Move files created yesterday

[skysel]

Hi, I get this output:

Yesterdays Date: 20100125

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.DocumentManagement-20100126-1.log File Date: 20100126

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100125-1.log File Date: 20100125

Got You! WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100125-1.log

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100126-1.log File Date: 20100126

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100125-1.log File Date: 20100125

Got You! WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100125-1.log

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100126-1.log File Date: 20100126

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.SmartForms-20100125-1.log File Date: 20100125

Got You! WEB-01-w3wp-Ttk.Crm.SmartForms-20100125-1.log

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-Ttk.Crm.SmartForms-20100126-1.log File Date: 20100126

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-wwwroot-20100125-2.log File Date: 20100125

Got You! WEB-01-w3wp-wwwroot-20100125-2.log

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-wwwroot-20100126-1.log File Date: 20100126

File: C:\Program Files\Microsoft Dynamics CRM\Trace\WEB-01-w3wp-wwwroot-20100126-2.log File Date: 20100126

It appears it should work, but for some strange reason it won't. I'm off from work for today, so we can continue this tomorrow

This is ridiculous! The last script I posted worked fine when I tried moving files from a sub-directory on my Desktop to my Desktop.

skysel, run waters script, post the output and let's see what the hell is going on...

[James]

Every time it outputs "Got you!" that means the match has been made and the file should move! We could do a nice test now to see if the file has been moved by doing this. Wait nevermind, I've just seen this line:

If @error > 0 Then FileWriteLine($Logfile,"Error " & @error & " when moving file " & $srcfolder & "\" & $FileList[$i])

And now, as there were no errors, we have to assume that there is something wrong with the server. If the files are matched, the date works, then there must be a server fault.

Right, so I've commented everything on the script and made a couple of changes. It now logs the file if it wasn't found. Also, if the directory the file is supposed to be moved to doesn't exist, it creates it - just in case.

#include <Date.au3>
#include <File.au3>

$srcfolder = "C:\Program Files\Microsoft Dynamics CRM\Trace" ; Set the source folder
$Logfile = "C:\temp\autoit.txt" ; Set the log file
$FileList = _FileListToArray($srcfolder) ; List all files in the array
$arTime = StringSplit(_DateAdd("D", -1, _NowCalcDate()), "/") ; Split yesterdays date up by the / delimeter
Dim $newTime
For $a = 1 To UBound($arTime) - 1
    $newTime &= $arTime[$a] ; Everytime we find a piece of the date, concatenate it
Next
FileDelete($Logfile) ; Delete the log file
FileWriteLine($Logfile, "Yesterdays Date: " & $newTime) ; Write yesterdays date to it

For $i = 1 To UBound($FileList) - 1 ; For each file in the array
    $FileTime = StringTrimRight(FileGetTime($srcfolder & "\" & $FileList[$i], 0, 1), 6) ; Get its creation date as a string and trim the time off
    FileWriteLine($Logfile, "File: " & $srcfolder & "\" & $FileList[$i] & " File Date: " & $FileTime & @CRLF) ; Write the log file
    If $FileTime = $newTime Then ; If the file date matches the current date
        FileWriteLine($Logfile, "Found file: " & $FileList[$i] & @CRLF)
        FileMove($srcfolder & "\" & $FileList[$i], "\\server.local\TraceLogs\", 8) ; Move the file
        If @error Then FileWriteLine($Logfile, "Error " & @error & " when moving file " & $srcfolder & "\" & $FileList[$i]) ; If there is an error, log it
    Else
        FileWriteLine($Logfile, "Could not find file: "  & $srcfolder & "\" & $FileList[$i] & @CRLF) ; If the file wasn't found, log it
    EndIf
Next

Edited January 26, 2010 by JamesBrooks

[skysel]

Ok this is really weird. Script now moved some files (2-3, but should move more)... The output is logged as:

Yesterdays Date: 20100126
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.DocumentManagement-20100126-1.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-Ttk.Crm.DocumentManagement-20100126-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.DocumentManagement-20100127-1.log File Date: 20100127
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.DocumentManagement-20100127-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100125-1.log File Date: 20100125
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100125-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100126-1.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100126-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100127-1.log File Date: 20100127
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.FraudPrevention-20100127-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100125-1.log File Date: 20100125
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100125-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100126-1.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-Ttk.Crm.GetCustomerNumbers-20100126-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100125-1.log File Date: 20100125
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100125-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100126-1.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100126-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100127-1.log File Date: 20100127
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-Ttk.Crm.SmartForms-20100127-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100125-2.log File Date: 20100125
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100125-2.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100126-1.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-wwwroot-20100126-1.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100126-2.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-wwwroot-20100126-2.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100126-3.log File Date: 20100126
Found file: CRM-WEB-01-w3wp-wwwroot-20100126-3.log
File: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100127-1.log File Date: 20100127
Could not find file: C:\Program Files\Microsoft Dynamics CRM\Trace\CRM-WEB-01-w3wp-wwwroot-20100127-1.log

Every time it outputs "Got you!" that means the match has been made and the file should move! We could do a nice test now to see if the file has been moved by doing this. Wait nevermind, I've just seen this line:

If @error > 0 Then FileWriteLine($Logfile,"Error " & @error & " when moving file " & $srcfolder & "\" & $FileList[$i])

And now, as there were no errors, we have to assume that there is something wrong with the server. If the files are matched, the date works, then there must be a server fault.

Right, so I've commented everything on the script and made a couple of changes. It now logs the file if it wasn't found. Also, if the directory the file is supposed to be moved to doesn't exist, it creates it - just in case.

#include <Date.au3>
#include <File.au3>

$srcfolder = "C:\Program Files\Microsoft Dynamics CRM\Trace" ; Set the source folder
$Logfile = "C:\temp\autoit.txt" ; Set the log file
$FileList = _FileListToArray($srcfolder) ; List all files in the array
$arTime = StringSplit(_DateAdd("D", -1, _NowCalcDate()), "/") ; Split yesterdays date up by the / delimeter
Dim $newTime
For $a = 1 To UBound($arTime) - 1
    $newTime &= $arTime[$a] ; Everytime we find a piece of the date, concatenate it
Next
FileDelete($Logfile) ; Delete the log file
FileWriteLine($Logfile, "Yesterdays Date: " & $newTime) ; Write yesterdays date to it

For $i = 1 To UBound($FileList) - 1 ; For each file in the array
    $FileTime = StringTrimRight(FileGetTime($srcfolder & "\" & $FileList[$i], 0, 1), 6) ; Get its creation date as a string and trim the time off
    FileWriteLine($Logfile, "File: " & $srcfolder & "\" & $FileList[$i] & " File Date: " & $FileTime & @CRLF) ; Write the log file
    If $FileTime = $newTime Then ; If the file date matches the current date
        FileWriteLine($Logfile, "Found file: " & $FileList[$i] & @CRLF)
        FileMove($srcfolder & "\" & $FileList[$i], "\\server.local\TraceLogs\", 8) ; Move the file
        If @error Then FileWriteLine($Logfile, "Error " & @error & " when moving file " & $srcfolder & "\" & $FileList[$i]) ; If there is an error, log it
    Else
        FileWriteLine($Logfile, "Could not find file: "  & $srcfolder & "\" & $FileList[$i] & @CRLF) ; If the file wasn't found, log it
    EndIf
Next

[water]

Script now moved some files (2-3, but should move more)...

According to your log file it should have moved 7 files. How many did it actually move (2 or 3?) and how many should it move (7 or more?)

Could you please be as specific as possible?

Edited January 27, 2010 by water

[James]

Urgh, not this problem again.

@water, do you agree with me that this has to be a server issue more than an "us" being bad coders?

[skysel]

Hah, I figured out what was wrong! On the FileMove function, I've added flag 1 (means overwrite existing files, etc). And now the script works great... go figure? Don't know what and why but it is working as it should. Thank you both for your extensive help!

[James]

Hah, I figured out what was wrong! On the FileMove function, I've added flag 1 (means overwrite existing files, etc). And now the script works great... go figure? Don't know what and why but it is working as it should. Thank you both for your extensive help!

Edited January 27, 2010 by JamesBrooks

[water]

I agree whole-heartedly!

[skysel]

James, is it that bad? Yeah I really don't know why the flag 1 on FileMove - because when the files moved they couldn't exist already on destination folder so files should get moved without overwrite flag! It really puzzles me

[James]

James, is it that bad? Yeah I really don't know why the flag 1 on FileMove - because when the files moved they couldn't exist already on destination folder so files should get moved without overwrite flag! It really puzzles me

It's kind of annoying. A tiny issue like that took three of us hours to fix.

I'd either completely ignore the flag or set it or set it to 9:

1 = overwrite existing files 8 = Create destination directory structure if it doesn't exist (See Remarks).

So 1+8 = Create/Overwrite if it doesn't exist Edited January 27, 2010 by JamesBrooks

[skysel]

Haha, mabye that feature should be implemented in the next release of auto-it .. combining flags like you said.. 1+8=9

[James]

Haha, mabye that feature should be implemented in the next release of auto-it .. combining flags like you said.. 1+8=9

What? You already can.

[water]

Haha, mabye that feature should be implemented in the next release of auto-it .. combining flags like you said.. 1+8=9

You can already use it. Set the flag to 9 and it works!

[water]

I get off this topic . Otherwise I fear to get brain cancer

I need all my neurons for the Active Directory UDF (see signature).

Edited January 27, 2010 by water

[skysel]

Oops, I didn't know that you can actualy combine flags... .

Again, thank you both for your help!