Quick debug request for a small script

[drx]

Morning folks,

New to the forum and the program, so I'll say Hello! But to the point. Got a simple script here I am putting in my new images, but it keeps giving me the error:

"Line 4 (File""): Error:Illegal text at the end of statement (one statement per line)"

I'm not the best coder around, but I don't have any text at the end of this code that I can see. Can anyone spot the issue? Thanks in advance....

If FileExists("C:\temp\setup\Setup.exe") Then
RunWait("C:\temp\setup\Setup.exe")
Msgbox(0,"First Install","Application Setup Completed Succesfully! Starting Next Instalation...")
else call(_Error)
EndIf
If FileExists("C:\temp\setup2.exe") Then
RunWait("C:\temp\setup2.exe")
MsgBox(0,"Second Install","All Installations completed Succesfully! Exiting Script")
else call(_Error)
EndIf
Func _Error()
    MsgBox(0,"Setup","One or more required files are not found. Installation Aborted!")
    Exit
EndFunc

[water]

Split the lines "else call(_Error)" into two lines:

If FileExists("C:\temp\setup\Setup.exe") Then
    RunWait("C:\temp\setup\Setup.exe")
    MsgBox(0, "First Install", "Application Setup Completed Succesfully! Starting Next Instalation...")
Else
    Call("_Error")
EndIf
If FileExists("C:\temp\setup2.exe") Then
    RunWait("C:\temp\setup2.exe")
    MsgBox(0, "Second Install", "All Installations completed Succesfully! Exiting Script")
Else
    Call("_Error")
EndIf
Func _Error()
    MsgBox(0, "Setup", "One or more required files are not found. Installation Aborted!")
    Exit
EndFunc   ;==>_Error

[Melba23]

drx,

Welcome to the AutoIt forum.

There is nothing at the end of your code, but the error tells you to look at Line 4:

else call(_Error)

You need to have the function call on a separate line to the Else - like this:

If FileExists("C:\temp\setup\Setup.exe") Then
    RunWait("C:\temp\setup\Setup.exe")
    MsgBox(0, "First Install", "Application Setup Completed Succesfully! Starting Next Instalation...")
Else
    _Error()
EndIf
If FileExists("C:\temp\setup2.exe") Then
    RunWait("C:\temp\setup2.exe")
    MsgBox(0, "Second Install", "All Installations completed Succesfully! Exiting Script")
Else
    _Error()
EndIf

Func _Error()
    MsgBox(0, "Setup", "One or more required files are not found. Installation Aborted!")
    Exit
EndFunc   ;==>_Error

By the way, there is no need to use Call - that should only used when you are evaluating a variable which holds the function name. You just use the function name directly as shown above.

M23

[drx]

Is that all?? Just split the lines eh? Man that's to simple to work :]

Thanks guys!

[water]

Yeah, it's that simple!

The error message is exactly telling what's wrong. A look in the helpfile tells you the syntax of the statement. That's all

[drx]

I was looking at a tutorial file that used the wrong syntax, took for granted they wouldnt' have typos.....lesson learned :]