Help Please

[Bert]

I haven't looked at the script but could you on exit do some type of logging to see what is hanging? Could it be a connection that is having a hard time closing? Not an expert in this area and I may be completely off base so forgive me if I speak out of turn.

[Iceman682]

Thanks, I'll give it a try this evening

[Iceman682]

Case $BOK
Local $sObject = GUICtrlRead($IObject)
Local $ssComputer = GUICtrlRead($ComputerToMove)
Local $hSelection = _GUICtrlTreeView_GetSelection($hTree)
If $hSelection = 0 Then
MsgBox(64, "Error", "You must select an OU!")
Endif
For $i = 1 To $aTreeView[0][0]
If $hSelection = $aTreeView[$i][2] Then ExitLoop
Next
Local $sOU = $aTreeView[$i][1]
ExitLoop
EndSwitch
WEnd

I think I'm missing something as I get the msgbox when no OU is selected and the move and update button is pressed but then it exits so its not looping back. What am I missing?

Edited October 24, 2012 by Iceman682

[Iceman682]

Case $BOK
Local $sObject = GUICtrlRead($IObject)
Local $ssComputer = GUICtrlRead($ComputerToMove)
Local $hSelection = _GUICtrlTreeView_GetSelection($hTree)


If $hSelection = 0 Then
MsgBox(64, "Error", "You must select an OU!")
Else

For $i = 1 To $aTreeView[0][0]
If $hSelection = $aTreeView[$i][2] Then ExitLoop
Next
Local $sOU = $aTreeView[$i][1]
ExitLoop
EndIf
EndSwitch
WEnd

It seems I got it working, I hope it's the best way!

Edited October 24, 2012 by Iceman682

[Bowmore]

You could also have used continueloop

If $hSelection = 0 Then
  MsgBox(64, "Error", "You must select an OU!")
  Continueloop
Endif

[water]

Looks good. I think this is the way it's being done in my example script too.

[Iceman682]

Func _AddAdmins($InputUserAdmin)
GUISetState(@SW_HIDE, $localAdminsGUI)
RunWait(@ComSpec & " /c " & "Net localgroup Administrators " & $HelpDesk & " /add", "", @SW_HIDE)
RunWait(@ComSpec & " /c " & "Net localgroup Administrators " & $InputUserAdmin & " /add", "", @SW_HIDE)
MsgBox(0, "", "Authorised accounts successfully added to the Administrators Group")
GUISetState(@SW_SHOW, $localAdminsGUI)
EndFunc ;==>_AddAdmins

Func _AddPowerUsers($InputPowerUser)
GUISetState(@SW_HIDE, $localAdminsGUI)
RunWait(@ComSpec & " /c " & "Net localgroup Administrators " & $HelpDesk & " /add", "", @SW_HIDE)
RunWait(@ComSpec & " /c " & '"Net localgroup "Power Users" "' & $InputPowerUser & " /add", "", @SW_HIDE)
MsgBox(0, "", "Authorised accounts successfully added to the Administrators and Power User Group")
GUISetState(@SW_SHOW, $localAdminsGUI)
EndFunc ;==>_AddPowerUsers

I seem to have found another issue that hopefully someone could assist.

As #RequiresAdmin is inserted, my script pops up the UAC prompts after the domain join and subsequent reboot asking for elevated credentials, unfortunatly when these are inserted it fails.

After removing the #RequiresAdmin the UAC prompts are gone, however when a domain user is added to the local Administrators Group or the Power Users Group the user names are not inserted into the respective groups. (due to it requiring the #RequiresAdmin)

Any assistance will be most welcome.

Edited October 26, 2012 by Iceman682