Sign in to follow this  
Followers 0
kor

array subscript dimension range exceeded

8 posts in this topic

I am getting this error in my compiled script, but the same script when running from scite I don't see the problem.

It reports the line number as 9,085 but my script is only about 100 lines of code.

Since this only seems to happen after I compile it can anyone offer some things I can look for that might help me troubleshoot. Any code examples of good error checking that I can build in so I can debug after it's compiled?

Share this post


Link to post
Share on other sites



How should we help without seing your code?

I lost my crystal ball last week ;)


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

#3 ·  Posted (edited)

#AutoIt3Wrapper_Change2CUI=y ; allows you to output console to command window
#include <AD.au3>
#include <File.au3>
#include <Array.au3>

; #####################################################################
; ### Set Run Mode                                                  ###
; ### 0 = Production Mode [DEFAULT]                                 ###
; ### 1 = Verbose Production Mode                                   ###
; ### 2 = Logging Only                                              ###
; ### 3 = Verbose Logging Only                                      ###
Global $iRunMode = 0 ;                                              ###
; ### Set Production Mode                                           ###
; ### 0 = All [DEFAULT]                                             ###
; ### 1 = Teachers Only                                             ###
; ### 2 = School Admins Only                                        ###
; ### 3 = Departments Only                                          ###
Global $iRunSection = 1 ;                                           ###
; #####################################################################

; ###########################################################################################################################################################################
; ## DO NOT MODIFY SCRIPT BELOW THIS LINE ###################################################################################################################################
; ###########################################################################################################################################################################
Global $sDepartmentQuery = "(&(objectCategory=person)(objectClass=user)(!userAccountControl:1.2.840.113556.1.4.803:=2)(!company=stu)(!(!company=*)))", _ ; LDAP Query | person, user, not disabled, not teacher, not student, company not null
$sSchoolQuery = "(&(objectCategory=person)(objectClass=user)(!userAccountControl:1.2.840.113556.1.4.803:=2)(!company=admin)(!company=stu)(!(!company=*)))", _ ; LDAP Query | person, user, not disabled, not admin, not student, company not null
$aUsers, $aDepartments, $aUserGroups, $sText, $sType, $aSchools, $aAdmins, $aTeachers, $aInput, $aAllOtherAdmins, $iRunMode, $hLogFile

If @Compiled Then
    Switch $CmdLine[0]
        Case 0 ; if no arguments provided set defaults
            $iRunMode = 0
            $iRunSection = 0
        Case 1, 3 To 64 ; if too few or too many arguments
            ;_ConsoleHelp()
        Case 2
            If StringRegExp($CmdLine[1], "[0-3]") > 0 And StringRegExp($CmdLine[2], "[0-3]") > 0 Then ; check command line options for valid arguments
                $iRunMode = $CmdLine[1]
                $iRunSection = $CmdLine[2]
            Else
                ;_ConsoleHelp()
            EndIf
    EndSwitch
EndIf

_AD_Open() ; open connection to Active Directory
$hLogFile = FileOpen(@ScriptDir & "\GMAR-log.log", 10) ; create log file
_VerboseLog("[VERBOSE] - Begin")

Switch $iRunSection
    Case 0 ; all
        _Teachers()
        ;_Admins()
        ;_Departments()
    Case 1 ; teachers only
        _Teachers()
    Case 2 ; school admins only
        _Admins()
    Case 3 ; departments only
        _Departments()
    Case Else
        _Log("[ERROR] Unknown Production Mode")
        Exit(1)
EndSwitch

Func _Teachers()
    _Log("[INFO][BEGIN TEACHERS]")
    _Log("[INFO][Running Teacher LDAP Query]")
    $aUsers = _AD_GetObjectsInOU("", $sSchoolQuery, 2, "sAMAccountName,company,department,physicalDeliveryOfficeName,title", "") ; query AD (4.439s), not sorting to save 500ms
    ; $aUsers[$i][0] = sAMAccountName (username)
    ; $aUsers[$i][1] = company (TCH, Admin, Stu, Contractor)
    ; $aUsers[$i][2] = department
    ; $aUsers[$i][3] = physicalDeliveryOfficeName (site)
    ; $aUsers[$i][4] = title (job title)

    _Log("[INFO][Reading Schools INI Section]")
    $aSchools = IniReadSection(@ScriptDir & "\GMAR-settings.ini", "Schools") ; read ini file for list of schools
    _RemoveQuotes($aSchools)
    ; $aSchools[$i][0] = school number
    ; $aSchools[$i][1] = school group prefix

    _Log("[INFO][Reading Teachers INI Section]")
    $aTeachers = IniReadSection(@ScriptDir & "\GMAR-settings.ini", "Teachers") ; read ini file for teacher group name
    _RemoveQuotes($aTeachers)
    ; $aTeachers[$i][0] = company
    ; $aTeachers[$i][1] = group name

    _Log("[INFO][Running Add/Remove Checks]")
    _VerboseLog("[VERBOSE] - Teacher Array contains " & UBound($aUsers) - 1 & " objects")
    _VerboseLog("[VERBOSE] - School Array contains " & UBound($aSchools) - 1 & " objects")
    For $i = 1 To UBound($aUsers) - 1 ; loop for each teacher user
        _VerboseLog("[VERBOSE] - User " & $i & " - " & $aUsers[$i][0])
        For $n = 1 to UBound($aSchools) - 1 ; loop for each school number
            If StringInStr($aUsers[$i][3], $aSchools[$n][0]) > 0 Then ; if teachers location matches school number
                If _AD_IsMemberOf($aSchools[$n][1] & " - " & $aTeachers[1][1], $aUsers[$i][0]) <> 1 Then ; if user is not already a member of the group
                    _Log("[ADD] - " & $aUsers[$i][0] & " - [TO] - " & $aSchools[$n][1] & " - " & $aTeachers[1][1])
                    If $iRunMode < 2 Then
                        _AD_AddUserToGroup($aSchools[$n][1] & " - " & $aTeachers[1][1], $aUsers[$i][0]) ; add user to group
                        If @error Then _Log("[ERROR][ADD] - " & $aUsers[$i][0] & " - [TO] - " & $aSchools[$i][1] & " - " & $aTeachers[1][1])
                    EndIf
                Else
                    _VerboseLog("[VERBOSE][SKIP] - " & $aUsers[$i][0] & " - [MEMBER] - " & $aSchools[$n][1] & " - " & $aTeachers[1][1])
                EndIf
            ElseIf StringInStr($aUsers[$i][3], $aSchools[$n][0]) = 0 Then ; if teachers location does not match school number
                If _AD_IsMemberOf($aSchools[$n][1] & " - " & $aTeachers[1][1], $aUsers[$i][0]) = 1 Then ; if user is a member of the group
                    _Log("[REMOVE] - " & $aUsers[$i][0] & " - [FROM] - " & $aSchools[$n][1] & " - " & $aTeachers[1][1])
                    If $iRunMode < 2 Then
                        _AD_RemoveUserFromGroup($aSchools[$i][1] & " - " & $aTeachers[1][1], $aUsers[$i][0]) ; remove user to group
                        If @error Then _Log("[ERROR][REMOVE] - " & $aUsers[$i][0] & " - [FROM] - " & $aSchools[$i][1] & " - " & $aTeachers[1][1])
                    EndIf
                Else
                    _VerboseLog("[VERBOSE][SKIP] - " & $aUsers[$i][0] & " - [NOT MATCH] - " & $aSchools[$n][1] & " - " & $aTeachers[1][1])
                EndIf
            EndIf
        Next
    Next
    _Log("[INFO][END TEACHERS]")
EndFunc   ;==>_Teachers

Func _Log($sText = "")
    ; writes script output to console, command window is compiled, and file
    Select
        Case StringInStr($sText, "ERROR") > 0
            $sPrefix = "! " ; red for error
        Case StringInStr($sText, "ADD") > 0
            $sPrefix = "+ " ; blue for add
        Case StringInStr($sText, "REMOVE") > 0
            $sPrefix = "- " ; orange for move
        Case Else
            $sPrefix = "> " ; blue for info
    EndSelect
    ConsoleWrite($sPrefix & $sText & @CRLF)
    _FileWriteLog($hLogFile, $sText)
EndFunc   ;==>_Log

Func _VerboseLog($sText = "")
    ; writes script output to console, command window is compiled, and file
    If $iRunMode = 1 Or $iRunMode = 3 Then
        ConsoleWrite($sText & @CRLF)
        _FileWriteLog($hLogFile, $sText)
    EndIf
EndFunc   ;==>_Log

Func _RemoveQuotes(ByRef $aInput)
    ; removes quotes from INI file just in case someone adds them
    For $i = 1 To UBound($aInput) - 1
        $aInput[$i][0] = StringReplace($aInput[$i][0], '"', "")
        $aInput[$i][1] = StringReplace($aInput[$i][1], '"', "")
    Next
EndFunc   ;==>_RemoveQuotes

_AD_Close() ; close connection to Active Directory
FileClose($hLogFile) ; close log file
_VerboseLog("[VERBOSE] - End")

Edited by kor

Share this post


Link to post
Share on other sites

Can you please tell us which version of AutoIt and the AD UDF you run?


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

AutoIT 3.3.12.0

AD 1.4.1.0

Share this post


Link to post
Share on other sites

I would insert

FileWriteLine("C:\temp\log.txt", "unique number or text")

before each function accessing an array so you know where the script fails. Then in a second run write the used indices of this statement to the same file.


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

I would insert

FileWriteLine("C:\temp\log.txt", "unique number or text")

before each function accessing an array so you know where the script fails. Then in a second run write the used indices of this statement to the same file.

I lost you at the second sentence. Can you provide an example of what you mean by write the used indices?

Share this post


Link to post
Share on other sites

This line accesses an array:

If StringInStr($aUsers[$i][3], $aSchools[$n][0]) > 0 Then ; if teachers location matches school number
So I would insert the FileWrite before this (and all other lines accessing an array):

FileWriteLine("C:\temp\log.txt", "27") ; A unique number or text so you know where your script crashed
If StringInStr($aUsers[$i][3], $aSchools[$n][0]) > 0 Then ; if teachers location matches school number
If the last line written to the log is "27" you know where it crashed.

Now add a new FileWrite line to log the relevant indexes:

FileWriteLine("C:\temp\log.txt", "27") ; A unique number or text so you know where your script crashed
FileWriteLine("C:\temp\log.txt", "$i: " & $i & ", $n: " & $n) ; All indices used in the next statement
If StringInStr($aUsers[$i][3], $aSchools[$n][0]) > 0 Then ; if teachers location matches school number
Now you should have an idea what goes wrong.

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0