Sign in to follow this  
Followers 0
DrewSS

Multiple CSV into same Excel sheet

8 posts in this topic

#1 ·  Posted (edited)

Hello,

Sorry this seems like it should be simple but I'm having a hard time...

I'm trying to run some concatenation on every file in a folder, then import the results separated with a comma delimiter into a single excel sheet. 

The file concatenation removes quotation marks from the files which works fine, and the import into excel part works fine, but I cannot get it to perform those tasks on every file in the target folder.

#include <Excel.au3>
#include <Array.au3>
#include <File.au3>
#include <MsgBoxConstants.au3>
Dim $x = 1
Dim $y = 1


Local $oExcel = _ExcelBookNew() 
$FileList = _FileListToArray("C:\Program Files\AutoIt3\GETSYS2\")

$sFile = $FileList & @CRLF

For $i1 = 0 To UBound($FileList) - 1
$sExcel = @ScriptDir & "Excel.xls"
$read = FileRead($sFile)
StringReplace($sFile, '"', '')
$sArray = StringSplit($read, @CRLF)

For $i = 1 To $sArray[0]
    If $sArray = "" Then ContinueLoop
    $aTemp = StringSplit($sArray, ",")

    For $a = 1 To $aTemp[0]
        _ExcelWriteCell($oExcel, $aTemp[$a], $y, $x) ;Write to the Cell
        $x += 1

    Next
    $y += 1
    $x = 1

Next
_ExcelBookSaveAs($oExcel, @ScriptDir & $sExcel, "xls", 0, 1) 
_ExcelBookClose($oExcel)

Any thoughts or recommendations?

Edit: that code is botched, was trying new things.

Edited by DrewSS

Share this post


Link to post
Share on other sites



You add @Scriptdir in two different places in your script to $sExcel and a '' is missing after @Scriptdir.


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

#include <Excel.au3>
#include <Array.au3>
#include <File.au3>
#include <MsgBoxConstants.au3>
Dim $x = 1
Dim $y = 2
$sFilePath1 = @ScriptDir & "\wes2009.xls"  ; source targets
Local $oExcel = _ExcelBookOpen($sFilePath1) ;Create new book, make it visible

;$xml_path_in = InputBox("CSV files", "Enter complete folder path for your folder")
$xml_path_in = @ScriptDir & '\'

$FileList = _FileListToArray($xml_path_in, "*", 1)

For $fileInf in $FileList
$sFile = $fileInf
$read = FileRead($sFile)
StringReplace($read, '"', '')
$sArray = StringSplit($read, @CRLF)

For $i = 1 To $sArray[0]
    If $sArray[$i] = "" Then ContinueLoop
    $aTemp = StringSplit($sArray[$i], ",")
    For $a = 1 To $aTemp[0]
        _ExcelWriteCell($oExcel, $aTemp[$a], $y, $x) ;Write to the Cell
        $x += 1
    Next
    $y += 1
    $x = 1
Next

;MsgBox(0, "Exiting", "Press OK to Save File and Exit")

Next

I got the import of multiple CSV files into 1 excel sheet going with the code above; however, the StringReplace statement (line 18) is not saving the results to the files before the files are read into an array (line 19).

Share this post


Link to post
Share on other sites

Needs to be:

$read = StringReplace($read, '"', '')
1 person likes this

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

Durp >.<

Thank you :-D

Now if only it wouldnt take 45 minutes to copy 30,000 files!

Share this post


Link to post
Share on other sites

That's about 4.5 files per second. Not too bad.

To improve performance, try to avoid I/Os.


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

I just noticed that you use the old Excel UDF. If possible update to the latest version of AutoIt. The new Excel UDF that comes witjh this new version allows to write a single cell, a 1D array or a 2D array with function _Excel_RangeWrite. This function is about 20 to 100 times faster compared to the old _ExcelWriteCell.

1 person likes this

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

Here's another way of combining all of the files into one before processing.

Run(@ComSpec & ' /k copy "' & $xml_path_in & '* ' & $$xml_path_out & 'NewFile.csv', "", @SW_HIDE)

This way you only have to process the file once instead of 30,000 times opening and closing files. Plus in the latest release version of _FileReadToArray can do the CSV splitting internally.

1 person likes this

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0