Jump to content
Sign in to follow this  
StillLearningThisStuff

Merge 2 x 1d temp arrays into one 2d array

Recommended Posts

StillLearningThisStuff

Hello all,

Summary: I have a basic piece of code that is to be a part of a much larger project; I just can't seem to get the right output. I'm retrieving two lots of powershell data into 2 x 1d arrays and trying to add them into a single 2d array. Retrieving the data together into the 2d array seemed harder, due to the application names varying too much to string split. Data being pulled is application name and GUID. From here I will use this info in a drop down box and an uninstall button to run the required command to remove the selected software (have this sorted already).

Problem: When I merge the data it doesn't put the application name and GUID on the same row in differing columns eg. my test box has 24 applications plus some superfluous data from Powershell to be cleaned up by the _arraydeletes. Instead I end up with an array with 58 rows and 2 columns; whereas my temp 1d arrays have 28 rows. As you can see I've tried both _ArrayInsert and _ArrayAdd but I still get the same result.

Question: Is there something that I'm doing wrong in putting the data into the 2d array or do I just need to do some more post processing to tidy it up and align the names and GUIDs?

Code:

#include <Array.au3>

$Cmd1 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select DisplayName" & Chr(34))
$Cmd2 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select ProdID" & Chr(34))

Global $aNameGUID[1][2]
;_ArrayDisplay($aNameGUID)
ReadApps($Cmd1,0)
;_ArrayDisplay($aNameGUID)
ReadApps($Cmd2,1)
_ArrayDisplay($aNameGUID)
Terminate()

Func ReadApps($Command,$col)
    $DOS = Run(@ComSpec & $Command, "", @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    ProcessWaitClose($DOS)
    $DOSOut = StdoutRead($DOS)
    ;MsgBox(0,"Data",$DOSOut) ;Show the line items that we want in the array
    Local $tmpArray = StringSplit(StringTrimRight(StringStripCR($DOSOut), StringLen(@CRLF)), @CRLF)
    If @error Then
        MsgBox(0,"FAIL","I failed to find objects")
        Exit
    Else
        _ArrayDisplay($tmpArray)
    EndIf
        ;_ArrayDelete($tmpArray, 3)
        ;_ArrayDelete($tmpArray, 2)
        ;_ArrayDelete($tmpArray, 1)
        ;$tmpArray[0] = $tmpArray[0] - 3
        For $i = 0 To UBound($tmpArray) - 1
            ;_ArrayAdd($aNameGUID, $tmpArray[$i], $col)
            _ArrayInsert($aNameGUID, 0, $tmpArray[$i], $col)
        Next
    $tmpArray = 0
EndFunc ;==>ReadApps

While 1
    Sleep(1500)
WEnd

Func Terminate()
    Exit 0
EndFunc   ;==>Terminate

Thanks in advance,

Luxyboy

Edited by StillLearningThisStuff
update

Share this post


Link to post
Share on other sites
spudw2k

Could you not retrieve both the DisplayName and ProdID in a single query?

Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like "{*}"} | select DisplayName, ProdID | Format-Table

You could also bypass using PowerShell and just query WMI directly from AutoIt (via COM object) and then format the data any way you want/need.

edit: WMI example

#include <Array.au3>  ;only needed for demo

$objWMIService = WMIService(@ComputerName)  ;WMIService Object - Establish Connection
If $objWMIService = 0 Then Exit

Local $strData[2]= ["DisplayName","ProdID"]  ;Data to Return from WMI Query

$arrResults = WMIQuery($objWMIService,"SELECT * FROM Win32Reg_AddRemovePrograms",$strData)  ;Run WMI Query against WMIService Object
$objWMIService = 0  ;Termninate WMIService Object

_ArrayDisplay($arrResults)

Func WMIService($host) ;Connects to WMI Service
    $objWMIService = ObjGet("winmgmts:{impersonationLevel=impersonate}!\\" & $host & "\root\cimv2")
    If not IsObj($objWMIService) Then return 0
    return $objWMIService
EndFunc

Func WMIQuery($objWMIService,$strWMIQuery,$arrData) ;Perform WMI Query with Query String and Data Return Parameters
    If not IsArray($arrData) then return 0
    $colItems = $objWMIService.ExecQuery ($strWMIQuery)  ;Execute query against WMI Service Object
    $iCount = $colItems.count
    If $iCOunt <= 0 Then return 0
    $iBound = UBound($arrData)
    Local $arrResults[$colItems.count+1][$iBound] ;Two-Dimension Array to store query Results

    For $i = 0 to $iBound-1
        $arrResults[0][$i] = $arrData[$i]
    Next

    Local $iIdx = 1
    For $objItem in $colItems
        For $i = 0 to $iBound - 1  ;Loop through WMI Query Results
            ;$arrResults[$iIdx][$i] = $arrData[$i]  ;Property/Data Name
            $arrResults[$iIdx][$i] = Execute("$objitem." & $arrData[$i])  ;Result
        Next
        $iIdx += 1
    Next

    return $arrResults  ;Return Result Array
EndFunc

 

Edited by spudw2k

Share this post


Link to post
Share on other sites
UEZ

This should do it:

Func ReadApps($Command,$col)
    $DOS = Run(@ComSpec & $Command, "", @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    ProcessWaitClose($DOS)
    $DOSOut = StdoutRead($DOS)
    ;MsgBox(0,"Data",$DOSOut) ;Show the line items that we want in the array
    Local $tmpArray = StringSplit(StringTrimRight(StringStripCR($DOSOut), StringLen(@CRLF)), @CRLF)
    If @error Then
        MsgBox(0,"FAIL","I failed to find objects")
        Exit
    Else
        _ArrayDisplay($tmpArray)
    EndIf
        ;_ArrayDelete($tmpArray, 3)
        ;_ArrayDelete($tmpArray, 2)
        ;_ArrayDelete($tmpArray, 1)
        ;$tmpArray[0] = $tmpArray[0] - 3
        If UBound($aNameGUID) < UBound($tmpArray) Then ReDim $aNameGUID[UBound($tmpArray)][2]
        For $i = 0 To UBound($tmpArray) - 1
            ;_ArrayAdd($aNameGUID, $tmpArray[$i], $col)
            ;_ArrayInsert($aNameGUID, 0, $tmpArray[$i], $col)
            $aNameGUID[$i][$col] = $tmpArray[$i]
        Next
    $tmpArray = 0
EndFunc ;==>ReadApps

 


Please don't send me any personal message and ask for support! I will not reply!

Selection of finest graphical examples at Codepen.io

The own fart smells best!
Her 'sikim hıyar' diyene bir avuç tuz alıp koşma!
¯\_(ツ)_/¯  ٩(●̮̮̃•̃)۶ ٩(-̮̮̃-̃)۶ૐ

Share this post


Link to post
Share on other sites
czardas

You can merge two 1D arrays to produce two columns like this, if that's what you want (see my signature).

#include 'ArrayWorkshop.au3'
Local $aTarget = ['a','b','c'], $aSource = [1,2,3]
_ArrayAttach($aTarget, $aSource, 2)

 

Edited by czardas

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Similar Content

    • lattey
      By lattey
      hi,
      i have checkboxes and each checkbox that checked, i put in array. 
      now, im stuck on how to loop the checked array and store in in one variable. what i can do now, is only write the result into a text file. 
      below is the code:
      #include <GUIConstantsEx.au3> ;~ #include <MsgBoxConstants.au3> #include <ButtonConstants.au3> #include <Array.au3> Global $Count = 3 Global $CheckBoxP[$Count] Global $step[$Count] global $array1[1] Global $ExitResult $hGUI = GUICreate("Summary Steps", 500, 400) GUISetFont(12, 400, "Tahoma") GUICtrlCreateLabel( "Please Select the Summary Steps for Script Check", 70, 20) GUISetFont(10, 400, "Tahoma") Global $array_Pstep[3] = ["fix2","fix1","fix3"] global $step[3] = ["2","3","4"] $Spacing = 50 For $i = 0 To UBound($array_Pstep) - 1 $CheckBoxP[$i] = GUICtrlCreateCheckbox($array_Pstep[$i], 80, $Spacing + (20 * $i), 65, 17) Next $submit = GUICtrlCreateButton("Submit",180, 280, 80, 30) $exit = GUICtrlCreateButton("Exit",180, 320, 80, 30) GUISetState() While 1 $Msg = GUIGetMsg() Select case $Msg=$submit For $i = 0 To $Count - 1 If GUICtrlRead($CheckBoxP[$i]) = $GUI_CHECKED Then _ArrayAdd($array1, $step[$i]) EndIf Next Global $logfilerray = @WorkingDir & "\checkedlist.txt" FileDelete ($logfilerray) Global $readlogfile = FileOpen($logfilerray,1) for $a = 1 to UBound($array1) - 1 ;~ $var=$array1[$a] FileWriteLine($readlogfile,$array1[$a]) Next FileClose($readlogfile) Exit case $Msg=$exit $ExitResult = MsgBox(1,"Summary Step", "Continue to Exit ?") if $ExitResult = 1 Then ;ok Exit EndIf Exit EndSelect WEnd  
    • omicron
      By omicron
      How do you perform a nested loop function with a multidimensional array from 2 lists.
      for i in list1
      (open file) extract variable
          while open for i in list 2
          (open file2) extract variable
       
      var1 + var2 = (search term)

      The list sizes will more than likely consist of different lengths.
       
      What is the best approach to accomplishing this method?
             
    • omicron
      By omicron
      Hello!

      I am working on a function that I am just getting lost on. The goal is a multiple nested loop.

      Here are the steps:
      Contents of file1.txt::
      [topic] var1=Name var2=OtherName var3=SomeotheName Contents of file2.txt::
      [subTopic] top=sub1 top2=sub2 top3=sub3 The Shell I am working from::
      #include <file.au3> $file = "c:\yourfile.txt" FileOpen($file, 0) For $i = 1 to _FileCountLines($file) $line = FileReadLine($file, $i) msgbox(0,'','the line ' & $i & ' is ' & $line) Next FileClose($file) Understanding however that the "msgbox" needs to then become a variable. in example the following::
      $file = "c:\yourfile.txt" FileOpen($file, 0) While true( prog.exe is running && "WinName" is open) do For $i = 1 to _FileCountLines($file) $line = FileReadLine($file, $i) ;Open File to log "current location of file 1" FileWriteLine ("filename", $i & ' is ' & $line) var = $line Next $file2 = "c:\yourfile.txt" FileOpen($file, 0) For $i = 1 to _FileCountLines($file) $line = FileReadLine($file, $i) ; OpenFile to log "Current location of file 2" FileWriteLine ("filename", $i & ' is ' & $line) Next FileClose($file2) FileClose($file) The goal in written form is the following ::

      While in "OpenWindow"
          read from file 1 starting at line 1 until end of file.
         file 1 is a list of names to be searched.
         With $line selected, add this element to the element in file 2.
       
      The search of a variables in list 1 and list 2 differ on the amount of posts that day. (This is not a web based platform, it is a game) I need to search 2 names and take a screenshot of the out put. The sizes of the names list depend on the activity of names at the time of search.
      This loop continues until all the names from both lists have been searched. Mostly in the format of::
      File1= item
      File2= Vendor
       
      Item + Vendor  ( Capture screen, scroll) -- Not sure how to detect if I need to scroll)
       
      Thank you for your help and support!
    • Skeletor
      By Skeletor
      Hi Virtual People,
      My array works perfectly fine. However, what is the best practice if the line in the array doesn't have the correct amount of columns and if I can add a placeholder?

       
      For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") Next  
    • MrCheese
      By MrCheese
      hi all,
      reviewing the forum, this thread is applicable: 
       
       
      I wanted to know if there is now a better way to do this?
      In essence, I load a tab delimited txt file into an array (works well). I used tab, as some fields in the original csv contains commas.
      However, I needed autoit to manipulate this array, and output it as a csv.
      IF my array contains items with a comma, without double quotes around the field, then how best do I get a csv out of this?
      My current workaround is to filewritefromarray tab delimited, then open it in excel and save as a csv. I will need to check this to see how the address fields behave that contain a comma.
       
      Any thoughts would be appreciated.
       
×