Sign in to follow this  
Followers 0
StillLearningThisStuff

Merge 2 x 1d temp arrays into one 2d array

4 posts in this topic

#1 ·  Posted (edited)

Hello all,

Summary: I have a basic piece of code that is to be a part of a much larger project; I just can't seem to get the right output. I'm retrieving two lots of powershell data into 2 x 1d arrays and trying to add them into a single 2d array. Retrieving the data together into the 2d array seemed harder, due to the application names varying too much to string split. Data being pulled is application name and GUID. From here I will use this info in a drop down box and an uninstall button to run the required command to remove the selected software (have this sorted already).

Problem: When I merge the data it doesn't put the application name and GUID on the same row in differing columns eg. my test box has 24 applications plus some superfluous data from Powershell to be cleaned up by the _arraydeletes. Instead I end up with an array with 58 rows and 2 columns; whereas my temp 1d arrays have 28 rows. As you can see I've tried both _ArrayInsert and _ArrayAdd but I still get the same result.

Question: Is there something that I'm doing wrong in putting the data into the 2d array or do I just need to do some more post processing to tidy it up and align the names and GUIDs?

Code:

#include <Array.au3>

$Cmd1 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select DisplayName" & Chr(34))
$Cmd2 = (" /c Powershell.exe " & Chr(34) & "Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like " & Chr(34) & Chr(123) & Chr(42) & Chr(125) & Chr(34) & "} | select ProdID" & Chr(34))

Global $aNameGUID[1][2]
;_ArrayDisplay($aNameGUID)
ReadApps($Cmd1,0)
;_ArrayDisplay($aNameGUID)
ReadApps($Cmd2,1)
_ArrayDisplay($aNameGUID)
Terminate()

Func ReadApps($Command,$col)
    $DOS = Run(@ComSpec & $Command, "", @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    ProcessWaitClose($DOS)
    $DOSOut = StdoutRead($DOS)
    ;MsgBox(0,"Data",$DOSOut) ;Show the line items that we want in the array
    Local $tmpArray = StringSplit(StringTrimRight(StringStripCR($DOSOut), StringLen(@CRLF)), @CRLF)
    If @error Then
        MsgBox(0,"FAIL","I failed to find objects")
        Exit
    Else
        _ArrayDisplay($tmpArray)
    EndIf
        ;_ArrayDelete($tmpArray, 3)
        ;_ArrayDelete($tmpArray, 2)
        ;_ArrayDelete($tmpArray, 1)
        ;$tmpArray[0] = $tmpArray[0] - 3
        For $i = 0 To UBound($tmpArray) - 1
            ;_ArrayAdd($aNameGUID, $tmpArray[$i], $col)
            _ArrayInsert($aNameGUID, 0, $tmpArray[$i], $col)
        Next
    $tmpArray = 0
EndFunc ;==>ReadApps

While 1
    Sleep(1500)
WEnd

Func Terminate()
    Exit 0
EndFunc   ;==>Terminate

Thanks in advance,

Luxyboy

Edited by StillLearningThisStuff
update

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

Could you not retrieve both the DisplayName and ProdID in a single query?

Get-WmiObject -Class win32reg_addremoveprograms | where {$_.ProdID -like "{*}"} | select DisplayName, ProdID | Format-Table

You could also bypass using PowerShell and just query WMI directly from AutoIt (via COM object) and then format the data any way you want/need.

edit: WMI example

#include <Array.au3>  ;only needed for demo

$objWMIService = WMIService(@ComputerName)  ;WMIService Object - Establish Connection
If $objWMIService = 0 Then Exit

Local $strData[2]= ["DisplayName","ProdID"]  ;Data to Return from WMI Query

$arrResults = WMIQuery($objWMIService,"SELECT * FROM Win32Reg_AddRemovePrograms",$strData)  ;Run WMI Query against WMIService Object
$objWMIService = 0  ;Termninate WMIService Object

_ArrayDisplay($arrResults)

Func WMIService($host) ;Connects to WMI Service
    $objWMIService = ObjGet("winmgmts:{impersonationLevel=impersonate}!\\" & $host & "\root\cimv2")
    If not IsObj($objWMIService) Then return 0
    return $objWMIService
EndFunc

Func WMIQuery($objWMIService,$strWMIQuery,$arrData) ;Perform WMI Query with Query String and Data Return Parameters
    If not IsArray($arrData) then return 0
    $colItems = $objWMIService.ExecQuery ($strWMIQuery)  ;Execute query against WMI Service Object
    $iCount = $colItems.count
    If $iCOunt <= 0 Then return 0
    $iBound = UBound($arrData)
    Local $arrResults[$colItems.count+1][$iBound] ;Two-Dimension Array to store query Results

    For $i = 0 to $iBound-1
        $arrResults[0][$i] = $arrData[$i]
    Next

    Local $iIdx = 1
    For $objItem in $colItems
        For $i = 0 to $iBound - 1  ;Loop through WMI Query Results
            ;$arrResults[$iIdx][$i] = $arrData[$i]  ;Property/Data Name
            $arrResults[$iIdx][$i] = Execute("$objitem." & $arrData[$i])  ;Result
        Next
        $iIdx += 1
    Next

    return $arrResults  ;Return Result Array
EndFunc

 

Edited by spudw2k

Share this post


Link to post
Share on other sites

This should do it:

Func ReadApps($Command,$col)
    $DOS = Run(@ComSpec & $Command, "", @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD)
    ProcessWaitClose($DOS)
    $DOSOut = StdoutRead($DOS)
    ;MsgBox(0,"Data",$DOSOut) ;Show the line items that we want in the array
    Local $tmpArray = StringSplit(StringTrimRight(StringStripCR($DOSOut), StringLen(@CRLF)), @CRLF)
    If @error Then
        MsgBox(0,"FAIL","I failed to find objects")
        Exit
    Else
        _ArrayDisplay($tmpArray)
    EndIf
        ;_ArrayDelete($tmpArray, 3)
        ;_ArrayDelete($tmpArray, 2)
        ;_ArrayDelete($tmpArray, 1)
        ;$tmpArray[0] = $tmpArray[0] - 3
        If UBound($aNameGUID) < UBound($tmpArray) Then ReDim $aNameGUID[UBound($tmpArray)][2]
        For $i = 0 To UBound($tmpArray) - 1
            ;_ArrayAdd($aNameGUID, $tmpArray[$i], $col)
            ;_ArrayInsert($aNameGUID, 0, $tmpArray[$i], $col)
            $aNameGUID[$i][$col] = $tmpArray[$i]
        Next
    $tmpArray = 0
EndFunc ;==>ReadApps

 


Please don't send me any personal message and ask for support! I will not reply!

Selection of finest graphical examples at Codepen.io

The own fart smells best!
Her 'sikim hıyar' diyene bir avuç tuz alıp koşma!
¯\_(ツ)_/¯

Share this post


Link to post
Share on other sites

#4 ·  Posted (edited)

You can merge two 1D arrays to produce two columns like this, if that's what you want (see my signature).

#include 'ArrayWorkshop.au3'
Local $aTarget = ['a','b','c'], $aSource = [1,2,3]
_ArrayAttach($aTarget, $aSource, 2)

 

Edited by czardas

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • jjohn
      By jjohn
      Hi all,
      I have the following code, basically, it populates an array with unique characters found in a string, but it turns out only one character is in the array, i don't want to think it is due to a bug of autoit at this point, so i need your help on why, please
      Dim $sx[0] Dim $cn $ss = "Xx" ConsoleWrite(StringLeft($ss, 1) & " " & StringRight($ss, 1) & @CRLF) ConsoleWrite(StringLeft($ss, 1) = StringRight($ss, 1) & @CRLF) ;here show X <> x ConsoleWrite(@CRLF) ;the following is to populate array $sx with different unique characters in $ss For $b = 1 To StringLen($ss) $flg = 0 For $a = 0 To UBound($sx) - 1 ;if asc(StringMid($ss,$b,1)) = asc($sx[$a]) Then ;if this line is used instead of the next, everything is fine If StringMid($ss, $b, 1) = $sx[$a] Then If StringMid($ss, $b, 1) = "x" Then ConsoleWrite("<<->>" & StringMid($ss, $b, 1) & " " & $sx[$a] & @CRLF) $flg = 1 ExitLoop EndIf Next If $flg = 0 Then $cn = $cn + 1 ReDim $sx[$cn] $sx[$cn - 1] = StringMid($ss, $b, 1) EndIf Next ConsoleWrite(UBound($sx) & @CRLF);list the ubound of $sx ;list what is in array $sx For $a = 0 To UBound($sx) - 1 ConsoleWrite($sx[$a] & @CRLF) Next same code in a file is attached as uniqueChar2Array.au3
    • FrancescoDiMuro
      By FrancescoDiMuro
      Good evening
      I was looking around the forum if I could find a function that allows to convert a string into a 2 dimensional array...
      The first column of the array is always the same, but the rows could change...
      I have a pattern like:

      Column A|Column B
      Static Text 1|Data 1
      Static Text 2|Data 2
      Static Text 3|Data 3
      Static Text 4|Data 4

      Where, Static Text (1...4) will be always the same, and I don't want to change them... But, Data 1...4 are dynamic fields... So, I could have the pattern above AND I coould have the pattern I'm going to show you right below

      Column A|Column B
      Static Text 1|Data 1
      Static Text 2|Data 2
      Static Text 3|Data 3
      Static Text 4|Data 4
      Static Text 1|Data 5
      Static Text 2|Data 6
      Static Text 3|Data 7
      Static Text 4|Data 8

      How can I do in this case?

      Thanks for everyone's help


       
    • ur
      By ur
      I have a string with comma seperated as below.
      Name="Test-win10x64,Test-win10x65,Test-win10x67"
      $machine_names = StringSplit($tempINIValue, ',', $STR_ENTIRESPLIT) with the above line i can get a single dimension array.
      But I want a tabular format array like 4X4 where I want to add the 4 single dimension arrays as different columns in them.
       
      Is there any option to do the same.
    • 232showtime
      By 232showtime
      im getting strange output in array display,$split_[1] is not properly aligned to other arrays and why guictrlsetdata is not writting any data if i put comma(,) at the end of the text in $Input1???
       
      #include <ButtonConstants.au3> #include <EditConstants.au3> #include <GUIConstantsEx.au3> #include <WindowsConstants.au3> #include <Array.au3> #Region ### START Koda GUI section ### Form=C:\Users\user\Desktop\Script\StringSplit.kxf $Form1 = GUICreate("Form1", 623, 449, 192, 114) $Input1 = GUICtrlCreateInput("50UGITQ421X, 50UGITQ422X, 50UGITQ423X, 50UGITQ427X, 50UGITQ431X, 50UGITQ435X, 50UGITQ436X, 50UGITQ437X, 50UGITQ441X, 50UGITQ445X, 50UGITQ449X, 50UGITQ453X, 50UGITQ454X, 50UGITQ455X, 50UGITQ459X", 24, 16, 553, 21) $Split = GUICtrlCreateButton("Split", 24, 48, 75, 25) $List1 = GUICtrlCreateList("", 24, 96, 553, 97) GUISetState(@SW_SHOW) #EndRegion ### END Koda GUI section ### While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE Exit Case $Split $read = GUICtrlRead($Input1) $split_ = StringSplit($read, ",") $Max = UBound($split_, 1) For $i = 1 To UBound($split_) - 1 ConsoleWrite($split_[$i] & @CRLF) ;~ ControlSetText($Form1, "", $List1, $split_[$i]) GUICtrlSetData($List1, $split_[$i]) ;~ GUICtrlSetData($List1, $split_[$i]) ;~ GUICtrlSetData($List1, $i) Next _ArrayDisplay($split_) EndSwitch WEnd  
    • hcI
      By hcI
      Hey !
      I was looking for an array display to see the result of StringSplit but when i called the <Array.au3>, an error is showing up when i try to launch the script.
      I took a screenshoot of the windows dialog box error : imp.bmp
      And when I look into the Array.au3 there is no error :
      Why is it doing this ?