while loop

[rkr]

hi, i am new to autoit. i prepared the attached code which will replace particular values in the file. the program works well in the first pass, but the while loop is not working in the second go. could anyone look into the attached code. If the ';#' in the code are replaced with '#', then the program works well.

sacs-read.au3

GMS Det Leg.txt

[Jos]

Please pay attention to the forum purpose when posting threads:

Quote

Do not create AutoIt-related topics here, use the AutoIt General Help and Support or AutoIt Technical Discussion forums.

Moved to support.

Jos

[BrewManNH]

You should be modifying the text file directly and not trying to automate Notepad.

[JLogan3o13]

@rkr it would be helpful if you explained just what you are trying to do, and what your expected outcome is - it may be clear to you, but not necessarily to others just from looking at your code. Also, there is bound to be a better way to do this if you share exactly what you are trying to accomplish. For example, just looking at the code, you can convert all of this:

run("notepad","",@SW_MAXIMIZE)
winwaitactive("Untitled - Notepad")
send("!F")
send("o")
winwaitactive("Open")
send($file_location)
Send("{ENTER}")
Send($file_name)
Send("{ENTER}")
WinWaitActive("GMS Det Leg.txt - Notepad")

To this:

ShellExecute("Notepad.exe", $file_location & $file_name)

We are happy to assist further, if you explain what you are trying to do in more detail. I am going to posit that your best bet will be reading the file into an array, and then changing the values accordingly. More information from you will help us help you.

[rkr]

8 hours ago, JLogan3o13 said:

@rkr it would be helpful if you explained just what you are trying to do, and what your expected outcome is - it may be clear to you, but not necessarily to others just from looking at your code. Also, there is bound to be a better way to do this if you share exactly what you are trying to accomplish. For example, just looking at the code, you can convert all of this:

run("notepad","",@SW_MAXIMIZE)
winwaitactive("Untitled - Notepad")
send("!F")
send("o")
winwaitactive("Open")
send($file_location)
Send("{ENTER}")
Send($file_name)
Send("{ENTER}")
WinWaitActive("GMS Det Leg.txt - Notepad")

To this:

ShellExecute("Notepad.exe", $file_location & $file_name)

We are happy to assist further, if you explain what you are trying to do in more detail. I am going to posit that your best bet will be reading the file into an array, and then changing the values accordingly. More information from you will help us help you.

i will try to explain it here in detail..

if you open the text file 'GMS Det Leg.txt'- it has 2 lines -> LOADCN   P   1.166  &      LOADCN   R   1.166  .. the autoit pgrm should open the notepad replace the numerals 1.166 based on an equation (here, just increase by 1 and 1.5 respectively for each lines) and the notepad is to be saved/closed. this should repeat till the top line become LOADCN   P   9.166 .. i believe my intention is clear... thanks for all suggestion  
   

[jchd]

You're still ignoring the best advice, already given here

Now, no your intend is unclear: as you repeatedly increment the same values in the same file, you could as well replace once by the final values (resp. 9.166 and 13.166). That, or save to distinct files at every step in your loop.

[careca]

If i was you, seeing that you really want to go that way, changing the file, i also wouldn't open the file with notepad, instead i would use

_ReplaceStringInFile

If those are the only 2 lines in it, it's even easier, you don't need to read the file, simply overwrite the same lines as you want, with that function.

Edited January 1, 2018 by careca