CredWriteW trying to add Attributes

[BigDaddyO]

Hello,

 

I'm trying to figure out how to add attributes to a Credentials Store.  I have been using it to store Creds and I was using the Comments to store some limited data but I'd really like to start using the 64 possible Attributes so I don't need to use the Registry to store misc information my script needs.

 

I have been trying to figure this our for a few days now and I'm able to create the structure, but it fails with Invalid Parameter when trying to add the item to the store.

 

Any ideas or pointers to where to get some further information on this?

Thanks,

Mike

expandcollapse popup

#include <Crypt.au3>
#include <Array.au3>
#include <WinAPI.au3>

$sEncryptionKey = @ScriptName & 'MyS3cur!tyK3y' & @UserName

$sCredName = "AttributeTest"
$sUserID = "MyUserID"
$sPassword = "SecretP@ssw0rd"
$sDatabase = "StoredCommentHere"

$sAttribute1 = "ALM.NoReply"
$sAttribute2 = "Defect #?BG_BUG_ID in ?PROJECT, Status = ?BG_STATUS, Severity = ?BG_SEVERITY"
$sAttribute3 = "C:\Users\MyProfile\Documents\ALM_Reports"
$sAttribute4 = "UserName1,QA_Analyst|UserName2,Business_Analyst|UserName3,QA_Analyst|UserName4,QA_Analyst|UserName5,Business_Analyst|UserName6,QA_Analyst"

Global $aAttribute[4, 2] = [["eMailFrom", $sAttribute1], ["eMailSubject", $sAttribute2], ["reportFldr", $sAttribute3], ["DefaultUsers", $sAttribute4]]


;Add something to the Credential Store
    $aAdd = _Cred_Add_WithAttributes($sCredName, $sUserID, StringEncrypt(True, $sPassword, $sEncryptionKey), $sDatabase, 1, $aAttribute)
    If @error Then
        MsgBox(0, "Error", "Failed to add credentials to " & $sCredName)
        Exit
    EndIf


Func _Cred_Add_WithAttributes($sTarget, $sUser, $sPassword, $sComm = "", $iType = 2, $aAttribute = "")  ;Type: 2=Domain, 1=Local
    
    Local $structTarget = DllStructCreate("wchar[100]")                 ; Create a structure to hold the Target object name
    DllStructSetData($structTarget, 1, $sTarget)                        ; Insert the target name into that Structure

    Local $structUser = DllStructCreate("wchar[100]")                   ; Create a structure to hold the UserName to use
    DllStructSetData($structUser, 1, $sUser)                            ; Insert the user name into the structure

    Local $structPwd = DllStructCreate("wchar[100]")                    ; Create a structure to hold the password to use
    DllStructSetData($structPwd, 1, $sPassword)                         ; Insert the password into the structure

    Local $structComment = DllStructCreate("wchar[100]")                ; Comments seem to only work where Type = 1 legacy
    DllStructSetData($structComment, 1, $sComm)

;--------------------------------------------------------------------------------------------------------------------
;-- CREDENTIAL_ATTRIBUTE structure  https://msdn.microsoft.com/en-us/library/windows/desktop/aa374790(v=vs.85).aspx  
;--------------------------------------------------------------------------------------------------------------------
    Local $aAttrirb[UBound($aAttribute)]
    Local $tagCREDENTIAL_ATTRIBUTE = "" & _
        "wchar Keyword;" & _
        "DWORD Flags;" & _
        "DWORD ValueSize;" & _
        "wchar Value"

    For $i = 0 to UBound($aAttribute) - 1
        $aAttrirb[$i] = DllStructCreate($tagCREDENTIAL_ATTRIBUTE)
        If @error Then
            ConsoleWrite("Error on $aAttrib[" & $i & "] = " & @error & @CRLF)
            Exit
        EndIf

        DllStructSetData($aAttrirb[$i],"Keyword",StringRight($aAttribute[$i][0], 256))                      ;Name for the Attribute to use, 256 characters max
        If @error Then ConsoleWrite("Error adding Keyword to $aAttrib[" & $i & "] = " & @error & @CRLF)
        DllStructSetData($aAttrirb[$i],"Flags",0)                                                           ;Should always be 0
        If @error Then ConsoleWrite("Error adding Flags to $aAttrib[" & $i & "] = " & @error & @CRLF)
        DllStructSetData($aAttrirb[$i],"ValueSize",256)                                                     ;Max = 256
        If @error Then ConsoleWrite("Error adding ValueSize to $aAttrib[" & $i & "] = " & @error & @CRLF)
        DllStructSetData($aAttrirb[$i],"Value",StringRight($aAttribute[$i][1], 256))                        ;Take the right most 256 characters if they put in to many
        If @error Then ConsoleWrite("Error adding Value to $aAttrib[" & $i & "] = " & @error & @CRLF)
    Next
;--------------------------------------------------------------------------------------------------------------------


    Local $structCREDENTIAL= "" & _
        "DWORD Flags;" & _
        "DWORD Type;"  & _
        "Ptr TargetName;" & _
        "Ptr Comment;" & _
        "UINT64 LastWritten;" & _
        "DWORD CredintialBlobSize;" & _
        "Ptr CredentialBlob;" & _
        "DWORD Persist;" & _
        "DWORD AttributeCount;" & _
        "ptr Attributes;" & _
        "Ptr TargetAlias;" & _
        "Ptr Username"

    Local $NewCred = DllStructCreate($structCREDENTIAL)
    If @error Then
        MsgBox(0, "NewCred", "Error in DllStructCreate " & @error);
        Exit
    EndIf

    DllStructSetData($NewCred,"Flags",0)
    DllStructSetData($NewCred,"Type",$iType)        ;2 = Domain, 1 = Generic
    DllStructSetData($NewCred,"TargetName",DllStructGetPtr($structTarget))
    DllStructSetData($NewCred,"Persist",3)          ;save to roaming profile = 3


;Problem with this section, as if I comment out, it adds but I need Attributes.
    DllStructSetData($NewCred,"AttributeCount",UBound($aAttrib))    ;max = 64
    If @error Then ConsoleWrite("Error adding AttributeCount (1) = " & @error & @CRLF)
    
    For $i = 0 to UBound($aAttrirb) - 1
        DllStructSetData($NewCred,"Attributes", DllStructGetPtr($aAttrirb[$i]))
        If @error Then ConsoleWrite("Error adding Attributes (" & $i + 1 & ") = " & @error & @CRLF)
    Next


    DllStructSetData($NewCred,"UserName",DllStructGetPtr($structUser))
    DllStructSetData($NewCred,"CredentialBlob",DllStructGetPtr($structPwd))
    DllStructSetData($NewCred,"CredintialBlobSize",StringLen($sPassword)*2)
    DllStructSetData($NewCred,"Comment",DllStructGetPtr($structComment))

    Local $hAdvapi32 = DllOpen("Advapi32.dll")
    If $hAdvapi32 = -1 Then
        Msgbox(0, "Error", "Failed to connect to the Credentials Store")
        Exit
    Endif

    $aRet = DllCall($hAdvapi32, 'bool', 'CredWriteW', 'ptr', DllStructGetPtr($NewCred), 'dword', 0)
    If @error Then ConsoleWrite("DllCall Error:  " & @error & @CRLF)
    $NewCred = 0
    ConsoleWrite("GetLastError = (" & _WinAPI_GetLastError() & ")" & @CRLF)
        ;87 = ERROR_INVALID_PARAMETER

    If IsArray($aRet) Then
        ConsoleWrite("Successfully performed the CredWriteW DLL call, Return = " & $aRet[0] & @CRLF)
        if UBound($aRet) > 1 Then _ArrayDisplay($aRet, "DllCall Returned")
        Return $aRet
    Else
        ConsoleWrite("Failed to perform the CredWriteW DLL call" & @CRLF)
        Return SetError(1)
    EndIf

EndFunc



Func _Cred_Get($sTarget, $iType = 2)  ;Type: 2=Domain, 1=Local.  CAN'T DECRYPT DOMAIN PASSWORDS!!!
    Local $FuncRet[3]

    Local $structTarget = DllStructCreate("wchar[100]")
    DllStructSetData($structTarget,1,$sTarget)

    Local $hAdvapi32 = DllOpen("Advapi32.dll")
    If $hAdvapi32 = -1 Then
        Msgbox(0, "Error", "Failed to connect to the Credentials Store")
        Exit
    Endif

    Local $Ret = DllCall($hAdvapi32, 'bool', 'CredReadW', 'ptr', DllStructGetPtr($structTarget), 'dword', $iType, 'dword', 0, 'ptr*', 0)

    if $ret[0]=0 then Return SetError(1,0,$FuncRet)

    Local $structCREDENTIAL= "" & _
        "DWORD Flags;" & _
        "DWORD Type;"  & _
        "Ptr TargetName;" & _
        "Ptr Comment;" & _
        "UINT64 LastWritten;" & _
        "DWORD CredintialBlobSize;" & _
        "Ptr CredentialBlob;" & _
        "DWORD Persist;" & _
        "DWORD AttributeCount;" & _
        "Ptr Attributes;" & _
        "Ptr TargetAlias;" & _
        "Ptr Username"

    Local $tdata=DllStructCreate($structCREDENTIAL, $Ret[4])

    Local $userName = DllStructCreate("wchar[100]", DllStructGetData($tdata, 'Username'))
    Local $User = DllStructGetData($userName, 1)

    Local $CredentialBlobSize = DllStructGetData($tdata, 'CredintialBlobSize')
    Local $credentialBlob = DllStructCreate("wchar[100]", DllStructGetData($tdata, 'CredentialBlob'))
    Local $Password = StringLeft(DllStructGetData($credentialBlob, 1), $CredentialBlobSize/2)

    ;Once the Add Attributes is working, I need to figure out how to retrieve the Attributes that I want, below is un-tested.
    ; Local $eMailFrom = DllStructCreate("wchar[256]", DllStructGetData($tdata, 'eMailFrom'))
    ; Local $eMail = DllStructGetData($eMailFrom, 4)
    ; Consolewrite("eMailFrom Attribute = (" & $eMail & ")" & @crlf )

    Local $Comment = DllStructCreate("wchar[100]", DllStructGetData($tdata, 'Comment'))
    Local $Comm = DllStructGetData($Comment, 1)

    Dim $FuncRet[] = [$User, $Password, $Comm]
    If IsArray($FuncRet) Then
        Return $FuncRet
    Else
        Return SetError(1)
    EndIf
EndFunc

 

[Danyfirex]

Hello. I have no too much time to check your code. But as far I can see  "wchar Keyword and "wchar Value" need to be pointer to wchar and BYTE.

 

Saludos

[supersonic]

@BigDaddyO: Did you find a solution to your problem writing AttributeCount/Attributes?

 

[BigDaddyO]

4 hours ago, supersonic said:

@BigDaddyO: Did you find a solution to your problem writing AttributeCount/Attributes?

 

nope, I gave up long ago and just store info in HKCU.  If you do find an answer, please let me know.

[caramen]

@FrancescoDiMuro Is your man there. 

I am suprised to see an unswered topic here  .

He will take this as a challenge I am sure  .