$cmdline[0] - error (Working again :-) )

[Mat]

i've added an exe with this script to the context menu of all files through the registry. (see here)

expandcollapse popup

#include <GUIConstantsEx.au3>
#Include <Clipboard.au3>
#include <WindowsConstants.au3>

Opt('MustDeclareVars', 1)
Opt("TrayIconHide", 1)
Opt("GUICloseOnESC", 0)

_main ()
Restart ()

func _Main ()
   local $msg, $long, $short, $copy, $close, $retry, $GUI, $error, $CmdLine

If $CmdLine[0] = 0 Then
    Exit
Endif

$long = Inputbox ("long File name", "Please give the long file name to convert.", "" & $CmdLine[1] & "")
   if @error = 1 then
      exit
   endif
$short = FileGetShortName ($long)

$GUI = GuiCreate("M@'s Short File Name Generator", 392, 168, -1, -1, $WS_OVERLAPPED + $WS_CAPTION + $WS_SYSMENU + $WS_VISIBLE + $WS_CLIPSIBLINGS + $WS_MINIMIZEBOX)
   GuiCtrlCreateLabel("The short file name is: " & @CRLF & "" & $short & ".", 10, 10, 370, 100)
   $Copy = GuiCtrlCreateButton("Copy", 10, 120, 110, 30)
   $Retry = GuiCtrlCreateButton("Try again", 130, 120, 110, 30)
   $close = GuiCtrlCreateButton("Close", 250, 120, 110, 30)
   
GUISetState ()

 do
      $msg = GUIGetmsg()
         select
            case $msg = $retry
               Restart ()
            case $msg = $copy
               ClipPut ($short)
            case $msg = $close or $msg = $GUI_Event_Close or $msg = $retry
               Exit
         Endselect
   until $msg = $GUI_Event_Close
endfunc

;------------------------------------------------------------------------------------------------------------------------------------------------------

Func Restart()
If Not @Compiled Then
    Run(@AutoItExe & " " & FileGetShortName(@ScriptFullPath))
ElseIf @Compiled Then
    Run(@ScriptFullPath)
EndIf
Exit
EndFunc

i get an error when running the script though

error: Subscript used with non-Array variable

it doesn't seem to like my $cmdline[]

any ideas??

the script worked fine until i added the cmdline parts

Mdiesel

Edited March 5, 2009 by mdiesel

[trancexx]

remove declaration of $CmdLine

[water]

You defined $cmdline as a local variable. I think you don' t have to define it. Just drop the $cmdline definition and see if it works.

[Mat]

done...and it works BUT

part 2

error: array variable has incorrect number of subscripts or subscript dimension range exceeded.

??????

[James]

Works for me. Are you trying to do more than one file at a time?

Also, why the hell do you have a "Try Again" button?

[Varian]

Why not make the following changes to so your Try Again button functions as you want it and you can run it without compiling it

If $CmdLine[0] = 0 Then
        Local $File = FileOpenDialog("Please select the file to convert", "", "All Files (*.*)", 1 + 2)
        If @error Then Exit
    Else
        Local $File = $CmdLine[1]
    EndIf

    $Long = InputBox("long File name", "Please give the long file name to convert.", "" & $File & "")

Edited March 5, 2009 by Varian

[Mat]

thanks for all the replies - that is now up and running under this code:

expandcollapse popup

#include <GUIConstantsEx.au3>
#Include <Clipboard.au3>
#include <WindowsConstants.au3>

Opt('MustDeclareVars', 1)
Opt("TrayIconHide", 1)
Opt("GUICloseOnESC", 0)

_main ()
Restart ()

func _Main ()
   local $msg, $long, $short, $copy, $close, $retry, $GUI, $error, $file

If $CmdLine[0] = 0 Then
   Local $File = FileOpenDialog("Please select the file to convert", "", "All Files (*.*)", 1 + 2)
   If @error Then Exit
Else
   Local $File = $CmdLine[1]
EndIf

$long = Inputbox ("long File name", "Please give the long file name to convert.", "" & $file & "")
   if @error = 1 then
      exit
   endif
$short = FileGetShortName ($long)

$GUI = GuiCreate("M@'s Short File Name Generator", 392, 168, -1, -1, $WS_OVERLAPPED + $WS_CAPTION + $WS_SYSMENU + $WS_VISIBLE + $WS_CLIPSIBLINGS + $WS_MINIMIZEBOX)
   GuiCtrlCreateLabel("The short file name is: " & @CRLF & "" & $short & ".", 10, 10, 370, 100)
   $Copy = GuiCtrlCreateButton("Copy", 10, 120, 110, 30)
   $Retry = GuiCtrlCreateButton("Try again", 130, 120, 110, 30)
   $close = GuiCtrlCreateButton("Close", 250, 120, 110, 30)
   
GUISetState ()

 do
      $msg = GUIGetmsg()
         select
            case $msg = $retry
               Restart ()
            case $msg = $copy
               ClipPut ($short)
            case $msg = $close or $msg = $GUI_Event_Close or $msg = $retry
               Exit
         Endselect
   until $msg = $GUI_Event_Close
endfunc

;------------------------------------------------------------------------------------------------------------------------------------------------------

Func Restart()
If Not @Compiled Then
    Run(@AutoItExe & " " & FileGetShortName(@ScriptFullPath))
ElseIf @Compiled Then
    Run(@ScriptFullPath)
EndIf
Exit
EndFunc

;------------------------------------------------------------------------------------------------------------------------------------------------------

try again - restart

same thing...

anyway

thanks

Mdiesel

Edited June 21, 2010 by Mat

[Varian]

I suggested the changes because with your original script, if you pressed Try Again the Restart() function ran the script with no parameters and would close because $Cmdline[0] = 0..there was no point to restarting it before

[Mat]

Yer, i notice that now, thanks for all the help -

final script (hopefully)

expandcollapse popup

#include <GUIConstantsEx.au3>
#Include <Clipboard.au3>
#include <WindowsConstants.au3>

Opt('MustDeclareVars', 1)
Opt("TrayIconHide", 1)
Opt("GUICloseOnESC", 0)

_main ()
Restart ()

func _Main ()
   local $msg, $long, $short, $copy, $close, $retry, $GUI, $error, $file

If $CmdLine[0] = 0 Then
   $msgbox1 = msgbox (1, "No file or folder selected", "This program was not accessed throught the system context menu" & @CRLF & "Do you wish to select a file?")
      select
         case $msgbox1 = 1
            $File = FileOpenDialog("Please select the file to convert", "", "All Files (*.*)", 1 + 2)
            If @error Then Exit
         case $msgbox1 = 2
            exit
      endselect
Else
   Local $File = $CmdLine[1]
EndIf

$long = Inputbox ("long File name", "Please give the long file name to convert.", "" & $file & "")
   if @error = 1 then
      exit
   endif
$short = FileGetShortName ($long)

$GUI = GuiCreate("M@'s Short File Name Generator", 392, 168, -1, -1, $WS_OVERLAPPED + $WS_CAPTION + $WS_SYSMENU + $WS_VISIBLE + $WS_CLIPSIBLINGS + $WS_MINIMIZEBOX)
   GuiCtrlCreateLabel("The short file name is: " & @CRLF & "" & $short & ".", 10, 10, 370, 100)
   $Copy = GuiCtrlCreateButton("Copy", 10, 120, 110, 30)
   $Retry = GuiCtrlCreateButton("Try again", 130, 120, 110, 30)
   $close = GuiCtrlCreateButton("Close", 250, 120, 110, 30)
   
GUISetState ()

 do
      $msg = GUIGetmsg()
         select
            case $msg = $retry
               Restart ()
            case $msg = $copy
               ClipPut ($short)
            case $msg = $close or $msg = $GUI_Event_Close or $msg = $retry
               Exit
         Endselect
   until $msg = $GUI_Event_Close
endfunc

;------------------------------------------------------------------------------------------------------------------------------------------------------

Func Restart()
If Not @Compiled Then
    Run(@AutoItExe & " " & FileGetShortName(@ScriptFullPath))
ElseIf @Compiled Then
    Run(@ScriptFullPath)
EndIf
Exit
EndFunc

;------------------------------------------------------------------------------------------------------------------------------------------------------