Sign in to follow this  
Followers 0
Rawox

Is this a bug? (Listview)

3 posts in this topic

Hey people!

I just changes 1 ; and a part of script didn't worked anymore.

Original:

Case $GetF
        $Files = FileOpenDialog ( $Title & " - Select files.", $DefaultDir, "All (*.*)", 4 )
        _GUICtrlListView_DeleteAllItems ( GUICtrlGetHandle ( $List ) )
        $Split = StringSplit ( $Files, "|" )
        _ArrayDisplay ( $Split )
        If @error = 1 Then
            Sleep ( 10 )
        ElseIf $Split[0] = 1 Then
            Dim $szDrive, $szDir, $szFName, $szExt
            $Item = _PathSplit ( $Split[1], $szDrive, $szDir, $szFName, $szExt )
            _GUICtrlListView_AddItem ( $List, $szFName & $szExt )
            _GUICtrlListView_AddSubItem ( $List, 0, $szDrive & $szDir, 1 )
        Else
            $j = 1
            $x = 0
            Do
                $j += 1
                _GUICtrlListView_AddItem ( $List, $Split[$j] )
                _GUICtrlListView_AddSubItem ( $List, $x, $Split[1] & "\", 1 )
                $x += 1
            Until $j = $Split[0]
        EndIf

New:

Case $GetF
        $Files = FileOpenDialog ( $Title & " - Select files.", $DefaultDir, "All (*.*)", 4 )
        _GUICtrlListView_DeleteAllItems ( GUICtrlGetHandle ( $List ) )
        $Split = StringSplit ( $Files, "|" )
        ;_ArrayDisplay ( $Split )
        If @error = 1 Then
            Sleep ( 10 )
        ElseIf $Split[0] = 1 Then
            Dim $szDrive, $szDir, $szFName, $szExt
            $Item = _PathSplit ( $Split[1], $szDrive, $szDir, $szFName, $szExt )
            _GUICtrlListView_AddItem ( $List, $szFName & $szExt )
            _GUICtrlListView_AddSubItem ( $List, 0, $szDrive & $szDir, 1 )
        Else
            $j = 1
            $x = 0
            Do
                $j += 1
                _GUICtrlListView_AddItem ( $List, $Split[$j] )
                _GUICtrlListView_AddSubItem ( $List, $x, $Split[1] & "\", 1 )
                $x += 1
            Until $j = $Split[0]
        EndIf

All I did is commented the ArrayDisplay. And if you now select one file from the FileOpenDialog nothing is displayed in the listview. Altough if I uncomment the ArrayDisplay it does work with just one file :S

Is it a bug or what?

Rawox.

Share this post


Link to post
Share on other sites



Rawox,

It looks to me as if you have a logic error about which @error you are testing. In the first case, you are testing the @error from the active _ArrayDisplay command; in the second case you are testing the @error directly from the StringSplit as the _ArrayDisplay is commented out..

In the second case, if you select only one file, StringSplit will set the @error because no delimiters were found - from the Help file: "If no delimiters were found @error is set to 1, the count is 1 ($array[0]) and the full string is returned ($array[1])".

I would suggest that you change the code logic to check for the "No files" case immediately after the FileOpenDialog - which will set @error if no files are selected. :)

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0