Moderators JLogan3o13 Posted January 19, 2011 Moderators Share Posted January 19, 2011 (edited) I had the bright idea recently of taking all of my most oft-used scripts and pulling them together into one app that sits in the tray. This allows me to rightclick and execute easily. It works pretty well, but I seem to run into issue with functions. As this holds a number of other scripts, there are several functions. Where I run into issues is trying to break out of a function, without killing the whole script. An example is below, part of a script that returns an array of Group Membership in AD: <BR>...<BR><BR>Func myLoop()<BR><BR>Local $var[1]<BR><BR>$group = InputBox( "Group Membership", "Please enter the name of the group" )<BR>$group1 = ObjGet("WinNT://mydomain/" & $group & ",group")<BR><BR>For $User In $Group1.Members<BR>_ArrayAdd($var, $User.Name)<BR><BR>Next<BR><BR>_ArraySort($var)<BR>_ArrayDisplay($var, "Group Membership")<BR><BR>$done = MsgBox(4, "Group Membership", "Would you like to choose another Group?")<BR><BR>[color="#ff0000"]If $done <> 7 Then<BR> Call("group")<BR>Else<BR> Exit<BR>EndIf[/color]<BR>EndFunc<BR>...<BR> As a standalone script, this works fine; if the user did not want to look at another group it would simply exit the script. But now I would like to just exit the function, not the entire script. I have tried wrapping the If statement into a While so I could use ExitLoop, but this doesn't seem to work either. Just curious if there is an easy way to exit a function without ending the entire script. Edited January 20, 2011 by JLogan3o13 "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
BrewManNH Posted January 19, 2011 Share Posted January 19, 2011 Try this: Else Return EndIf If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
Moderators JLogan3o13 Posted January 20, 2011 Author Moderators Share Posted January 20, 2011 Thanks for the suggestion. I did try that as well, but it still loops continually. It's not as user friendly, but I may just have to remove the loop altogether. "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
jvanegmond Posted January 20, 2011 Share Posted January 20, 2011 Melba's proposed fix in code:Func myLoop() Local $var[1] $group = InputBox("Group Membership", "Please enter the name of the group") $group1 = ObjGet("WinNT://mydomain/" & $group & ",group") For $User In $group1.Members _ArrayAdd($var, $User.Name) Next _ArraySort($var) _ArrayDisplay($var, "Group Membership") $done = MsgBox(4, "Group Membership", "Would you like to choose another Group?") If $done <> 7 Then group() ;<== What is this? Else Return EndIf EndFunc ;==>myLoopIt should work. If it doesn't, then the problem is somewhere else .. For example you may be calling the function again, or $done <> 7 is not the correct expression. Etc. github.com/jvanegmond Link to comment Share on other sites More sharing options...
Moderators JLogan3o13 Posted January 20, 2011 Author Moderators Share Posted January 20, 2011 Not sure how to mark this as Solved, but you were correct Manadar. The script was not liking the way I was calling another function. The following ended up working just fine. Thanks! Func group() Local $var[1] While 1 $group = InputBox( "Group Membership", "Please enter the name of the group" ) If @error = 1 Then ExitLoop EndIf $group1 = ObjGet("WinNT://mydomain/" & $group & ",group") If @error Then MsgBox(0, "Group not found", "Please check the spelling of this group and try again.") ExitLoop EndIf For $User In $Group1.Members _ArrayAdd($var, $User.Name) Next _ArraySort($var) _ArrayDisplay($var, "Group Membership") $done = MsgBox(4, "Group Membership", "Would you like to choose another Group?") If $done = 7 Then ExitLoop EndIf WEnd EndFunc "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum! Link to comment Share on other sites More sharing options...
guinness Posted January 20, 2011 Share Posted January 20, 2011 If you Edit the First Post and select Full Editor then you can edit the Title. UDF List: _AdapterConnections() • _AlwaysRun() • _AppMon() • _AppMonEx() • _ArrayFilter/_ArrayReduce • _BinaryBin() • _CheckMsgBox() • _CmdLineRaw() • _ContextMenu() • _ConvertLHWebColor()/_ConvertSHWebColor() • _DesktopDimensions() • _DisplayPassword() • _DotNet_Load()/_DotNet_Unload() • _Fibonacci() • _FileCompare() • _FileCompareContents() • _FileNameByHandle() • _FilePrefix/SRE() • _FindInFile() • _GetBackgroundColor()/_SetBackgroundColor() • _GetConrolID() • _GetCtrlClass() • _GetDirectoryFormat() • _GetDriveMediaType() • _GetFilename()/_GetFilenameExt() • _GetHardwareID() • _GetIP() • _GetIP_Country() • _GetOSLanguage() • _GetSavedSource() • _GetStringSize() • _GetSystemPaths() • _GetURLImage() • _GIFImage() • _GoogleWeather() • _GUICtrlCreateGroup() • _GUICtrlListBox_CreateArray() • _GUICtrlListView_CreateArray() • _GUICtrlListView_SaveCSV() • _GUICtrlListView_SaveHTML() • _GUICtrlListView_SaveTxt() • _GUICtrlListView_SaveXML() • _GUICtrlMenu_Recent() • _GUICtrlMenu_SetItemImage() • _GUICtrlTreeView_CreateArray() • _GUIDisable() • _GUIImageList_SetIconFromHandle() • _GUIRegisterMsg() • _GUISetIcon() • _Icon_Clear()/_Icon_Set() • _IdleTime() • _InetGet() • _InetGetGUI() • _InetGetProgress() • _IPDetails() • _IsFileOlder() • _IsGUID() • _IsHex() • _IsPalindrome() • _IsRegKey() • _IsStringRegExp() • _IsSystemDrive() • _IsUPX() • _IsValidType() • _IsWebColor() • _Language() • _Log() • _MicrosoftInternetConnectivity() • _MSDNDataType() • _PathFull/GetRelative/Split() • _PathSplitEx() • _PrintFromArray() • _ProgressSetMarquee() • _ReDim() • _RockPaperScissors()/_RockPaperScissorsLizardSpock() • _ScrollingCredits • _SelfDelete() • _SelfRename() • _SelfUpdate() • _SendTo() • _ShellAll() • _ShellFile() • _ShellFolder() • _SingletonHWID() • _SingletonPID() • _Startup() • _StringCompact() • _StringIsValid() • _StringRegExpMetaCharacters() • _StringReplaceWholeWord() • _StringStripChars() • _Temperature() • _TrialPeriod() • _UKToUSDate()/_USToUKDate() • _WinAPI_Create_CTL_CODE() • _WinAPI_CreateGUID() • _WMIDateStringToDate()/_DateToWMIDateString() • Au3 script parsing • AutoIt Search • AutoIt3 Portable • AutoIt3WrapperToPragma • AutoItWinGetTitle()/AutoItWinSetTitle() • Coding • DirToHTML5 • FileInstallr • FileReadLastChars() • GeoIP database • GUI - Only Close Button • GUI Examples • GUICtrlDeleteImage() • GUICtrlGetBkColor() • GUICtrlGetStyle() • GUIEvents • GUIGetBkColor() • Int_Parse() & Int_TryParse() • IsISBN() • LockFile() • Mapping CtrlIDs • OOP in AutoIt • ParseHeadersToSciTE() • PasswordValid • PasteBin • Posts Per Day • PreExpand • Protect Globals • Queue() • Resource Update • ResourcesEx • SciTE Jump • Settings INI • SHELLHOOK • Shunting-Yard • Signature Creator • Stack() • Stopwatch() • StringAddLF()/StringStripLF() • StringEOLToCRLF() • VSCROLL • WM_COPYDATA • More Examples... Updated: 22/04/2018 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now