Jump to content
Sign in to follow this  
ADAMsGOIN

Having trouble with if..then..else statements/return values

Recommended Posts

ADAMsGOIN

I just started using AutoIT a couple days ago, and this is the script I've been working on - it's designed to automatically back up the system when it's put into windows as a scheduled task. It needs to send an email if it fails that tells what part of it failed, as well as an email if it works. This will be run from a server though, so I can't use any message boxes. I've been trying to get this to work for an excess of four hours and I keep getting the same error message - "If" statement has no matching "EndIf" statement. Can somebody help me get this working?

$ReturnValueCreateDirectory = DirCreate("Filepath\" & $date)
$ReturnValueCopyDirectory = DirCopy("OtherFilepath\", "Filepath\" & $date, 1)
$date = @Year & "-" & @MON & "-" & @MDAY
If $ReturnValueCreateDirectory = 0 Then ;Send DirCreate failure email
        #include <INet.au3>
        $AddressForCreateFailure = "My email address"
        $SubjectForCreateFailure = "BACKUP FAILED - " & $date
        $BodyForCreateFailure = "Error creating directory on " & $date
        _INetMail($AddressForCreateFailure, $SubjectForCreateFailure, $BodyForCreateFailure)
        Exit
ElseIf $ReturnValueCopyDirectory = 0 Then ;Send DirCopy failure email
            #include <INet.au3>
            $AddressForCopyFailure = "My email address"
            $SubjectForCopyFailure = "BACKUP FAILED - " & $date
            $BodyForCopyFailure = "Error copying Directory on " & $date
            _INetMail($AddressForCopyFailure, $SubjectForCopyFailure, $BodyForCopyFailure)
            Exit
Else
    DirCreate("Filepath" & $date)
    DirCopy("Other filepath", "filepath" & $date, 1)
    #include <INet.au3>
            $AddressForSuccess = "My email address"
            $SubjectForSuccess = "Backup Successful - " & $date
            $BodyForSuccess = "_____ successfully backed up on " & $date
            _INetMail($AddressForSuccess, $SubjectForSuccess, $BodyForSuccess)
    
EndIf

I've also tried this version...same message

$ReturnValueCreateDirectory = DirCreate("Filepath\" & $date)
$ReturnValueCopyDirectory = DirCopy("Other filepath", "Filepath" & $date, 1)
$date = @Year & "-" & @MON & "-" & @MDAY
DirCreate("Filepath" & $date)
    If $ReturnValueCreateDirectory = 0 Then ;Send DirCreate failure email
        #include <INet.au3>
        $AddressForCreateFailure = "My email address"
        $SubjectForCreateFailure = "BACKUP FAILED - " & $date
        $BodyForCreateFailure = "Error creating directory on " & $date
        _INetMail($AddressForCreateFailure, $SubjectForCreateFailure, $BodyForCreateFailure)
        Exit
    Else ;Backup into newly created file
        DirCopy("Other filepath", "Filepath" & $date, 1)
        If $ReturnValueCopyDirectory = 0 Then ;Send DirCopy failure email
            #include <INet.au3>
            $AddressForCopyFailure = "My email address"
            $SubjectForCopyFailure = "BACKUP FAILED - " & $date
            $BodyForCopyFailure = "Error copying Directory on " & $date
            _INetMail($AddressForCopyFailure, $SubjectForCopyFailure, $BodyForCopyFailure)
            Exit
        Else ;Send Backup Success email
            #include <INet.au3>
            $AddressForSuccess = "My email address"
            $SubjectForSuccess = "Backup Successful - " & $date
            $BodyForSuccess = "_____ successfully backed up on " & $date
            _INetMail($AddressForSuccess, $SubjectForSuccess, $BodyForSuccess)
        EndIf
    EndIf

Share this post


Link to post
Share on other sites
BrewManNH

You have #include statements inside your If...Endif loop. They MUST be at the top of the script, and not within the code.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
ADAMsGOIN

That fixed the error. Thanks :mellow:

Share this post


Link to post
Share on other sites
guinness

Also you only have to include an include once i.e. you can remove the other 2 INet.au3's

Edited by guinness

UDF List:

 
_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_ArrayFilter/_ArrayReduce_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 22/04/2018

Share this post


Link to post
Share on other sites
AdmiralAlkex

#include works by copying the code to the location of the line, so while you may have them anywhere, it rarely makes sense and you have to be wary of problems.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×