NDog Posted October 20, 2011 Share Posted October 20, 2011 (edited) Hi all This is a code block I would like to shorten. This is because eventually I need to create more of these kind of values and don't want to have to type them out for each time I add more. For example admin_1_name and $inAdminName1 has two '1's If $myTTYID[$r][0] = "_admin_1_name" Then GUICtrlSetData($inAdminName1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_2_name" Then GUICtrlSetData($inAdminName2, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_3_name" Then GUICtrlSetData($inAdminName3, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_1_name" Then GUICtrlSetData($inLimitedName1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_2_name" Then GUICtrlSetData($inLimitedName2, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_3_name" Then GUICtrlSetData($inLimitedName3, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_1_pass" Then GUICtrlSetData($inAdminPass1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_2_pass" Then GUICtrlSetData($inAdminPass2, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_3_pass" Then GUICtrlSetData($inAdminPass3, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_1_pass" Then GUICtrlSetData($inLimitedPass1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_2_pass" Then GUICtrlSetData($inLimitedPass2, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_3_pass" Then GUICtrlSetData($inLimitedPass3, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_1_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chAdmin1, $GUI_CHECKED) If $myTTYID[$r][0] = "_admin_2_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chAdmin2, $GUI_CHECKED) If $myTTYID[$r][0] = "_admin_3_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chAdmin3, $GUI_CHECKED) If $myTTYID[$r][0] = "_limited_1_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chLimited1, $GUI_CHECKED) If $myTTYID[$r][0] = "_limited_2_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chLimited2, $GUI_CHECKED) If $myTTYID[$r][0] = "_limited_3_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chLimited3, $GUI_CHECKED) And a second code block where I need to parse through every thing to create a text file expandcollapse popupLocal $msg, $read_input $read_input = 0 $read_input = GUICtrlRead($inLimitedName1) If $read_input <> "" Then $msg &= "_limited_1_name="&GUICtrlRead($inLimitedName1)&@CRLF $msg &= "_limited_1_pass="&GUICtrlRead($inLimitedPass1)&@CRLF If BitAnd(GUICtrlRead($chLimited1),$GUI_CHECKED) Then $msg &= "_limited_1_enable=yes"&@CRLF Else $msg &= "_limited_1_enable=no"&@CRLF EndIf $msg &= "_limited_1_picxp="&@CRLF $msg &= "_limited_1_picw7=C:\ProgramData\Microsoft\User Account Pictures\Default Pictures\usertile21.bmp"&@CRLF $msg &= "_limited_1_desktopbmp="&@CRLF $msg &= @CRLF EndIf $read_input = 0 $read_input = GUICtrlRead($inLimitedName2) If $read_input <> "" Then $msg &= "_limited_2_name="&GUICtrlRead($inLimitedName2)&@CRLF $msg &= "_limited_2_pass="&GUICtrlRead($inLimitedPass2)&@CRLF If BitAnd(GUICtrlRead($chLimited2),$GUI_CHECKED) Then $msg &= "_limited_2_enable=yes"&@CRLF Else $msg &= "_limited_2_enable=no"&@CRLF EndIf $msg &= "_limited_2_picxp="&@CRLF $msg &= "_limited_2_picw7="&@CRLF $msg &= "_limited_2_desktopbmp="&@CRLF $msg &= @CRLF EndIf $read_input = 0 $read_input = GUICtrlRead($inLimitedName3) If $read_input <> "" Then $msg &= "_limited_3_name="&GUICtrlRead($inLimitedName3)&@CRLF $msg &= "_limited_3_pass="&GUICtrlRead($inLimitedPass3)&@CRLF If BitAnd(GUICtrlRead($chLimited3),$GUI_CHECKED) Then $msg &= "_limited_3_enable=yes"&@CRLF Else $msg &= "_limited_3_enable=no"&@CRLF EndIf $msg &= "_limited_3_picxp="&@CRLF $msg &= "_limited_3_picw7="&@CRLF $msg &= "_limited_3_desktopbmp="&@CRLF EndIf Local $file = FileOpen($filename, 10) ; which is similar to 2 + 8 (erase + create dir) FileWrite($filename, $msg ) FileClose($file) and more simply ; Count number of checked admin Checkboxes at least one is required $iCount = 0 If GUICtrlRead($chAdmin1) = 1 Then $iCount += 1 If GUICtrlRead($chAdmin2) = 1 Then $iCount += 1 If GUICtrlRead($chAdmin3) = 1 Then $iCount += 1 ; If at least 1 is checked If $iCount = 0 Then MsgBox("hi","Admin accounts","You need to have at least one active admin user"&@CRLF&"Enter an admin username and tick the active box") Return EndIf I have a feeling this should not be too hard? Thanks for your help Edited October 20, 2011 by NDog Link to comment Share on other sites More sharing options...
NDog Posted October 27, 2011 Author Share Posted October 27, 2011 bump Link to comment Share on other sites More sharing options...
BrewManNH Posted October 27, 2011 Share Posted October 27, 2011 (edited) You could take your first block of your script and use this to shorten it. For $I = 1 To 3 If $myTTYID[$r][0] = "_admin_" & $I & "_name" Then GUICtrlSetData($inAdminName1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_" & $I & "_name" Then GUICtrlSetData($inLimitedName1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_" & $I & "_pass" Then GUICtrlSetData($inAdminPass1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_limited_" & $I & "_pass" Then GUICtrlSetData($inLimitedPass1, $myTTYID[$r][$c]) If $myTTYID[$r][0] = "_admin_" & $I & "_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chAdmin1, $GUI_CHECKED) If $myTTYID[$r][0] = "_limited_" & $I & "_enable" And $myTTYID[$r][$c] = "yes" Then GUICtrlSetState($chLimited1, $GUI_CHECKED) Next Edited October 27, 2011 by BrewManNH If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
NDog Posted November 1, 2011 Author Share Posted November 1, 2011 Thanks for your reply however that didn't answer the question. I am trying to substitue the variable itself eg $var1 $var2 $var3 do a loop through $var1 $var2 $var3 getting the number at the end of the variable as a count in the loop. Hope it clarifies things Link to comment Share on other sites More sharing options...
BrewManNH Posted November 1, 2011 Share Posted November 1, 2011 Use an array, and avoid the problem of variable names altogether. $var1 -> $var3 would become $var[1] ->$var[3]. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
NDog Posted November 2, 2011 Author Share Posted November 2, 2011 it is not possible in autoit to do what I want to achieve. I'm surprised but I am new to autoit programming. I am guessing this means I have to create an array for all my GUI objects so btn1, btn2, btn3 etc would become guibtn[1] guibtn[2] guibtn[3] I guess. To match the GUI objects with variables I would use loop on if guibtn vs $btn I guess? Confused as ever... I hope there may be a good example to show this kind of dynamic relationship between objects and variables. I'm getting stuck on my project over this.. Link to comment Share on other sites More sharing options...
Moderators Melba23 Posted November 2, 2011 Moderators Share Posted November 2, 2011 NDog,it is not possible in autoit to do what I want to achieve. I'm surprisedAnd so would I be if your surmise is true! At the moment I have very little idea what you are trying to do (and the absence of responses suggests I am not alone) - all you have provided so far is a couple of uncommented snippets of code which do not help a lot. Can you explain in simple terms what it is you are trying to do and give us an idea of what your GUI looks like so we can try and help you. M23 Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind Open spoiler to see my UDFs: Spoiler ArrayMultiColSort ---- Sort arrays on multiple columnsChooseFileFolder ---- Single and multiple selections from specified path treeview listingDate_Time_Convert -- Easily convert date/time formats, including the language usedExtMsgBox --------- A highly customisable replacement for MsgBoxGUIExtender -------- Extend and retract multiple sections within a GUIGUIFrame ---------- Subdivide GUIs into many adjustable framesGUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView itemsGUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeViewMarquee ----------- Scrolling tickertape GUIsNoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxesNotify ------------- Small notifications on the edge of the displayScrollbars ----------Automatically sized scrollbars with a single commandStringSize ---------- Automatically size controls to fit textToast -------------- Small GUIs which pop out of the notification area Link to comment Share on other sites More sharing options...
guinness Posted November 2, 2011 Share Posted November 2, 2011 (edited) Maybe he is talking about Eval? But an array is a smarter approach. Edited November 2, 2011 by guinness UDF List: _AdapterConnections() • _AlwaysRun() • _AppMon() • _AppMonEx() • _ArrayFilter/_ArrayReduce • _BinaryBin() • _CheckMsgBox() • _CmdLineRaw() • _ContextMenu() • _ConvertLHWebColor()/_ConvertSHWebColor() • _DesktopDimensions() • _DisplayPassword() • _DotNet_Load()/_DotNet_Unload() • _Fibonacci() • _FileCompare() • _FileCompareContents() • _FileNameByHandle() • _FilePrefix/SRE() • _FindInFile() • _GetBackgroundColor()/_SetBackgroundColor() • _GetConrolID() • _GetCtrlClass() • _GetDirectoryFormat() • _GetDriveMediaType() • _GetFilename()/_GetFilenameExt() • _GetHardwareID() • _GetIP() • _GetIP_Country() • _GetOSLanguage() • _GetSavedSource() • _GetStringSize() • _GetSystemPaths() • _GetURLImage() • _GIFImage() • _GoogleWeather() • _GUICtrlCreateGroup() • _GUICtrlListBox_CreateArray() • _GUICtrlListView_CreateArray() • _GUICtrlListView_SaveCSV() • _GUICtrlListView_SaveHTML() • _GUICtrlListView_SaveTxt() • _GUICtrlListView_SaveXML() • _GUICtrlMenu_Recent() • _GUICtrlMenu_SetItemImage() • _GUICtrlTreeView_CreateArray() • _GUIDisable() • _GUIImageList_SetIconFromHandle() • _GUIRegisterMsg() • _GUISetIcon() • _Icon_Clear()/_Icon_Set() • _IdleTime() • _InetGet() • _InetGetGUI() • _InetGetProgress() • _IPDetails() • _IsFileOlder() • _IsGUID() • _IsHex() • _IsPalindrome() • _IsRegKey() • _IsStringRegExp() • _IsSystemDrive() • _IsUPX() • _IsValidType() • _IsWebColor() • _Language() • _Log() • _MicrosoftInternetConnectivity() • _MSDNDataType() • _PathFull/GetRelative/Split() • _PathSplitEx() • _PrintFromArray() • _ProgressSetMarquee() • _ReDim() • _RockPaperScissors()/_RockPaperScissorsLizardSpock() • _ScrollingCredits • _SelfDelete() • _SelfRename() • _SelfUpdate() • _SendTo() • _ShellAll() • _ShellFile() • _ShellFolder() • _SingletonHWID() • _SingletonPID() • _Startup() • _StringCompact() • _StringIsValid() • _StringRegExpMetaCharacters() • _StringReplaceWholeWord() • _StringStripChars() • _Temperature() • _TrialPeriod() • _UKToUSDate()/_USToUKDate() • _WinAPI_Create_CTL_CODE() • _WinAPI_CreateGUID() • _WMIDateStringToDate()/_DateToWMIDateString() • Au3 script parsing • AutoIt Search • AutoIt3 Portable • AutoIt3WrapperToPragma • AutoItWinGetTitle()/AutoItWinSetTitle() • Coding • DirToHTML5 • FileInstallr • FileReadLastChars() • GeoIP database • GUI - Only Close Button • GUI Examples • GUICtrlDeleteImage() • GUICtrlGetBkColor() • GUICtrlGetStyle() • GUIEvents • GUIGetBkColor() • Int_Parse() & Int_TryParse() • IsISBN() • LockFile() • Mapping CtrlIDs • OOP in AutoIt • ParseHeadersToSciTE() • PasswordValid • PasteBin • Posts Per Day • PreExpand • Protect Globals • Queue() • Resource Update • ResourcesEx • SciTE Jump • Settings INI • SHELLHOOK • Shunting-Yard • Signature Creator • Stack() • Stopwatch() • StringAddLF()/StringStripLF() • StringEOLToCRLF() • VSCROLL • WM_COPYDATA • More Examples... Updated: 22/04/2018 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now