Subscript used with non-Array variable _FileReadToArray $aRecords count

[computergroove]

#include <file.au3>
#include <IE.au3>
#include <Array.au3>
Global $Paused
Global $linecount = 1
Global $aRecords ;Counts the number of lines in array
Dim $Split[14] ;sets aside memory for all 14 seperate columnsin data.txt

Start() ; Declares teh Start Function

$file = "Data.txt" ; cc member data list
_FileReadToArray($file, $aRecords) ; puts the contents of $file into an array

Func Start()
While 1
    $line = $aRecords[$linecount] ; Sets $line to the line of the record the script wants to use

In the last line above I am getting an error during compiling:

Subscript used with non-Array variable.:

$line = $aRecords[$linecount]

$line = $aRecords^ ERROR

What the hell is the problem?

[VixinG]

I'd say RTFM but I like to solve things.

The problem was wrong code...

READ this and FIND differences with your code, then learn more about them from manual (yes, F1 in SciTE). I also recommend typing in google:

site:autoitscript.com <your question>

- it helped me many times

Here's fixed version:

#include <file.au3>
#include <IE.au3>
#include <Array.au3>
Global $Paused
Global $linecount = 1
Start() ; Declares teh Start Function
Func Start()
While 1
Local $file = "Data.txt" ; cc member data list
    Local $CountLines = _FileCountLines("Data.txt")
Local $aRecords[$CountLines]
_FileReadToArray($file, $aRecords) ; puts the contents of $file into an array
MsgBox(0,"Title",$aRecords[1]) ; reads the 1st line of $file
WEnd
EndFunc

[kylomas]

computergroove, VixinG, There are a couple of previous posts that sized an array meant to hold a file by running _filecountlines. Consider the following alternative (simpler and less overhead)

; ; ; ; generate test file Local $data_block = 'this is the first line of text' & @CRLF & 'this is the second line of text' & @CRLF & _ 'this is the third line of text' & @CRLF & 'this is the fourth line of text' Local $hfl = FileOpen("c:tmpdata.txt",2) ; open file in write mode If $hfl = -1 Then MsgBox(0,'File open error','') ; if error then barf FileWrite($hfl,$data_block) ; write 4 lines of text to the file FileClose($hfl) ; close the file handle ; read test file to array and display 1ST line ; This is all you need to create an array from a file ; Note - nesting the fileread prohibits you from checking for fileread errors. Local $array = StringSplit(FileRead("c:tmpdata.txt"),@crlf,1) ; read the file into an array MsgBox(0,'My file contains ' & $array[0] & ' lines','line 1 = ' & $array[1]) ; issue a goofy message

Good Luck, kylomas

Edit: re-post - the editor made garbage of the post when trying to correct a parameter.

Edited April 2, 2012 by kylomas

[guinness]

VixinG,

You don't really need _FileCountLines as _FileReadToArray returns the line count in $aArray[0] (0th index) and there is no need for a While loop in your example, because it keeps repeating the operation over and over again. Also declaring variables in loops can reduce performance, so always declare Local or Global variables outside of loops.

With _FileReadToArray you don't have to declare the size of the Array, it does it for you.

computergroove,

Since your snippet was truncated, I have no idea what you were doing, so here is my interpretation. Also the example in the Help would have showed you how to correctly enumerate through an Array returned by _FileReadToArray.

#include <Array.au3>
#include <File.au3>

Example()

Func Example()
    Local $aArray ; Try not to use Dim, either Global or Local. In this case the scope is Local.
    Local $sFilePath = @ScriptDir & "Data.txt"
    _FileReadToArray($sFilePath, $aArray)
    If Not @error Then ; Check if there wasn't an error reading the file.
        For $i = 1 To $aArray[0]
            ConsoleWrite($aArray[$i] & @CRLF)
        Next
        MsgBox(4096, "", "Number of lines: " & $aArray[0])
    EndIf
EndFunc   ;==>Example

[kylomas]

computergroove, VixinG,

There are a couple of previous posts that sized an array meant to hold a file by running _filecountlines. Consider the following alternative (simpler and less overhead)

; generate test file

Local $data_block = 'this is the first line of text' & @CRLF & 'this is the second line of text' & @CRLF & _
                    'this is the third line of text' & @CRLF & 'this is the fourth line of text'

Local $hfl = FileOpen("c:tmpdata.txt",2)                                        ; open file in write mode
If $hfl = -1 Then MsgBox(0,'File open error','')                                ; if error then barf
FileWrite($hfl,$data_block)                                                     ; write 4 lines of text to the file
FileClose($hfl)                                                                 ; close the file handle

; read test file to array and display 1ST line

; This is all you need to create an array from a file
; Note - nesting the fileread prohibits you from checking for fileread errors.

Local $array = StringSplit(FileRead("c:tmpdata.txt"),@crlf,1)                   ; read the file into an array
MsgBox(0,'My file contains ' & $array[0] & ' lines','line 1 = ' & $array[1])    ; issue a goofy message

Good Luck,

kylomas

[guinness]

kylomas,

A quick thought you display a MsgBox stating there was an error with FileOpen but still continue to write to it. Also if the file is using linefeed (@LF) or carriage return (@CR) instead of @CRLF then your snippet will fail.

#include <Array.au3>

Example()

Func Example()
    Local $sData_LF = 'this is the first line of text' & @LF & 'this is the second line of text' & @LF & _
            'this is the third line of text' & @LF & 'this is the fourth line of text'
    Local $aArray = StringSplit($sData_LF, @CRLF, 1)
    _ArrayDisplay($aArray)

    Local $sData_CRLF = 'this is the first line of text' & @CRLF & 'this is the second line of text' & @CRLF & _
            'this is the third line of text' & @CRLF & 'this is the fourth line of text'
    $aArray = StringSplit($sData_CRLF, @CRLF, 1)
    _ArrayDisplay($aArray)

    Local $sData_CR = 'this is the first line of text' & @CR & 'this is the second line of text' & @CR & _
            'this is the third line of text' & @CR & 'this is the fourth line of text'
    $aArray = StringSplit($sData_CR, @CRLF, 1)
    _ArrayDisplay($aArray)
EndFunc   ;==>Example

Edited April 2, 2012 by guinness

[kylomas]

@guiness,

Yes, all of this is true. I will plead that it is 2AM and I'm going to bed...apologies to the origional poster!

By the way, how can you edit a post without the formatting getting all fucked up? (this happens intermittently)

kylomas

[guinness]

What browser are you using? If the answer is Opera then select the button in the top left hand corner labelled 'Toggle editing mode' to the basic view and add the autoit tags (or before you toggle the view by selecting the AutoIt button as it's ghosted out) and then paste in between the tags. It might be cumbersome but it means I don't have to switch to Firefox everytime I want to post code.

[kylomas]

Guinness,

using IE9

[guinness]

The same advice might apply, no idea I haven't used IE9.

[kylomas]

computergroove,

Code corrected to reflect guinness's observations.

#include <file.au3>

; generate test file

Local $data_block = 'this is the first line of text' & @CRLF & 'this is the second line of text' & @CRLF & _
                    'this is the third line of text' & @CRLF & 'this is the fourth line of text'

Local $hfl = FileOpen("c:tmpdata.txt",2)                                        ; open file in write mode
If $hfl = -1 Then
    MsgBox(0,'File open error','')                                              ; if error then barf
    Exit
endif
FileWrite($hfl,$data_block)                                                     ; write 4 lines of text to the file
FileClose($hfl)                                                                 ; close the file handle

; read test file to array and display 1ST line
; This is all you need to create an array from a file

Local $array
_filereadtoarray("c:tmpdata.txt", $array)                                       ; read the file into an array
MsgBox(0,'My file contains ' & $array[0] & ' lines','line 1 = ' & $array[1])    ; issue a goofy message

kylomas

[VixinG]

guinness, kylomas,

You are both right. I am new user and I wrongly think that everything what works (written by me) is good. Thanks for the tips, and I will try to code better. Also I was writing that message late at night (4:36 AM)

[guinness]

guinness, kylomas,

You are both right. I am new user and I wrongly think that everything what works (written by me) is good. Thanks for the tips, and I will try to code better. Also I was writing that message late at night (4:36 AM)

No problem, I make mistakes all the time, but it's how we learn.

[computergroove]

Thank you for all your responses. The script worked past the last line above until I added the line 'Func Main()'. After that I received this error and I think the data is valid. Here's what I want to accomplish:

I have a list of auto generated user names and email addresses in cc member data.txt. There are 14 pieces of data in each line and I have 118 lines, ie name, mailing address, email address etc. I want to change the proxy address and restart internet explorer. If the proxy is down I need a error log of the records that did not go through. The problem is that I cant get ie to stop the script, write the record to an ini file and then change to the next record and restart the loop. I am using arrays to get the data.

[BrewManNH]

Please post your code, what you posted in the first post is incomplete and doesn't tell us what you're trying to do.