1 and string = bug?

[ripdad]

Can someone confirm a bug?

; test digit and string if equal to 1
;==========================================
$s = '1 String'
If $s = 1 Then
    MsgBox(0,'1',$s)
EndIf

; test with front-end space
;==========================================
$s = '      1 String'
If $s = 1 Then
    MsgBox(0,'2',$s)
EndIf

; test multi-line with space
;==========================================
$s = @CRLF & @CRLF & '      1 String'
If $s = 1 Then
    MsgBox(0,'3',$s)
EndIf

; swap digit and string
;==========================================
$s = 'String 1'
If $s = 1 Then
    MsgBox(0,'4',$s)
EndIf

[GuillaumeDube]

You're not comparing an int to a string, you are putting 1 in the string.

[water]

If you compare a number with a string the string will be converted to a number. You can check the result of the conversion with

msgBox(0, "", Number($s))

All strings starting with a number (examples 1 to 3) are converted to 1. $s = 'String 1' converts to 0 and therefore is not equal 1.

[water]

You're not comparing an int to a string, you are putting 1 in the string.

Wrong. After "If" always a comparison is being done.

[GuillaumeDube]

Just look at his "if" statement. He's using a single "=" sign instead of two. what does "$string = 1" mean in a if statement?

[JohnOne]

Its a string comparison without case.

[BrewManNH]

From the help file (Language Reference > DataTypes)

The other way around however is different. When you use string comparisons with Boolean values, the following rules apply:

Only an empty string ("") will be a Boolean false

Any other string values (including a string equal "0") will be a Boolean true

You're doing a boolean comparison by using the 1 as a number, so an non-empty string will equal 1 because True = 1.

[water]

Here you find all available operators.

[BrewManNH]

Just look at his "if" statement. He's using a single "=" sign instead of two. what does "$string = 1" mean in a if statement?

In AutoIt the double "=" is used as a case sensitive string comparison, a single quote is used, in this example, as a comparison without case sensitvitiy.

[water]

To sum it up: No, it's not a bug. AutoIt works as designed.

[GuillaumeDube]

I'm really sorry then. That's what I get for thinking in C# in Autoit forums . Sorry again.

[Mechaflash]

From the help file (Language Reference > DataTypes)

You're doing a boolean comparison by using the 1 as a number, so an non-empty string will equal 1 because True = 1.

I just tested this and it doesn't check out

$s = '2 some obfuscated string'
If $s = 1 Then
    MsgBox(0,'1',$s) ; fails
EndIf

Notice this:

$s = '2 some obfuscated string'
If $s = 2 Then
    MsgBox(0,'1','first') ; works
EndIf
$s = '1 some obfuscated string'
If $s = 2 Then
    MsgBox(0,'2','second') ; fails
EndIf

I thought it was thinking 1 = true also until i tested this

I think what's happening is that since it's comparing the string to a number, it's converting the string to a number... which all alpha characters are scrapped from the string.

Disregard below... I was on something at the time I wrote it

You can even put the numbers at the end of the string and they will return true.

$s = 'some obfuscated string 2'
If $s = 2 Then
    MsgBox(0,'1','1') ; works
EndIf
$s = 'some obfuscated string 2'
If $s = 1 Then
    MsgBox(0,'2','2') ; fails
EndIf

Edited June 8, 2012 by mechaflash213

[ripdad]

I Expect StringInStr($s, 1) to return 1

but not an If equal to statement.

Something new learned today, I guess.

Thanks for your time and help.

Now I'm off to write a function to deal with it....

[BrewManNH]

I just tested this and it doesn't check out

I think what's happening is that since it's comparing the string to a number, it's converting the string to a number... which all alpha characters are scrapped from the string. You can even put the numbers at the end of the string and they will return true.

Yes, you're right, when doing a comparison against a number, it's converting the string to a number, got that part wrong.

[JohnOne]

I just tested this and it doesn't check out

$s = '2 some obfuscated string'
If $s = 1 Then
    MsgBox(0,'1',$s) ; fails
EndIf

Notice this:

$s = '2 some obfuscated string'
If $s = 2 Then
    MsgBox(0,'1','first') ; works
EndIf
$s = '1 some obfuscated string'
If $s = 2 Then
    MsgBox(0,'2','second') ; fails
EndIf

I thought it was thinking 1 = true also until i tested this

I think what's happening is that since it's comparing the string to a number, it's converting the string to a number... which all alpha characters are scrapped from the string. You can even put the numbers at the end of the string and they will return true.

$s = 'some obfuscated string 2'
If $s = 2 Then
    MsgBox(0,'1','1') ; works
EndIf
$s = 'some obfuscated string 2'
If $s = 1 Then
    MsgBox(0,'2','2') ; fails
EndIf

Autoit does it's best to figure out what a user is trying to do, when code is bad.

[Mechaflash]

Autoit does it's best to figure out what a user is trying to do, when code is bad.

I feel edumacated

[water]

I Expect StringInStr($s, 1) to return 1

but not an If equal to statement.

Something new learned today, I guess.

Thanks for your time and help.

Now I'm off to write a function to deal with it....

Where do you find a StringInStr in the OPs code? If you pass a parameter as number to the function but a string is expected it is translated to a string.

$s = '    1 String'
ConsoleWrite(Stringinstr($s, 1) & @LF)

returns 7 and is equivalent to

$s = '    1 String'
ConsoleWrite(Stringinstr($s, "1") & @LF)

Edited June 8, 2012 by water

[Mechaflash]

I Expect StringInStr($s, 1) to return 1

but not an If equal to statement.

Something new learned today, I guess.

Thanks for your time and help.

Now I'm off to write a function to deal with it....

StringInStr() returns the position of the value you're searching for. If 1 is at the first position, it will return 1. If there are 6 spaces before the 1, it will return 7 etc. If you're just trying to make sure that it's there, just do a

If StringInStr($s, 1) Then msgbox(0,"","It's there")

Which the function returns True (non-zero), else it returns False (zero)

Edited June 8, 2012 by mechaflash213

[ripdad]

Okay, I get it.

That string could be an either-or combination. Thats my point.

I will still have to write a function for it.

[Mechaflash]

Okay, I get it.

That string could be an either-or combination. Thats my point.

I will still have to write a function for it.

Why not just make the number a string? Or check if what you're comparing to is an integer first, then do the comparison?

$s = '1 some obfuscated string'
If $s = '1' Then
    MsgBox(0,'1',$s) ; fails
EndIf

;;;;;;;;; or

$s = '1 some obfuscated string'
If IsInt($s) And $s = 1 Then
    MsgBox(0,'1',$s) ; fails
EndIf