Jump to content
Sign in to follow this  
BitByteBit

Is using Ubound in For To Next declarations loops bad practice

Recommended Posts

Read this

I have been contemplating the posts which lead up to Valik's explanaition:

Both of these are good points, and it makes me doubt the validity of explicitly declaring variables out of context for beginners to learn from. In other words it might be as well to go the extra mile and include the function to avoid confusion. I consider this to be better than declaring a local variable in global scope when it belongs inside a function. I personally think these subtleties of scope are more for advanced users to discover as you become more familiar with general programming concepts.

Edited by czardas

Share this post


Link to post
Share on other sites

I'd agree with you czardas, if you provide examples with variables declared Local but in the Global scope, it will only lead to confusion for anyone learning the language. The new users will start declaring everything Local without knowing the implications and having issues all over the place that they can't understand. This in turn will probably lead many to drop the language because it's "broken".


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

@BrewmanNH Thanks for your comment. The best method is not necessarily the easiest way to demonstrate a straight forward, or unrelated, concept. For example: an answer to a question about deactivating Hotkeys might be more educational even though setting an accelerator key turns out to be more suited to the task.

Edited by czardas

Share this post


Link to post
Share on other sites

Kinda wonder why some are textually pre-specifying a variable scoop on a variable when is not declared yet.

Beginners tip:

Use: #AutoIt3Wrapper_AU3Check_Parameters=-q -d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7

Les ambiguity in what you should not do. (less danger in learning bad habits.)

... Proof: Tricky proposition. ...


"Straight_and_Crooked_Thinking" : A "classic guide to ferreting out untruths, half-truths, and other distortions of facts in political and social discussions."
"The Secrets of Quantum Physics" : New and excellent 2 part documentary on Quantum Physics by Jim Al-Khalili. (Dec 2014)

"Believing what you know ain't so" ...

Knock Knock ...
 

Share this post


Link to post
Share on other sites

With the help file examples we use this for checking scripts with Au3Check advanced parameters:

#AutoIt3Wrapper_AU3Check_Parameters=-q -d -w 1 -w 2 -w 3 -w- 4 -w 5 -w 6 -w- 7

Of course if I were to declare Local variables in 'File scope' then I would probably wrap it in a function.

Global $vGlobalVar = 0

SomeFunc()
AnotherFunc()

Local $vLocalVar = 2
If $vGlobalVar Then
    MsgBox(4096, '', '$vGlobalVar = ' & $vGlobalVar & ', ' & '$vLocalVar = ' & $vLocalVar)
EndIf

Func SomeFunc()
    $vGlobalVar += 1
    ; Some code
EndFunc   ;==>SomeFunc

Func AnotherFunc()
    $vGlobalVar += 1
    ; Some code
EndFunc   ;==>AnotherFunc

Global $vGlobalVar = 0

SomeFunc()
AnotherFunc()

Func Example()
    Local $vLocalVar = 2
    If $vGlobalVar Then
        MsgBox(4096, '', '$vGlobalVar = ' & $vGlobalVar & ', ' & '$vLocalVar = ' & $vLocalVar)
    EndIf
EndFunc   ;==>Example

Func SomeFunc()
    $vGlobalVar += 1
    ; Some code
EndFunc   ;==>SomeFunc

Func AnotherFunc()
    $vGlobalVar += 1
    ; Some code
EndFunc   ;==>AnotherFunc

UDF List:

 
_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_ArrayFilter/_ArrayReduce_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 22/04/2018

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×
×
  • Create New...