Infinite loop?

[olo]

I have the below function in a while loop. while 1....Wend

However when I get my error and the function successfully closes it. The script is still looping?

 
Func  Assert($popup)

    If (WinExists("[TITLE:" & $popup & "]")) Then

        WinActivate("[TITLE:" & $popup & "]")

        Send("{CTRLDOWN}c{CTRLUP}")

        Local $olo = ClipGet()

        ACRAOutputerror($olo)

        Send("{ENTER}")

    EndIf

EndFunc
 

[guinness]

ExitLoop.

I'm sure you have been told this before.

[olo]

  On 6/5/2013 at 2:16 PM, guinness said:

ExitLoop.

I'm sure you have been told this before.

I know of exit loop but I dont need it to exit the loop I want the whole thing to finish running altogether

[BrewManNH]

If you Exit the while loop, it will exit the script.

[olo]

  On 6/5/2013 at 2:19 PM, BrewManNH said:

If you Exit the while loop, it will exit the script.

In one of my other scripts I had a list of functions that the script ran through and once it did it successfully ended. I dont see why that wouldnt work here?

[guinness]

ExitLoop should be used with a loop, not Exit. But the code above doesn't show a loop anywhere.

[olo]

  On 6/5/2013 at 2:20 PM, guinness said:

ExitLoop should be used with a loop, not Exit. But the code above doesn't show a loop anywhere.

my loop is literally

 
while 1
 
Test_Assert()
 
Wend
 

Edited June 5, 2013 by olo

[BrewManNH]

Something like this.

 

while 1
 
If Test_Assert($thepopup) Then ExitLoop
 
Wend
  
Func  Test_Assert($popup)
    Local $return = 0
    If (WinExists("[TITLE:" & $popup & "]")) Then
 
        WinActivate("[TITLE:" & $popup & "]")
 
        Send("{CTRLDOWN}c{CTRLUP}")
 
        Local $olo = ClipGet()
 
        ACRAOutputerror($olo)
 
        Send("{ENTER}")
        $return = 1
    EndIf
    Return $return
EndFunc
 

[guinness]

; So Return True in that function e.g.

While 1
    If Test_Assert() Then
        ExitLoop
    EndIf
WEnd

[FireFox]

While 1
    If MyFunc() = 0 Then ExitLoop
WEnd
 
Func MyFunc()
    ;do stuff
    Return 1 ;success
    Return 0 ;failure
EndFunc

[TheSaint]

@olo - How can you expect that to exit, when it doesn't ask for or return a value?

EDIT

The others have given it to you on a platter ... I would have made you work harder for it ... use a few brain cells even.

Edited June 5, 2013 by TheSaint

[olo]

Cheers guys. I see what I was doing wrong. Thanks again

[FireFox]

Seems like we are set to anwser in a minute.

Edited June 6, 2013 by FireFox

[olo]

  On 6/5/2013 at 2:27 PM, TheSaint said:

@olo - How can you expect that to exit, when it doesn't ask for or return a value?

Yea just realized that there. Still getting used to programming...

[BrewManNH]

  On 6/5/2013 at 2:28 PM, FireFox said:

Seems like we are set to anwser in a minute.

It's pretty basic coding.

[guinness]

Seems I'm the only one who returns a boolean value instead of an integer!

[FireFox]

  On 6/5/2013 at 2:29 PM, BrewManNH said:

It's pretty basic coding.

The funny thing was not that we answered quickly, but we all answered at the same minute.

[FireFox]

  On 6/5/2013 at 2:32 PM, guinness said:

Seems I'm the only one who returns a boolean value instead of an integer!

It's personal, I don't "like" to return booleans.

[TheSaint]

  On 6/5/2013 at 2:28 PM, olo said:

Yea just realized that there. Still getting used to programming...

To succeed in programming, one needs to have their critical thinking cap on at all times.

It pays to step through the code, and ask yourself, what it is doing at each point/line plus what you are wanting or expecting it to do.

It's a two way process.

Edited June 5, 2013 by TheSaint

[BrewManNH]

  On 6/5/2013 at 2:32 PM, guinness said:

Seems I'm the only one who returns a boolean value instead of an integer!

1 and 0 are functionally the same as True and False.