michaelslamet Posted January 3, 2014 Posted January 3, 2014 (edited) I have some issues with current array functions: expandcollapse popup#include <array.au3> #include <date.au3> Opt("TrayIconDebug", 1) Local $tdata, $arr ; generate data for testing For $1 = 1 to 2000 $tdata &= 'user' & stringformat('%04i',random(1,1000,1)) & ' :: ' & 'www.' for $2 = 1 to random(5,16,1) $tdata &= chr(random(97,122,1)) Next $tdata &= '.com :: ' $tdata &= _dateadd('D',random(-365,365,1),_NowCalcDate()) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) & @LF Next ; ==> generate data for testing local $st = timerinit() $arr = StringSplit2D ($tdata, @LF, "::") _ArrayDeleteCol($arr, 1) _ArrayDeleteCol($arr, 2) _ArrayDeleteCol($arr, 3) _ArrayDeleteCol($arr, 4) _ArrayDeleteCol($arr, 5) _ArrayDeleteCol($arr, 6) _ArrayDeleteCol($arr, 7) ConsoleWrite(stringformat('Time to run %03i records = %2.4f',$1-1,timerdiff($st)/1000) & @lf) _ArrayDisplay($arr) Func StringSplit2D($string ,$delimiters1 ,$delimiters2) $Array1 = StringSplit ( $string, $delimiters1) Dim $MAXUBound = 0 , $OutArray2[1][1] For $I = 1 To $Array1[0] Step 1 $OutArray = StringSplit ( $Array1[$i], $delimiters2) If $MAXUBound < $OutArray[0] Then ReDim $OutArray2[$i][$OutArray[0]] $MAXUBound = $OutArray[0] Else ReDim $OutArray2[$i][UBound($OutArray2,2)] EndIf For $j = 1 To $OutArray[0] Step 1 $OutArray2[$i - 1][$j - 1] = $OutArray[$j] Next Next Return $OutArray2 EndFunc Func _ArrayDeleteCol(ByRef $avWork, $iCol) If Not IsArray($avWork) Then Return SetError(1, 0, 0); Not an array If UBound($avWork, 0) <> 2 Then Return SetError(1, 1, 0); Not a 2D array If ($iCol < 0) Or ($iCol > (UBound($avWork, 2) - 1)) Then Return SetError(1, 2, 0); $iCol out of range If $iCol < UBound($avWork, 2) - 1 Then For $c = $iCol To UBound($avWork, 2) - 2 For $r = 0 To UBound($avWork) - 1 $avWork[$r][$c] = $avWork[$r][$c + 1] Next Next EndIf ReDim $avWork[UBound($avWork)][UBound($avWork, 2) - 1] Return 1 EndFunc 1. It's too slow. Time to run 2000 records = 37.2815 I think that is because ReDim. At least that is what Opt("TrayIconDebug", 1) tell. 2. Result array from StringSplit2D function always have some blank columns, so I need to delete it with _ArrayDeleteCol Those blank columns should not there at the first place 3. Result array from StringSplit2D function always have 1 blank row at the end. That blank row/record should not there at the first place Edit: typo on title Edited January 3, 2014 by michaelslamet
guinness Posted January 3, 2014 Posted January 3, 2014 Look in my signature for a discussion on ReDim. It's under _ReDim. UDF List: Reveal hidden contents _AdapterConnections() • _AlwaysRun() • _AppMon() • _AppMonEx() • _ArrayFilter/_ArrayReduce • _BinaryBin() • _CheckMsgBox() • _CmdLineRaw() • _ContextMenu() • _ConvertLHWebColor()/_ConvertSHWebColor() • _DesktopDimensions() • _DisplayPassword() • _DotNet_Load()/_DotNet_Unload() • _Fibonacci() • _FileCompare() • _FileCompareContents() • _FileNameByHandle() • _FilePrefix/SRE() • _FindInFile() • _GetBackgroundColor()/_SetBackgroundColor() • _GetConrolID() • _GetCtrlClass() • _GetDirectoryFormat() • _GetDriveMediaType() • _GetFilename()/_GetFilenameExt() • _GetHardwareID() • _GetIP() • _GetIP_Country() • _GetOSLanguage() • _GetSavedSource() • _GetStringSize() • _GetSystemPaths() • _GetURLImage() • _GIFImage() • _GoogleWeather() • _GUICtrlCreateGroup() • _GUICtrlListBox_CreateArray() • _GUICtrlListView_CreateArray() • _GUICtrlListView_SaveCSV() • _GUICtrlListView_SaveHTML() • _GUICtrlListView_SaveTxt() • _GUICtrlListView_SaveXML() • _GUICtrlMenu_Recent() • _GUICtrlMenu_SetItemImage() • _GUICtrlTreeView_CreateArray() • _GUIDisable() • _GUIImageList_SetIconFromHandle() • _GUIRegisterMsg() • _GUISetIcon() • _Icon_Clear()/_Icon_Set() • _IdleTime() • _InetGet() • _InetGetGUI() • _InetGetProgress() • _IPDetails() • _IsFileOlder() • _IsGUID() • _IsHex() • _IsPalindrome() • _IsRegKey() • _IsStringRegExp() • _IsSystemDrive() • _IsUPX() • _IsValidType() • _IsWebColor() • _Language() • _Log() • _MicrosoftInternetConnectivity() • _MSDNDataType() • _PathFull/GetRelative/Split() • _PathSplitEx() • _PrintFromArray() • _ProgressSetMarquee() • _ReDim() • _RockPaperScissors()/_RockPaperScissorsLizardSpock() • _ScrollingCredits • _SelfDelete() • _SelfRename() • _SelfUpdate() • _SendTo() • _ShellAll() • _ShellFile() • _ShellFolder() • _SingletonHWID() • _SingletonPID() • _Startup() • _StringCompact() • _StringIsValid() • _StringRegExpMetaCharacters() • _StringReplaceWholeWord() • _StringStripChars() • _Temperature() • _TrialPeriod() • _UKToUSDate()/_USToUKDate() • _WinAPI_Create_CTL_CODE() • _WinAPI_CreateGUID() • _WMIDateStringToDate()/_DateToWMIDateString() • Au3 script parsing • AutoIt Search • AutoIt3 Portable • AutoIt3WrapperToPragma • AutoItWinGetTitle()/AutoItWinSetTitle() • Coding • DirToHTML5 • FileInstallr • FileReadLastChars() • GeoIP database • GUI - Only Close Button • GUI Examples • GUICtrlDeleteImage() • GUICtrlGetBkColor() • GUICtrlGetStyle() • GUIEvents • GUIGetBkColor() • Int_Parse() & Int_TryParse() • IsISBN() • LockFile() • Mapping CtrlIDs • OOP in AutoIt • ParseHeadersToSciTE() • PasswordValid • PasteBin • Posts Per Day • PreExpand • Protect Globals • Queue() • Resource Update • ResourcesEx • SciTE Jump • Settings INI • SHELLHOOK • Shunting-Yard • Signature Creator • Stack() • Stopwatch() • StringAddLF()/StringStripLF() • StringEOLToCRLF() • VSCROLL • WM_COPYDATA • More Examples... Updated: 22/04/2018
Moderators Melba23 Posted January 3, 2014 Moderators Posted January 3, 2014 michaelslamet,There are lots of CSV-to-Array functions - which is essentially what you are doing - on the forum. Take a look at some of them and see how they have been constructed. M23 Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind Open spoiler to see my UDFs: Reveal hidden contents ArrayMultiColSort ---- Sort arrays on multiple columnsChooseFileFolder ---- Single and multiple selections from specified path treeview listingDate_Time_Convert -- Easily convert date/time formats, including the language usedExtMsgBox --------- A highly customisable replacement for MsgBoxGUIExtender -------- Extend and retract multiple sections within a GUIGUIFrame ---------- Subdivide GUIs into many adjustable framesGUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView itemsGUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeViewMarquee ----------- Scrolling tickertape GUIsNoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxesNotify ------------- Small notifications on the edge of the displayScrollbars ----------Automatically sized scrollbars with a single commandStringSize ---------- Automatically size controls to fit textToast -------------- Small GUIs which pop out of the notification area
Solution mikell Posted January 3, 2014 Solution Posted January 3, 2014 (edited) This ? expandcollapse popup#include <array.au3> #include <date.au3> Opt("TrayIconDebug", 1) Local $tdata, $arr ; generate data for testing For $1 = 1 to 2000 $tdata &= 'user' & stringformat('%04i',random(1,1000,1)) & ' :: ' & 'www.' for $2 = 1 to random(5,16,1) $tdata &= chr(random(97,122,1)) Next $tdata &= '.com :: ' $tdata &= _dateadd('D',random(-365,365,1),_NowCalcDate()) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) & @LF Next ; ==> generate data for testing local $st = timerinit() Local $arr StringSplit2D ($tdata, $arr, @LF, "::") ConsoleWrite(stringformat('Time to run %03i records = %2.4f',$1-1,timerdiff($st)/1000) & @lf) ;msgbox(0,"", stringformat('Time to run %03i records = %2.4f',$1-1,timerdiff($st)/1000)) _ArrayDisplay($arr) Func StringSplit2D($string, ByRef $aArray, $aDelim1 = @crlf, $aDelim2 = ";") $string = StringStripWS($string, 3) Local $aTemp, $aSplit, $iRows, $iCols $aTemp = StringSplit($string, $aDelim1, 3) $iRows = UBound($aTemp) $iCols = 1 Dim $aArray[$iRows][$iCols] For $i = 0 to $iRows-1 $aSplit = StringSplit($aTemp[$i], $aDelim2, 3) If $iCols < UBound($aSplit) Then $iCols = UBound($aSplit) Redim $aArray[$iRows][$iCols] EndIf For $j = 0 to UBound($aSplit)-1 $aArray[$i][$j] = $aSplit[$j] Next Next EndFunc Edit : added StringStripWS Edited January 3, 2014 by mikell michaelslamet 1
michaelslamet Posted January 3, 2014 Author Posted January 3, 2014 On 1/3/2014 at 3:51 PM, mikell said: This ? expandcollapse popup#include <array.au3> #include <date.au3> Opt("TrayIconDebug", 1) Local $tdata, $arr ; generate data for testing For $1 = 1 to 2000 $tdata &= 'user' & stringformat('%04i',random(1,1000,1)) & ' :: ' & 'www.' for $2 = 1 to random(5,16,1) $tdata &= chr(random(97,122,1)) Next $tdata &= '.com :: ' $tdata &= _dateadd('D',random(-365,365,1),_NowCalcDate()) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) $tdata &= ' :: ' & random(1000,100000,1) & @LF Next ; ==> generate data for testing local $st = timerinit() Local $arr StringSplit2D ($tdata, $arr, @LF, "::") ConsoleWrite(stringformat('Time to run %03i records = %2.4f',$1-1,timerdiff($st)/1000) & @lf) ;msgbox(0,"", stringformat('Time to run %03i records = %2.4f',$1-1,timerdiff($st)/1000)) _ArrayDisplay($arr) Func StringSplit2D($string, ByRef $aArray, $aDelim1 = @crlf, $aDelim2 = ";") $string = StringStripWS($string, 3) Local $aTemp, $aSplit, $iRows, $iCols $aTemp = StringSplit($string, $aDelim1, 3) $iRows = UBound($aTemp) $iCols = 1 Dim $aArray[$iRows][$iCols] For $i = 0 to $iRows-1 $aSplit = StringSplit($aTemp[$i], $aDelim2, 3) If $iCols < UBound($aSplit) Then $iCols = UBound($aSplit) Redim $aArray[$iRows][$iCols] EndIf For $j = 0 to UBound($aSplit)-1 $aArray[$i][$j] = $aSplit[$j] Next Next EndFunc Edit : added StringStripWS Wow, Time to run 2000 records = 0.0773 versus my previous function: Time to run 2000 records = 37.2815 That was a HUGE different! Thanks alot, Mikell. Your modified function works great and very fast! The ReDim statement only called once versus my previous one that called on every loop (that is why guinness suggest me to read about _ReDim) Thanks too to guinness and M23. Thanks again!!
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now