Jump to content
VenusProject2

StringExplode behavior after upgrading from 3.3.10.2 to 3.3.12.0

Recommended Posts

VenusProject2

Hello, have only just upgraded Autoit from 3.3.10.2 to 3.3.12.0 & now my scripts that use _StringExplode on a delimiter = @CRLF insert the delimiter as an element in the array, the script below demonstrates this.

Text file is

1,2
3,4
4,5
6,7
8,9
9,0

The _ArrayDisplay (3.3.12.0) is:

[0] 1,2
[1]
[2] 3,4
[3]
[4] 4,5
[5]
[6] 6,7
[7]
[8] 8,9
[9]
[10] 9,0
[11]
[12]

The _ArrayDisplay (3.3.10.2) is:

[0] 1,2
[1] 3,4
[2] 4,5
[3] 6,7
[4] 8,9
[5] 9,0
[6]

#Include <File.au3>
#Include <Array.au3>
#include <String.au3>
$h = FileOpen("c:\test\stringexplode.txt",$FO_READ)

;stringexplode.txt - below
#cs CRLF at end of eachline
1,2
3,4
4,5
6,7
8,9
9,0

#ce

$sTest = FileRead($h)
FileClose($h)
$aTest = _StringExplode($sTest,@CRLF)
_ArrayDisplay($aTest);The array includes the delimiter as an element, this behavior is different to autoit 3.3.10.2, what am I missing??

I did check "Array UDF - Script Breaking Changes" but didn't find a reference to this.

I have attached the original text file for convenience

Appreciate any insight, thank you

StringExplode.txt

Share this post


Link to post
Share on other sites
iamtheky

one or the other, and with a -1 gets rid of the empty

$aTest = _StringExplode($sTest, @LF , -1)

or

$aTest = _StringExplode($sTest,@CR , -1)


,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites
VenusProject2

Thanks, I did test your proposal & certainly it did remove the @CRLF as an array element, the only issue I have is that after I use "FileWriteLine" to recreate the original text file(see script below), viewed using Notepad ++ I see additional LF(if delimiter = @CR), this is an issue for my database of text files with CRLF @ the end of each line of text.

Here is my demo script to illustrate the issue:

#Include <File.au3>
#Include <Array.au3>
#include <String.au3>
$h = FileOpen("c:\test\stringexplode.txt",$FO_READ)

;stringexplode.txt - below
#cs CRLF at end of eachline
1,2
3,4
4,5
6,7
8,9
9,0

#ce

$sTest = FileRead($h)
FileClose($h)
$aTest = _StringExplode($sTest,@CR)
_ArrayDisplay($aTest);The array includes the delimiter, this behavior is different to autoit 3.3.10.2, what am I missing??

;Rewrite the file to a new text file
$h = FileOpen("c:\test\stringexplode1.txt",$FO_OVERWRITE+$FO_CREATEPATH)
For $i = 0 to UBound($aTest)-1
    FileWriteLine($h,$aTest[$i])
Next
FileClose($h)
$h = FileOpen("c:\test\stringexplode1.txt",$FO_READ)
$sTest = FileRead($h)
ConsoleWrite("! $sTest" & @CRLF)
ConsoleWrite($sTest & @CRLF);viewed in console window the read file has an empty line between lines with text, in notepad++ u can see an extra LF(view=>Show Symbol=>'Show End Of Line' characters)

Any thoughts?? Thank you

Share this post


Link to post
Share on other sites
Malkey

Looking at the function _StringExplode in String.au3 in the include directory you will see  

Return StringSplit($sString, $sDelimiter, $STR_NOCOUNT)

where $STR_NOCOUNT = 2

Previous versions of AutoIt has

Return StringSplit($sString, $sDelimiter, 3)

where 3 = 1+ 2 =  $STR_ENTIRESPLIT (1) +  $STR_NOCOUNT (2)

My advice is to use StringSplit($sTest, @CRLF, 3) in your script instead of _StringExplode($sTest,@CR)

This appears to be an introduced bug into the  _StringExplode function.

The extra lines are introduced because  each character in the delimiter string in _StringExplode  will mark where to split the string.   And @CRLF is two characters.
 

  • Like 1

Share this post


Link to post
Share on other sites
Melba23

Hi,

Fixed in the next Beta.

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites
VenusProject2

Thanks Malkey, your advise worked like a charm, I really appreaciate it....

My advice is to use StringSplit($sTest, @CRLF, 3) in your script instead of _StringExplode($sTest,@CR)

This appears to be an introduced bug into the  _StringExplode function.
 

 

Melba we look forward to the return of _StringExplode less it's aberrant behavior..lol

Hi,

Fixed in the next Beta.

M23

Share this post


Link to post
Share on other sites
guinness

Sorry about that. Literally have no idea how that happened.

Edit: I introduced the bug back in rev 9497 on 04 January 2014 03:08:00. So my apologies. By the looks of the time it was late!

Edited by guinness

UDF List:

 
_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_ArrayFilter/_ArrayReduce_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 22/04/2018

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • Skeletor
      By Skeletor
      Hi Virtual People,
      My array works perfectly fine. However, what is the best practice if the line in the array doesn't have the correct amount of columns and if I can add a placeholder?

       
      For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") Next  
    • MrCheese
      By MrCheese
      hi all,
      reviewing the forum, this thread is applicable: 
       
       
      I wanted to know if there is now a better way to do this?
      In essence, I load a tab delimited txt file into an array (works well). I used tab, as some fields in the original csv contains commas.
      However, I needed autoit to manipulate this array, and output it as a csv.
      IF my array contains items with a comma, without double quotes around the field, then how best do I get a csv out of this?
      My current workaround is to filewritefromarray tab delimited, then open it in excel and save as a csv. I will need to check this to see how the address fields behave that contain a comma.
       
      Any thoughts would be appreciated.
       
    • Skeletor
      By Skeletor
      Hi All,

      I would like to know how you would take a FileLineRead and insert it into an array which then inserts it into Excel?
      One thing to know is the files content is broken up, so I only use half of the content within $FileRead1.
      So its imperative that the $value1, $value2, etc variables be used. 
      Code below:
      $FileRead1 = FileReadLine("C:\temp\sample.txt",1) For $count = 1 To _FileCountLines($FileRead1) Step 1 $string = FileReadLine($FileRead1, $count) $input = StringSplit($string, ",", 1) $value1 = $input[1] $value2 = $input[2] $value3 = $input[3] $value4 = $input[4] _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value1, "A1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value2, "B1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value3, "C1") _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $value4, "D1") Next  
    • AnonymousX
      By AnonymousX
      Hello,
      I'm trying to write a script that moves copies excel cells into an array. I'll than manipulate the values and send array into another program. 
      I don't want range to be specific to a workbook, or sheet, or set of cells.
      I want user to be able to highlight desired cells and to copy either normally ("Ctrl+C") or by a hotkey ("Alt+C"). 
      Could someone help me with this?
      Thank you,
      I've tried to write the framework: (edited)
      #include <MsgBoxConstants.au3> #include <Array.au3> #include <Excel.au3> HotKeySet("!v", "Pastedata") While True Sleep(1000) WEnd func Makearray() local $bArray ;User has cells already copied ;Convert clipboard into an array ;I don;t know how excel stores data to clipboard so don;t know how to bring it into array _Arraydisplay($bArray) MsgBox(0,0,$bArray) return $bArray endfunc func Pastedata() Local $aArray MsgBox(0,0,"wait",1) ;make array based on assumption user has already copied a range to clipboard $aArray = Makearray() ;paste code ;don;t worry about this I got the rest endfunc  
    • Dzenan03
      By Dzenan03
      I want to make a while loop, that creates variables based on a array. For thist I created the array $iDsO with the number and the name of folders in an other folder. Every folder has a different name an I want to create variables(arrays) for each folder that show me all the files in that folder. For example: I have the Folder \Folder1. In it there are the Folders \1, \2, \3. In 1, 2 and 3 there are some files(.png). The array for Folder1 is $iDsO and now I want to crate the arrays $iDsO1, $iDsO2 and $iDsO3 with the files in them can I make something like this:
      While $iDs > 0 ;$iDs is the number of files in Folder1>> $iDsO[0] $iDs#here should come the Foldername for example '1'# = _FileListtoArray(@ProgramFilesDir&"\Folder1\"&$iDsO[$iDs]) $iDs = $iDs - 1 Wend So that in the End I have three variabels ($iDs1, $iDs2 and $iDs3)
       
      Is this posible or if not what could I do instead ( I don´t know the number of folders in Folder1 in the begining).
×