StringExplode behavior after upgrading from 3.3.10.2 to 3.3.12.0

[VenusProject2]

Hello, have only just upgraded Autoit from 3.3.10.2 to 3.3.12.0 & now my scripts that use _StringExplode on a delimiter = @CRLF insert the delimiter as an element in the array, the script below demonstrates this.

Text file is

1,2
3,4
4,5
6,7
8,9
9,0

The _ArrayDisplay (3.3.12.0) is:

[0] 1,2
[1]
[2] 3,4
[3]
[4] 4,5
[5]
[6] 6,7
[7]
[8] 8,9
[9]
[10] 9,0
[11]
[12]

The _ArrayDisplay (3.3.10.2) is:

[0] 1,2
[1] 3,4
[2] 4,5
[3] 6,7
[4] 8,9
[5] 9,0
[6]

#Include <File.au3>
#Include <Array.au3>
#include <String.au3>
$h = FileOpen("c:\test\stringexplode.txt",$FO_READ)

;stringexplode.txt - below
#cs CRLF at end of eachline
1,2
3,4
4,5
6,7
8,9
9,0

#ce

$sTest = FileRead($h)
FileClose($h)
$aTest = _StringExplode($sTest,@CRLF)
_ArrayDisplay($aTest);The array includes the delimiter as an element, this behavior is different to autoit 3.3.10.2, what am I missing??

I did check "Array UDF - Script Breaking Changes" but didn't find a reference to this.

I have attached the original text file for convenience

Appreciate any insight, thank you

StringExplode.txt

[iamtheky]

one or the other, and with a -1 gets rid of the empty

$aTest = _StringExplode($sTest, @LF , -1)

or

$aTest = _StringExplode($sTest,@CR , -1)

[VenusProject2]

Thanks, I did test your proposal & certainly it did remove the @CRLF as an array element, the only issue I have is that after I use "FileWriteLine" to recreate the original text file(see script below), viewed using Notepad ++ I see additional LF(if delimiter = @CR), this is an issue for my database of text files with CRLF @ the end of each line of text.

Here is my demo script to illustrate the issue:

#Include <File.au3>
#Include <Array.au3>
#include <String.au3>
$h = FileOpen("c:\test\stringexplode.txt",$FO_READ)

;stringexplode.txt - below
#cs CRLF at end of eachline
1,2
3,4
4,5
6,7
8,9
9,0

#ce

$sTest = FileRead($h)
FileClose($h)
$aTest = _StringExplode($sTest,@CR)
_ArrayDisplay($aTest);The array includes the delimiter, this behavior is different to autoit 3.3.10.2, what am I missing??

;Rewrite the file to a new text file
$h = FileOpen("c:\test\stringexplode1.txt",$FO_OVERWRITE+$FO_CREATEPATH)
For $i = 0 to UBound($aTest)-1
    FileWriteLine($h,$aTest[$i])
Next
FileClose($h)
$h = FileOpen("c:\test\stringexplode1.txt",$FO_READ)
$sTest = FileRead($h)
ConsoleWrite("! $sTest" & @CRLF)
ConsoleWrite($sTest & @CRLF);viewed in console window the read file has an empty line between lines with text, in notepad++ u can see an extra LF(view=>Show Symbol=>'Show End Of Line' characters)

Any thoughts?? Thank you

[Malkey]

Looking at the function _StringExplode in String.au3 in the include directory you will see  

Return StringSplit($sString, $sDelimiter, $STR_NOCOUNT)

where $STR_NOCOUNT = 2

Previous versions of AutoIt has

Return StringSplit($sString, $sDelimiter, 3)

where 3 = 1+ 2 =  $STR_ENTIRESPLIT (1) +  $STR_NOCOUNT (2)

My advice is to use StringSplit($sTest, @CRLF, 3) in your script instead of _StringExplode($sTest,@CR)

This appears to be an introduced bug into the  _StringExplode function.

The extra lines are introduced because  each character in the delimiter string in _StringExplode  will mark where to split the string.   And @CRLF is two characters.
 

[Melba23]

Hi,

Fixed in the next Beta.

M23

[VenusProject2]

Thanks Malkey, your advise worked like a charm, I really appreaciate it....

My advice is to use StringSplit($sTest, @CRLF, 3) in your script instead of _StringExplode($sTest,@CR)

This appears to be an introduced bug into the  _StringExplode function.
 

 

Melba we look forward to the return of _StringExplode less it's aberrant behavior..lol

Hi,

Fixed in the next Beta.

M23

[guinness]

Sorry about that. Literally have no idea how that happened.

Edit: I introduced the bug back in rev 9497 on 04 January 2014 03:08:00. So my apologies. By the looks of the time it was late!

Edited April 20, 2015 by guinness