Jump to content
Newb

Parsing multiline (& _) string concatenation results in error

Recommended Posts

Newb

Hi,

I get an error when trying to build a multiline concatenated string with comments inbetween. I think it's more like a minor bug than a real problem, but since I saw bug report forums are closed/archived and I don't know if it's a kown thing or not, I'm gonna post it here to be sure if this needs to be reported as a bug or it's not.

 

This example I made for this purpose works:

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>

Global $Form1 = GUICreate("Test", 150, 168, 392, 362)
Global $Input1 = GUICtrlCreateInput("1", 3, 10, 130, 21)
Global $Input2 = GUICtrlCreateInput("11", 3, 43, 130, 21)
Global $Input3 = GUICtrlCreateInput("123", 4, 76, 130, 21)
Global $Input4 = GUICtrlCreateInput("1234", 4, 108, 130, 21)
Global $BtnTest = GUICtrlCreateButton("Test", 3, 136, 130, 25)
GUISetState(@SW_SHOW)

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

While 1
    Local $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $BtnTest
            MsgBox(0,"test",$TestString)
    EndSwitch
WEnd

 

But this throws errors during compilation:

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>

Global $Form1 = GUICreate("Test", 150, 168, 392, 362)
Global $Input1 = GUICtrlCreateInput("1", 3, 10, 130, 21)
Global $Input2 = GUICtrlCreateInput("11", 3, 43, 130, 21)
Global $Input3 = GUICtrlCreateInput("123", 4, 76, 130, 21)
Global $Input4 = GUICtrlCreateInput("1234", 4, 108, 130, 21)
Global $BtnTest = GUICtrlCreateButton("Test", 3, 136, 130, 25)
GUISetState(@SW_SHOW)

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _
;Crash my building here pls!
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

While 1
    Local $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $BtnTest
            MsgBox(0,"test",$TestString)
    EndSwitch
WEnd

Did one more test and found that this is true also for code and not only for string concatenations. The code gets evaluated as actual code even if it's a comment. Look at the If statement:

This works:

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>

Global $Form1 = GUICreate("Test", 150, 168, 392, 362)
Global $Input1 = GUICtrlCreateInput("1", 3, 10, 130, 21)
Global $Input2 = GUICtrlCreateInput("11", 3, 43, 130, 21)
Global $Input3 = GUICtrlCreateInput("123", 4, 76, 130, 21)
Global $Input4 = GUICtrlCreateInput("1234", 4, 108, 130, 21)
Global $BtnTest = GUICtrlCreateButton("Test", 3, 136, 130, 25)
GUISetState(@SW_SHOW)

Global $ShowMessage = True

While 1
    Local $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $BtnTest
            $TestString = "Test values: " & _
                    GUICtrlRead($Input1) & "," & _
                    GUICtrlRead($Input2) & "," & _
                    GUICtrlRead($Input3) & "," & _
                    GUICtrlRead($Input4)
            If (StringLen($TestString) > 25 And _
                    $ShowMessage) Then
                MsgBox(0, "test", $TestString)
            Else
                MsgBox(0, "test", "Oh noes!")
            EndIf
    EndSwitch
WEnd

And this won't:

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>

Global $Form1 = GUICreate("Test", 150, 168, 392, 362)
Global $Input1 = GUICtrlCreateInput("1", 3, 10, 130, 21)
Global $Input2 = GUICtrlCreateInput("11", 3, 43, 130, 21)
Global $Input3 = GUICtrlCreateInput("123", 4, 76, 130, 21)
Global $Input4 = GUICtrlCreateInput("1234", 4, 108, 130, 21)
Global $BtnTest = GUICtrlCreateButton("Test", 3, 136, 130, 25)
GUISetState(@SW_SHOW)

Global $ShowMessage = True

While 1
    Local $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $BtnTest
            $TestString = "Test values: " & _
                    GUICtrlRead($Input1) & "," & _
                    GUICtrlRead($Input2) & "," & _
                    GUICtrlRead($Input3) & "," & _
                    GUICtrlRead($Input4)
            If (StringLen($TestString) > 25 And _
                ;Crash me plz!
                    $ShowMessage) Then
                MsgBox(0, "test", $TestString)
            Else
                MsgBox(0, "test", "Oh noes!")
            EndIf
    EndSwitch
WEnd

 

Edited by Newb

I'm a compulsive poster. When I post something, come to read it at least 5 minutes later after the posting, because I will edit it. I edited even this signature a few minutes later after I wrote it.

Share this post


Link to post
Share on other sites
Melba23

Newb,

I am not in the least surprised that you get a syntax error when you stick a comment in the middle of a line - would you expect this to work?

$TestString = "Test values: " & GUICtrlRead($Input1) & "," & GUICtrlRead($Input2) & "," & ;Crash my building here pls! GUICtrlRead($Input3) & "," & GUICtrlRead($Input4)

If you must have a comment in the middle of a continued string, just put it at the end of a line where it gets ignored:

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _ ;Crash my building here pls!
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

M23

P.S. And you report bugs at https://www.autoitscript.com/trac/autoit - there is a "Bug Tracker" link in the menu bar at the top of the page.


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites
Newb

Well I won't expect that to work since you put it all inline, but my comment was on the next line and wasn't including the actual code.

From my point of view, there is no much difference between

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _ ;Crash my building here pls!
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

and

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _ 
;Crash my building here pls!
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

expecially when the syntax highlighter colors hints me that autoit will read that comment line as a comment (green) and the code as code (other colors).
In your inline example

$TestString = "Test values: " & GUICtrlRead($Input1) & "," & GUICtrlRead($Input2) & "," & ;Crash my building here pls! GUICtrlRead($Input3) & "," & GUICtrlRead($Input4)

the syntax highlighter hints me that everything after the semicolon is read as a comment so I'm expecting  that to not work of course.

Anyway I didn't reported it as a bug because I wanted a second opinion about this and wanted to know if this it's worth reporting.


I'm a compulsive poster. When I post something, come to read it at least 5 minutes later after the posting, because I will edit it. I edited even this signature a few minutes later after I wrote it.

Share this post


Link to post
Share on other sites
spudw2k

Though the help file doesn't explicitly say it, Melba's demonstration is a good explanation of why breaking the multiline with a comment won't work. However the help file does show how to, "combine underscore and semicolon to put comments on lines and still have a long statement span on next line." (also demonstrated by Melba).

Edited by spudw2k
grammar
  • Like 1

Share this post


Link to post
Share on other sites
Melba23

Newb,

From my point of view, there is no much difference

But from the point of view of the interpreter there most certainly is - it expects the next line after a continuation character to be the next part of the string.

 I wanted a second opinion about this and wanted to know if this it's worth reporting

You have one and it is not.

M23 

  • Like 1

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites
Newb

Ok guys, thanks for the clarification!


I'm a compulsive poster. When I post something, come to read it at least 5 minutes later after the posting, because I will edit it. I edited even this signature a few minutes later after I wrote it.

Share this post


Link to post
Share on other sites
Exit

Just prefix the commentline with:  "" & _ ; 

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>

Global $Form1 = GUICreate("Test", 150, 168, 392, 362)
Global $Input1 = GUICtrlCreateInput("1", 3, 10, 130, 21)
Global $Input2 = GUICtrlCreateInput("11", 3, 43, 130, 21)
Global $Input3 = GUICtrlCreateInput("123", 4, 76, 130, 21)
Global $Input4 = GUICtrlCreateInput("1234", 4, 108, 130, 21)
Global $BtnTest = GUICtrlCreateButton("Test", 3, 136, 130, 25)
GUISetState(@SW_SHOW)

$TestString = "Test values: " & _
GUICtrlRead($Input1) & "," & _
GUICtrlRead($Input2) & "," & _
"" & _ ;  Do NOT crash my building here pls!
GUICtrlRead($Input3) & "," & _
GUICtrlRead($Input4)

While 1
    Local $nMsg = GUIGetMsg()
    Switch $nMsg

        Case $GUI_EVENT_CLOSE
            Exit
        Case $BtnTest

            MsgBox(0,"test",$TestString)
    EndSwitch
WEnd

 

 


My UDFs, Abbrevs and Snippets
If you like my post, just click the like button :) 

Share this post


Link to post
Share on other sites
232showtime

Hello all one quick silly question if u dnt mind, this is kinda off topic dnt wnt to start another thread for small issue. Whats the use of underscore ? What does it do? Is it like a @CRLF or break?, or something else?

Edited by 232showtime

ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites
iamtheky
  • Like 1

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites
232showtime

@boththose many thanks... ;)


ill get to that... i still need to learn and understand a lot of codes graduated.gif

Correct answer, learn to walk before you take on that marathon.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • JuanFelipe
      By JuanFelipe
      Hello friends, I would like to know how to open a GUI from another GUI, I did it the way I leave the attached code, but when closing the second GUI they all close, they could help me to solve this problem without compiling another script. Thank you #include <ButtonConstants.au3> #include <GUIConstantsEx.au3> #include <WindowsConstants.au3> $Form1 = GUICreate("Form1", 173, 126, 192, 124) $Button1 = GUICtrlCreateButton("Button1", 16, 24, 75, 25) GUISetState(@SW_SHOW) While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE Exit Case $Button1 _form2() EndSwitch WEnd ;================================================= GUI 2 Func _form2() $Form1 = GUICreate("Form2", 615, 437, 192, 124) GUISetState(@SW_SHOW) While 2 $nMsg = GUIGetMsg() Switch $nMsg Case $GUI_EVENT_CLOSE Exit EndSwitch WEnd EndFunc  
    • bowker
      By bowker
      Hi! Is there a way for me to set the value for my slider? I am getting the value for my slider with
       
      Local $strText = _UIA_getPropertyValue($oUIElement, $UIA_LegacyIAccessibleValuePropertyId) MsgBox(0,"",$strText)  
    • nacerbaaziz
      By nacerbaaziz
      Hello
      Can we pause and resume the download in the InetGet function?
      If is possible, what is the solution please?
      I used this code To manage the download

      #include <INet.au3> func _downloader($name, $linc, $filepath, $RTLF = false, $link = false) global $downloader = GUICreate("downloader", 400, 200, -1, -1, $WS_CLIPCHILDREn, $RTLF, $link) global $path = $filePath $labelTxt = GUICtrlCreateLabel("downloading " & $name, 50, 10, 200, 20) global $labelTxt0 = GUICtrlCreateLabel("downloaded size 0 MB " & "OF 0 MB", 50, 60, 300, 20) global $Progress = "" global $sText = ""     For $i = 1 To Random(5, 20, 1) ; Return an integer between 5 and 20 to determine the length of the string.         $sText &= Chr(Random(65, 122, 1)) ; Return an integer between 65 and 122 which represent the ASCII characters between a (lower-case) to Z (upper-case). next global $labelTxt2 = GUICtrlCreateInput("0%", 50, 80, 50, 20) _GUICtrlEdit_SetReadOnly(-1, true) GUIStartGroup("") global $beep = GUICtrlCreateCheckBox("use the progress beep notification", 150, 120, 200, 20) GUIStartGroup("") $button = GUICtrlCreateButton("Cancel', 130, 150, 180, 25, 0x01) $iIndex = 0 global $Target global $url GUIStartGroup("") global $Progress = GUICtrlCreateProgress(50, 90, 150, 20) global $Target = $filepath global $url = $linc global $path = $filepath global $hDownloadNo = _RSMWare_GetData($url, $Target) global $status = false AdlibRegister("SetProgress") global $onprogress = false, $curent = false GUISetState(@sw_Show) While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE, $button $asc = MsgBox(4132,"exit download?","if you click yes the downloading will be cancel, do you want to cancel it ?") if $asc = 6 then AdlibUnRegister("SetProgress") GUIDelete() If $hDownloadNo <> 0 Then InetClose($hDownloadNo) exitLoop endIf EndSwitch if $status = -1 then $status = 0 $hDownloadNo = _RSMWare_GetData($url, $Target) $onprogress = false $curent = false elseIf $Status = 1 then $status = $path GUIDelete() AdlibUnRegister("SetProgress") exitLoop endIf WEnd return $status endFunc Func _RSMWare_GetData($url, $Target) Local $hDownload = InetGet($url, $Target, 1, 1) Return $hDownload EndFunc ;==>_RSMWare_GetData Func SetProgress() Local $state If $hDownloadNo <> 0 Then $state = InetGetInfo($hDownloadNo) If @error = 0 Then $infor = "downloaded size " & Round(Execute(InetGetInfo($hDownloadNo, $INET_DOWNLOADREAD) / 1048576), 2) & " MB of " & Round(Execute(InetGetInfo($hDownloadNo, $INET_DOWNLOADSIZE) / 1048576), 2) & " MB " $onprogress = Round(Ceiling(($state[0] / $state[1]) * 100)) if not (InetGetInfo($hDownloadNo, $INET_DOWNLOADSIZE) = 0) then if $onProgress <= 0 then $onProgress = 0 GUICtrlSetData($Progress, $onProgress) GUICtrlSetData($labelTxt0, $infor) GUICtrlSetData($labelTxt2, $onProgress & "%") if _isChecked($beep) then if $onprogress > $curent then beep((100 + $onprogress * 20), 100) $curent = $onprogress endIf endIf endIf If $state[2] Then If $state[3] Then InetClose($hDownloadNo) $status = 1 else InetClose($hDownloadNo) $status = -1 endIf endIf EndIf endIf EndFunc ;==>SetProgress
    • VollachR
      By VollachR
      Hi,
      I'm looking for a way to take a number value from a Row2 of a 2D array and according to this check if files that appear in rows 3-11 in the array exists.
      For example, if the number in Row2 is 5 I need to check for the files in Row 3-6 only, if it is 6 than rows 3-7 and so on.
      I thought on using a FOR loop but I have very little experience with those.
      Can you suggest the best way to do what I need?
      BTW, the files in Rows 3-11 will usually have blank value for any row above the number in Row2 (e.g. Row2 = 5 so Rows3-6 will have values but 8-11 be empty), The values I need are in Column 1 of the array, the name of the key from the INI file that the array was created from is in Column 0.
      Full Example:
      Row2 of Array:
      Col0 = Games# - Col1 = 5
      Rows3-6
      Col0 = Exe2 - Col1 = Path To File
      Col0 = Exe3 - Col1 = Path To File
      Col0 = Exe4 - Col1 = Path To File
      Col0 = Exe5 - Col1 = Path To File
      I need that if Row2 is 5 to check these above for rows if the file exists, if it was 6 then the next row as well and so on up until number 10 in Row2 as it can't go above 10.
      So basically for whatever number in Row2 from 2-10 need to check 1-9 rows from 3-11 to see if the files in Col1 exists and if any of them don't exist it should call a function that shows an error message.
      I'm pretty sure I have the first line of the for look correct:
      For $i = 1 To $aAIO[2][1] Just not sure how to continue from there, also not sure if $i should be equal 1 or 2.
      Help will be appreciated.
    • VollachR
      By VollachR
      Hi,
      I've written a specialty INI file editor for a specific set of INI files related to a bigger script I'm working on.
      I'm trying to create a verification script that checks the ini files structure and format and gives an error if they are not in expected format.
      What I did so far is create a couple of custom arrays, each with the list of Sections expected in the files and I use IniReadSectionNames in order to read the sections from the selected INI file and compare it to the array.
      It works fine, excepts it only gives an error if one or more of the sections in the custom array is missing, if they all exist but there are other additional sections that shouldn't be there it doesn't give an error and continue to open the editor screen.
      Here are the relevant part of my script:
      The Custom Verification Arrays:
      ;Creating Arrays for INI Verification Global $aSettingsVerify[7] $aSettingsVerify[1] = "Conversion" $aSettingsVerify[2] = "AIO" $aSettingsVerify[3] = "Data" $aSettingsVerify[4] = "Redist" $aSettingsVerify[5] = "Split" $aSettingsVerify[6] = "Autorun" Global $aDataVerify[6] $aDataVerify[1] = "Compression" $aDataVerify[2] = "Exclude" $aDataVerify[3] = "LangExclude" $aDataVerify[4] = "PreCommands" $aDataVerify[5] = "PostCommands" The IniReadSectionNames verification part:
      Case $OK If StringInStr($ActiveConfig, "Settings.ini") Then $CheckArray1 = IniReadSectionNames($ActiveConfig) $CheckArray2 = _ArrayCompare($aSettingsVerify, $CheckArray1) $CheckArray3 = UBound($CheckArray2, 1) If $CheckArray3 = 1 Then GUIDelete($ConfigStart) SettingsGUI() EndIf If $CheckArray3 > 1 Then WrongIni() EndIf EndIf If StringInStr($ActiveConfig, "Data") Then $CheckArray1 = IniReadSectionNames($ActiveConfig) $CheckArray2 = _ArrayCompare($aDataVerify, $CheckArray1) $CheckArray3 = UBound($CheckArray2, 1) If $CheckArray3 = 1 Then GUIDelete($ConfigStart) DataGUI() EndIf If $CheckArray3 > 1 Then WrongIni() EndIf EndIf The Function that performs the compare: (Found it in another thread on this forums somewhere by using Google Search)
      ;Compares Imported INI file with the Verification array Func _ArrayCompare(ByRef $a1, ByRef $a2) Local $nOldSize = UBound($a2) Local $a3[$nOldSize], $nNewSize = $nOldSize For $i = 0 To UBound($a1) - 1 For $j = 0 To $nOldSize - 1 If Not $a3[$j] And ($a1[$i] = $a2[$j]) Then $a3[$j] = 1 $nNewSize -= 1 EndIf Next Next Local $a4[$nNewSize], $j = 0 For $i = 0 To $nOldSize - 1 If Not $a3[$i] Then $a4[$j] = $a2[$i] $j += 1 EndIf Next Return $a4 EndFunc ;==>_ArrayCompare  
      Any way to make a check if there are sections other than the ones in the Verification Array and produce an error?
      Thanks
×