Radiance

Declaring local variables in condition

4 posts in this topic

#1 ·  Posted (edited)

I didn't find anything so here's a general coding question.

I'm calling a function that has 1 parameter. Depending on the parameter the function needs to declare different varables.

Func _DoStuff($iParm)
    Switch $iParm
        Case 1
            Local $sVar1 = "w", $sVar2 = "x"
            ; do stuff
            Return
        Case 2
            Local $sVar3 = "y", $sVar4 = "z"
            ; do stuff
            Return
    EndSwitch        
EndFunc

Does declaring like this make sense?
How will this code affect my memory? Will all four variables be declared once the function is called or will only two of them be declared once the condition matches?

Edited by Radiance

Share this post


Link to post
Share on other sites



The variables will be defined when AutoIt processes the Local statement. You could check after EndSwitch.

If IsDeclared("sVar1") Then ConsoleWrite("$sVar1 is declared")
If IsDeclared("sVar3") Then ConsoleWrite("$sVar3 is declared")

 

1 person likes this

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2017-04-18 - Version 1.4.8.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2017-02-27 - Version 1.3.1.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2015-04-01 - Version 0.4.0.0) - Download - General Help & Support - Example Scripts
Excel - Example Scripts - Wiki
Word - Wiki
PowerPoint (2015-06-06 - Version 0.0.5.0) - Download - General Help & Support

Tutorials:
ADO - Wiki

 

Share this post


Link to post
Share on other sites

@Radiance, do you need all four variables? In my mind, you're saying "If condition One exists, declare "w" and "x", but if condition Two exists, declare "y" and "z". Why can't you do that with just two vars? If condition Two is true, you're not going to use "w" and "x" right?

Func _DoStuff($iParm)
    Switch $iParm
        Case 1
            Local $sVar1 = "w", $sVar2 = "x"
            ; do stuff
            Return
        Case 2
            Local $sVar1 = "y", $sVar2 = "z"
            ; do stuff
            Return
    EndSwitch        
EndFunc

 

1 person likes this

√-1 2^3 ∑ π, and it was delicious!

Share this post


Link to post
Share on other sites

Or do it the right way and declare both variables, and then set the values to them inside the switch statement. :)

Func _DoStuff($iParm)
Local $sVar1, $sVar2
    Switch $iParm
        Case 1
            $sVar1 = "w"
            $sVar2 = "x"
            ; do stuff
            Return
        Case 2
            $sVar1 = "y"
            $sVar2 = "z"
            ; do stuff
            Return
    EndSwitch        
EndFunc

Conditionally declaring variables is a bad idea.

2 people like this

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now