Jump to content
Mannyfresh15

"If Not" Not Working

Recommended Posts

Mannyfresh15

This may sound a little silly but "if Not" is not working for me I'm trying:

 

If Not @OSVersion = "WIN_XP" Then
MsgBox(0,"Aviso","Tu OS es " & @OSVersion,10)
EndIf

at the beginning of my script to check if OS is XP to run certain code if OS is not WinXP but I can't get it to work in my Win7 machine.

Please Help!

Share this post


Link to post
Share on other sites
Bowmore

Just for future reference on the correct way to use NOT in this situation.

 

If Not (@OSVersion = "WIN_XP") Then
MsgBox(0,"Aviso","Tu OS es " & @OSVersion,10)
EndIf

 


"Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to build bigger and better idiots. So far, the universe is winning."- Rick Cook

Share this post


Link to post
Share on other sites
guinness

I guess it should also be noted that ...

; This
If Not @OSVersion = 'WIN_XP' Then

; is being evaluated as
If (Not @OSVersion) = 'WIN_XP' Then

; which is essentially and as we know, boolean is !== a string
If (False) = 'WIN_XP' Then

 

Edited by guinness

UDF List:

 
_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_ArrayFilter/_ArrayReduce_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 22/04/2018

Share this post


Link to post
Share on other sites
Mannyfresh15

Thanks to all of you for your replies...

Share this post


Link to post
Share on other sites
Mannyfresh15

I would like to know if, I can use "If Not" like this:

Quote

 

If Not  (@OSVersion = "WIN_10") Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7")
  
  Then
   
   MsgBox(0, "Warning", "Your OS " & @OSVersion & " is not compatible with this version. :(", 10)
   Exit
   
 Else
    
    MsgBox(0, "Motice", "Congratulations your OS is: " & @OSVersion & " which is compatible", 10)
     
 EndIf
Quote

 

 

 

Quote
Quote

 

 

 

Share this post


Link to post
Share on other sites
Mannyfresh15

IDK what happened with this quote thing didn't let me delete them ):

Share this post


Link to post
Share on other sites
jchd

As is stands your code means:

If (Not (@OSVersion = "WIN_10")) Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7")

that is:

If (@OSVersion <> "WIN_10") Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7")

while I guess you want:

If Not ((@OSVersion = "WIN_10") Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7"))

which you can also write:

If (@OSVersion <> "WIN_10") And (@OSVersion <> "WIN_8") And (@OSVersion <> "WIN_81") And (@OSVersion <> "WIN_7")

or another more efficient and readable way:

Switch @OSVersion
    Case "WIN_10", "WIN_8", "WIN_81", "WIN_7"
    MsgBox(0, "Motice", "Congratulations your OS is: " & @OSVersion & " which is compatible", 10)
Else
    MsgBox(0, "Warning", "Your OS " & @OSVersion & " is not compatible with this version. :(", 10)
    Exit
EndSwitch

 


This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Share this post


Link to post
Share on other sites
Mannyfresh15
On 6/10/2016 at 2:07 AM, jchd said:

As is stands your code means:

If (Not (@OSVersion = "WIN_10")) Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7")

that is:

If (@OSVersion <> "WIN_10") Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7")

while I guess you want:

If Not ((@OSVersion = "WIN_10") Or (@OSVersion = "WIN_8") Or (@OSVersion = "WIN_81") Or (@OSVersion = "WIN_7"))

which you can also write:

If (@OSVersion <> "WIN_10") And (@OSVersion <> "WIN_8") And (@OSVersion <> "WIN_81") And (@OSVersion <> "WIN_7")

or another more efficient and readable way:

Switch @OSVersion
    Case "WIN_10", "WIN_8", "WIN_81", "WIN_7"
    MsgBox(0, "Motice", "Congratulations your OS is: " & @OSVersion & " which is compatible", 10)
Else
    MsgBox(0, "Warning", "Your OS " & @OSVersion & " is not compatible with this version. :(", 10)
    Exit
EndSwitch

 

Thanks for the examples

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×