Dynamic Array Size

[Ghost21]

I'm trying to get all the devices from a MySQL Database which works great then put them into a array that grows depending on the amount of devices as there could be ten there could be 1000 depending on the amount of devices on the network..

$Recordset.open("select device from pcdata", $Connection)
                    With $Recordset
                    $x = 1
                    While Not .EOF
                        $Found_Device = $Recordset.fields("DEVICE" ).Value
                        $devicearray[$x] = $Found_Device
                        $x = $x + 1
                        $devicearray[0] = $x
                        If UBound($devicearray[0]) = $devicearrayMAX Then
                            ReDim $devicearray[$devicearray[$x] + $devicearrayMAX]
                            $devicearrayMAX = $devicearray[0]
                        EndIf
                        _ArrayDisplay($devicearray)
                        .movenext
                                        Wend
                                        EndWith

I'm sure its something simple I'm missing..

[JohnOne]

Yes there is something simple missing, the rest of your code, for it to make sense

where is $devicearray from

where is $devicearrayMAX from

etc...

"If UBound($devicearray[0])"

Unless that is an array of arrays, its wrong and maybe should be If UBound($devicearray), but its impossible to tell with selective code posting.

[Minikori]

You cannot make an array change in size after you declare it. Well, you can, but that erases the content of the array. Here is a work around:

When you first declare the array, make it huge (like 65535, considering that is the maximum). Some where in your loop, have a variable counting up to tell how many times you've gone through the loop. On your giant array, have the values continually adding to the array, but always have your 0th term be the number of items in the array (like how StringSplit() returns the strings, but term 0 is how many strings in the array there are). So the extra terms in your array won't be used, but the script can know that by telling how many there are by checking the 0th term.

If that doesn't work for you, you can always have the script run through the database without saving data to see how many terms you will need, then declaring the array and running through it again, this time saving data.

The former method will be faster.

[JohnOne]

"You cannot make an array change in size after you declare it. Well, you can, but that erases the content of the array"

ReDim

[Minikori]

"You cannot make an array change in size after you declare it. Well, you can, but that erases the content of the array"

ReDim

I do not deserve to program anymore.

[jchd]

@Minikori,

Please lookup ReDim in the help file before giving such advice, since your just plain wrong here.

@Ghost21,

You don't need doing the dirty job yourself. Try this:

$Recordset.open("select device from pcdata", $Connection)
                    With $Recordset
                        If Not .EOF Then
                            $devicearray = .GetRows()
                        Else
                            $devicearray = 0
                        EndIf
                    EndWith
                    $Recordset = 0
                    _ArrayDisplay($devicearray)

[Ghost21]

Yay big thanks to everyone but especially jchd.

[guinness]

I created an Example yesterday about the most efficent way to ReDim, its called _ReDim in my signature.

Edited June 14, 2011 by guinness

[Ghost21]

When you do the

$Recordset.open("select device from pcdata", $Connection)

With $Recordset

If Not .EOF Then

$devicearray = .GetRows()

Else

$devicearray = 0

EndIf

EndWith

$Recordset.close

How do you read back each item...

_dbopen()

$Recordset.open("select device from pcdata", $Connection)

With $Recordset

If Not .EOF Then

$devicearray = .GetRows()

Else

$devicearray = 0

EndIf

EndWith

$Recordset.close

$z = UBound($devicearray)

_ArrayDisplay($devicearray)

For $x = 0 To $z

$device = $devicearray[$x] <--- keeps stopping here..

ERROR:

==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

etc..

[Ghost21]

Got it... I feel like an a.. Damn two dimensional arrays.

[jchd]

Not only!

Even with a 1D array your code will bomb out.

$z = UBound($devicearray)

_ArrayDisplay($devicearray)

For $x = 0 To $z - 1

$device = $devicearray[$x] <--- won't stop here..

Remember AutoIt arrays are zero-based! Indices run from 0 to UBound($ar1D) - 1