Checkbox and Array issue

[Chimaera]

Hi all

I have a few checkboxes that are checked and if ALL are empty when a button is pressed a msg ensues to get user to tick first.

Global $aCheckKeys[6] = [5, $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5]
For $i = 1 To $aCheckKeys[$i]
Next

If $aCheckKeys[$i] = $GUI_UNCHECKED Then
    SplashTextOn(" Install Check ", " Please Tick Required Product " & @CRLF & @CRLF & _
      " To Install Files ", 300, 80, -1, -1, 0, "Tahoma", 10, 600)
     Sleep(2000)
     SplashOff()

But it doesnt work if you press it a couple of times you get the message but one press only doesnt work?? and is it checking all the checkboxes?

One small odditty as well i had to add this

Global $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5

outside of the button section even though i global the array, anyone know why it needed both?

[Melba23]

Chimaera,

I would do it this way:

expandcollapse popup

#include <GUIConstantsEx.au3>

Global $aCheck[5]

$hGUI = GUICreate("Test", 500, 500)

For $i = 0 To 4
    $aCheck[$i] = GUICtrlCreateCheckbox("Check " & $i, 10, 10 + (30 * $i), 100, 20)
Next

$hButton = GUICtrlCreateButton("Go", 10, 300, 80, 30)

GUISetState()

While 1

    Switch GUIGetMsg()
        Case $GUI_EVENT_CLOSE
            Exit
        Case $hButton
            ; Set a flag
            $fEmpty = True
            ; Now look and see if soemthing is checked
            For $i = 0 To 4
                If GUICtrlRead($aCheck[$i]) = $GUI_CHECKED Then
                    ; If it is then clear the flag
                    $fEmpty = False
                    ; No point in looking any further
                    ExitLoop
                EndIf
            Next
            ; If the flag is still set then nothing is checked
            If $fEmpty Then
                SplashTextOn(" Install Check ", " Please Tick Required Product " & @CRLF & @CRLF & _
                        " To Install Files ", 300, 80, -1, -1, 0, "Tahoma", 10, 600)
                Sleep(2000)
                SplashOff()
            EndIf
    EndSwitch

WEnd

Any use?

M23

[JohnOne]

I suggest you post the code.

there doesn't seem to be anything relevant there.

[tlman12]

I suggest you post the code.

there doesn't seem to be anything relevant there.

i agree we'd have to see the code but i do see a couple of things wrong (maybe)

[font=monospace]

[url="http://www.autoitscript.com/autoit3/docs/keywords.htm"][color="#0000ff"]Global $aCheckKeys[6] = [5, $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5]
For $i = 1 To $aCheckKeys[$i]
Next

If $aCheckKeys[$i] = $GUI_UNCHECKED Then
    SplashTextOn(" Install Check ", " Please Tick Required Product " & @CRLF & @CRLF & _
      " To Install Files ", 300, 80, -1, -1, 0, "Tahoma", 10, 600)
     Sleep(2000)
     SplashOff()[/color][/url][/font][font=monospace]

first, theres nothing in your For loop so it's useless.

second,(related to the first) since the If statment is outside of the For loop $i is only going to equal the last number it gets to which would be 5

the reson you are probably being required to Global the $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5 is because your pobably calling then in your script at a point where autoit sees a chance that theres a possibility for them not to be declared causing a fatal error and a script crash. also you may have this "Opt("MustDeclareVars", 0)" in your script somewere near the top set to 1 ;0=no, 1=require pre-declare

[Chimaera]

I suggest you post the code.

there doesn't seem to be anything relevant there.

17 scripts all tied together way to much to post

Thanks for that melba Ive ended up with this

Case $GuiMsg = $InstallButton
            $fEmpty = True
   Global $aCheckKeys[6] = [5, $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5]
   For $i = 1 To 5
             If $aCheckKeys[$i] = $GUI_CHECKED Then
                    $fEmpty = False
                    ExitLoop
                EndIf
; Do some other stuff here ..
            If $fEmpty Then
                SplashTextOn(" Install Check ", " Please Tick Required Product " & @CRLF & @CRLF & _
                    " To Install Files ", 300, 80, -1, -1, 0, "Tahoma", 10, 600)
                Sleep(2000)
                SplashOff()

But ive hit a snag, whilst it checks them sort of how its supposed to it is checking for the All condition only if all 5 are empty can it trigger as it stands it checks one then the next etc

So it wont work as it stands

Its basically just a check for the idiots that don't tick any checkboxes and go straight to the install button. is there a way to check all 5 at once or add them together?

This is how i was doing it before and what i was trying to simplify to an array as i have a load more checkboxes to add

If GUICtrlRead($Checkbox_1 = $GUI_UNCHECKED And $Checkbox_2 = $GUI_UNCHECKED And $CheckBox_3 = $GUI_UNCHECKED And $CheckBox_4 = $GUI_UNCHECKED And $CheckBox_5 = $GUI_UNCHECKED) Then

the reson you are probably being required to Global the $Checkbox_1, $Checkbox_2, $CheckBox_3, $CheckBox_4, $CheckBox_5 is because your pobably calling then in your script at a point where autoit sees a chance that theres a possibility for them not to be declared causing a fatal error and a script crash. also you may have this "Opt("MustDeclareVars", 0)" in your script somewere near the top set to 1 ;0=no, 1=require pre-declare

Ok ive not really used for next much

i actually use this after advice from guinness

#AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w- 4 -w 5 -w 6 -w 7

Thanks for all the comments

Edited November 26, 2011 by Chimaera

[guinness]

i actually use this after advice from guinness

Great!

Edit: Also about your little 'snag' I'm not following as with Melba's example it will show a warning if no checkboxes are checked.

Edited November 26, 2011 by guinness

[Chimaera]

Im not saying it doesnt show a warning my problem is it goes through them one by one so i get the warning but 5 times, i need it to check and only if all 5 are empty give the warning

if 1 is ticked and 4 are not it must do nothing

[guinness]

I get the warning once, look at Melba's version again. Take the If statement (If $fEmpty Then) out of the loop & then you'll get it only once.

And also if you're using Variables e.g. $Checkbox1, $Checkbox2 then you can use a For Loop like this >>

For $i = $Checkbox1 To $Checkbox5
     ....
Next

Which is basically $i = ControlID number of Checkbox 1 to ControlID number of Checkbox 5 Edited November 26, 2011 by guinness

[Chimaera]

aah your a clever fella, yes id moved the next too far down so it was adding the if's

thank you kindly young sir

and thx to the others as well

[guinness]

You're welcome, but I would do as Melba did with mapping the ControlID returned from GUICtrlCreateCheckbox to an Array item and look at Variable Scope, because with the small snippet you've provided shows you're declaring a Global Variable within a Function, this should be declared at the top of the Script, unless it should be in Local scope?

[Chimaera]

Ill try and have a look, unfortunately this script has grown beyond the ridiculous, with one main script with 16 includes and im just starting to look at making it more streamlined

Unfortunately the control ids i think are on the includes not the main and they aren't all active at same time, its very hard to explain, they are modules and i turn them off an on depending on the product to be installed.

Within a few secs i can change one set of products for another set but it also brings more complexity and i haven't been able to come up with a better way...yet

But ill revisit melbas idea and see what can be done

[guinness]

It still shouldn't matter about the ControlID's. But trial & error as you know is the best way to really learn AutoIt.