[Solved]Problems writing text to a file

[Akarillon 0]

This line was originally used instead of the FileOpen and FileWrite commands

_WinAPI_WriteFile($hFile, DllStructGetPtr($tBuffer), StringLen($sText), $nBytes)

But WinAPI would only erase my prev text.

But FileOpen and FileWrite doesn't work.

The file is generated, but no text is inserted.

#include <WinAPI.au3>
#include <Date.au3>
DirCreate("C:\Inventory\Log")
Global $sFile, $hFile, $sText, $nBytes, $tBuffer
$aDato = _Date_Time_GetSystemTime()
$Dato = _Date_Time_SystemTimeToArray($aDato)
_WriteToLog("Topic", "text")
_WriteToLog("Topic2", "text2")

Func _WriteToLog($labelname, $Recv)
$sFile = 'C:\Inventory\Log\' & $dato[2] & $dato[0] & $dato[1] & '.log'
$sText = '' & $labelname & ' | ' & $Recv & ' ' & @CRLF & ''
$tBuffer = DllStructCreate("byte[" & StringLen($sText) & "]")
DllStructSetData($tBuffer, 1, $sText)
$hFile = _WinAPI_CreateFile($sFile, 1)
FileOpen($sFile, 1)
FileWrite($sFile, $sText)
_WinAPI_CloseHandle($hFile)
ConsoleWrite('1) ' & FileRead($sFile) & @CRLF)
EndFunc   ;==>_WriteToLog

Thanks for all help =)

Edited December 8, 2011 by Akarillon

[BrewManNH 1,254]

You don't need any of the _WinAPI items inside the function to write to the file, it's possible that because you opened it twice, the second one failed and the file is locked for writing. Try this:

#include <WinAPI.au3>
#include <Date.au3>
DirCreate("C:InventoryLog")
Global $sFile, $hFile, $sText, $nBytes, $tBuffer
$aDato = _Date_Time_GetSystemTime()
$Dato = _Date_Time_SystemTimeToArray($aDato)
_WriteToLog("Topic", "text")
_WriteToLog("Topic2", "text2")

Func _WriteToLog($labelname, $Recv)
    $sFile = 'C:InventoryLog' & $Dato[2] & $Dato[0] & $Dato[1] & '.log'
    $sText = '' & $labelname & ' | ' & $Recv & ' ' & @CRLF & ''
    $somevariable = FileOpen($sFile, 1)
    FileWrite($somevariable, $sText)
    FileClose($somevariable)
    ConsoleWrite('1) ' & FileRead($sFile) & @CRLF)
EndFunc

[water 2,098]

Why would you use the _WinAPI_* functions? For performance reasons?

[Akarillon 0]

@BrewManNH

Thanks for the solution

@Water

I just didn't know that FileOpen created a file if it was not there.

Was looking desperately for a FileCreate and only one I found was _WinAPI_CreateFile

[water 2,098]

It's in the help file, section "Remarks": Opening a file in write mode creates the file if it does not exist.

Depending on the number of records you want to write to the log I would suggest to open the log at the beginning of the script and close it before you exit. This will improve performance because opening/closing a file is quite expensive.

[Akarillon 0]

It's in the help file, section "Remarks": Opening a file in write mode creates the file if it does not exist.

Depending on the number of records you want to write to the log I would suggest to open the log at the beginning of the script and close it before you exit. This will improve performance because opening/closing a file is quite expensive.

Thanks

I am adding from 20-3000 entries, so performance would be nice