multiple If FileExisit FileDelete loop

[BigAl 0]

Hi Appologies if this has been answered before, I've have searched the forum but cant seem to find what I need. I'm am writing a script for decommissioning PC's at work, which requires varies different aspects, I run eraser on some folders to delete sensitive data, remove some directories which will always be present but I have a number of files that may or may not be present, scattered around the machine. I originally did this a large number of IF statements, which work's but is not the best so a friend suggested doing it in a loop but i'm not having much luck with it, I'm quite new to scripting and dont have any real experience apart from some VERY basic batch files. I have 12 files which may or may not be present, if 1 of the 12 files isn't present I would like it to carry on to the next file and delete it if it is there and so on through all the files. I've put a snippet of script below, which when i try and run i get an error "Until" statement with no matching "Do" statement.: Until $i = 12 Could anybody point me in the right direction for how to achieve this

Local $i = 0 ;set $i as an interger
Local $1 = ( $allusersprofile & "\Desktop\xxxxx.lnk" ) ;file 1 to delete
Local $2 = ( $public & "\Desktop\xxxxx.lnk" ) ;file 2 to delete
local $3 = ( "C:\xxxxxx.flg" ) ;file 3 to delete

Do 
   If FileExists ( $i + 1 Then )
          FileDelete ( $i + 1 )
    $i = $i + 1
 Until $i = 12

[guinness 1,495]

Look at Arrays in the AutoIt help file and wiki first, as currently you're trying evaluate a variable in the wrong manner.

Local $aFiles[4] = [3, _
    'FILEPATH_1', _
    'FILEPATH_2', _
    'FILEPATH_3']

For $i = 1 To $aFiles[0]
    If FileExists($aFiles[$i]) Then FileDelete($aFiles[$i])
Next

[Bowmore 96]

This

Do 
   If FileExists ( $i + 1 Then )
          FileDelete ( $i + 1 )
    $i = $i + 1
 Until $i = 12

could be changed to this

Do 
    FileDelete ( $i + 1 )
    $i = $i + 1
 Until $i = 12

FileDelete() will attempt to delete the file if it exists otherwise it will return 0 if the files did not exist or was protected. So there is no real need to check if it exists before trying to delete it.

[guinness 1,495]

Bowmore,

You're right, but are you sure your code works? As $i + 1 is basically a file called 1 and then 2 etc...

Edited May 20, 2013 by guinness

[jdelaney 307]

this would work:

but guinness' array is the best way to go

Local $1 =  "somefile1"
Local $2 =  "somefile2"
local $3 =  "somefile3"

For $i = 1 To 12
    ConsoleWrite(Eval($i) & @CRLF)
Next

Edit (a little more refined)

Local $iCounter = 1
Local $1 =  "somefile1"
Local $2 =  "somefile2"
local $3 =  "somefile3"

While IsDeclared($iCounter)
    ConsoleWrite(Eval($iCounter) & @CRLF)
    $iCounter+=1
WEnd

Edited May 20, 2013 by jdelaney

[BigAl 0]

Many thanks for all the quick replies I hadn't looked into array's, after guinness' first post i've got it working with the following :

 
 
 
Local $aFiles[12] ; Array defining some extra files which may or may not be present on the machine
    $aFiles[0]=$allusersprofile & "\Desktop\xxxxxxx.lnk"
    $aFiles[1]=$public & "\Desktop\xxxxxxx.lnk"
    $aFiles[2]=$homepath & "\Desktop\xxxxxx.url"
$aFiles[3]=$homepath & "\Desktop\xxxxxxx.url"
$aFiles[4]=$homepath & "\Desktop\xxxxxxx.url"
$aFiles[5]=$homepath & "Desktop\xxxxxxxx.url"
$aFiles[6]=$homepath & "Desktop\xxxxxx.lnk"
$aFiles[7]=$homepath & "Desktop\xxxxxxxxx.lnk"
$aFiles[8]="C:\xxxxxx.log"
$aFiles[9]="C:\xxxxxxxx.flg"
$aFiles[10]="C:\xxxxxx.flg"
$aFiles[11]="C:\xxxxxx.log"
 
 
 
For $i = 0 To 11
    If FileExists($aFiles[$i]) Then FileDelete($aFiles[$i], 1 )
 

Edited May 21, 2013 by BigAl

[guinness 1,495]

You can also do this...

Local $aFiles[12] = [$allusersprofile & "\Desktop\xxxxxxx.lnk", _  ; Array defining some extra files which may or may not be present on the machine
        $public & "\Desktop\xxxxxxx.lnk", _
        $homepath & "\Desktop\xxxxxx.url", _
        $homepath & "\Desktop\xxxxxxx.url", _
        $homepath & "\Desktop\xxxxxxx.url", _
        $homepath & "Desktop\xxxxxxxx.url", _
        $homepath & "Desktop\xxxxxx.lnk", _
        $homepath & "Desktop\xxxxxxxxx.lnk", _
        "C:\xxxxxx.log", _
        "C:\xxxxxxxx.flg", _
        "C:\xxxxxx.flg", _
        "C:\xxxxxx.log"]