Date.au3

[guinness]

Yes, I did. By the way, I am just thinking all those StringIsInt() seem overkill when a regular expression could be used e.g. [d-/.]

[jaberwacky]

I need to get myself into a regexp mindset.

[guinness]

Don't worry, I will look at this someday.

[jaberwacky]

I meant in general.  You know, give me a hammer and everything becomes a nail sort of deal.

[guinness]

Completed.

[Melba23]

jaberwacky,

 

  On 1/12/2014 at 2:01 PM, jaberwacky said:

I need to get myself into a regexp mindset.

Do not get too fixated on them. As GEOSoft told me when I started learning about SREs, one of the major things to learn about RegExes is when NOT to use them.

M23

[guinness]

Sometimes it's just efficient to use String() functions instead of banging your head against a brick wall to create an "all purpose" regular expression.

[jaberwacky]

Wonndering if Number is needed too?  Shouldn't they be explicitly converted to ints?  That's what the helpfile says anyway.

[jaberwacky]

I set up a comprehensive test of _DateIsValid and I see some weird results.  Maybe I am using the hh:mm:ss part wrong?  I ran it on both 3.3.10.2 and 3.3.11.2 with the same results.

I'm a numbnard sometimes.

#include <Date.au3>

_test_DateIsValid() ; without [ 00:00[:00]] -- does work

_test_DateIsValid("[ 00:00[:00]]") ; with [ 00:00[:00]] -- doesn't work

Func _test_DateIsValid(Const $hhmmss = '')  
  Local $is_valid = ''
 
  Local $days_in_month = ''
 
  Local $year, $month, $day = ''
 
  For $y = 1000 To 1001 ; usually to 2999 but 1001 for quick testing
    $year = StringFormat("%04d", $y)
    
    For $m = 1 To 12      
      $month = StringFormat("%02d", $m)
    
      $days_in_month = _DaysInMonth($year)[$m]
      
      For $d = 1 To $days_in_month    
        $day = StringFormat("%02d", $d)
      
        $is_valid = _DateIsValid($year & '/' & $month & '/' & $day & $hhmmss)
       
        ConsoleWrite(($is_valid ? '>' : '!') & " Date: " & $year & '/' & $month & '/' & $day & $hhmmss & @CRLF)
      Next
    Next
  Next
EndFunc

Edited January 14, 2014 by jaberwacky

[jaberwacky]

Ok, finally figured out the problem in my last post.   ::heh::

And so I found out that Number(...) is not needed.

expandcollapse popup

_test_DateIsValid()

Func _test_DateIsValid()  
  Local $is_valid, $days_in_month = ''
  Local $year, $month, $day, $date = ''
 
  For $y = 1000 To 2999
    $year = StringFormat("%04d", $y)
    
    For $m = 1 To 12      
      $month = StringFormat("%02d", $m)
    
      $days_in_month = _DaysInMonth($year)[$m]
      
      For $d = 1 To $days_in_month    
        $day = StringFormat("%02d", $d)
        
        $date = $year & '/' & $month & '/' & $day & " 00:00:00"
      
        $is_valid = _DateIsValid($date)
       
        ConsoleWrite(($is_valid ? '>' : '!') & " Date: " & $date & @CRLF)
      Next
    Next
  Next
EndFunc

Func _DateIsValid($sDate)  
  If StringRegExp($sDate, "(\d{4}/\d{2}/\d{2}\s+\d{2}:\d{2}(:\d{2}){0,1}|\d{4}/\d{2}/\d{2})") Then
    Return SetError(1)
  EndIf
 
  Local $asDatePart[4]
 
  Local $asTimePart[4]
 
  _DateTimeSplit($sDate, $asDatePart, $asTimePart)
 
  ; check if all contain valid values
  If $asDatePart[1] < 1000 Or $asDatePart[1] > 2999 Then Return SetError(2)
  If $asDatePart[2] < 1 Or $asDatePart[2] > 12 Then Return SetError(3)
  Local Const $iNumDays = _DaysInMonth($asDatePart[1])[$asDatePart[2]]
  If $asDatePart[3] < 1 Or $asDatePart[3] > $iNumDays Then Return SetError(4)
 
  ; check Time portion
  If $asTimePart[0] < 1 Then Return 1 ; No time specified so date must be correct
  If $asTimePart[0] < 2 Then Return 0 ; need at least HH:MM when something is specified
  If $asTimePart[0] = 2 Then $asTimePart[3] = "00" ; init SS when only HH:MM is specified
 
  If $asTimePart[1] < 0 Or $asTimePart[1] > 23 Then Return SetError(5)
  If $asTimePart[2] < 0 Or $asTimePart[2] > 59 Then Return SetError(6)
  If $asTimePart[3] < 0 Or $asTimePart[3] > 59 Then Return SetError(7)
 
  ; we got here so date/time must be good
  Return 1
EndFunc

(My regexp doesn't work though.)

Edited January 14, 2014 by jaberwacky

[guinness]

Is this a submission? As it's not adhering to the UDF standards we expect. For example SetError() without the return parameter is incorrect.

A couple of regular expressions I was thinking of for _DateIsValid()

$sDate = '2014/01/14'
$fIsDate = StringRegExp($sDate, '[^\d.\-/:]') = 0
ConsoleWrite($fIsDate & @CRLF)

$sDate = '2014/01/14T12:51:00'
$fIsDate = StringRegExp($sDate, '(?x)^\d{4}(?:[.\-/]\d{2}){2}   (?:     (?:T|\h)\d{2}:\d{2}     (?::\d{2})?     )?$') = 1
ConsoleWrite($fIsDate & @CRLF)

Edited January 14, 2014 by guinness

[jaberwacky]

  On 1/14/2014 at 11:08 AM, guinness said:

Is this a submission?

Nope.

Gosh.  SetError:

"[optional] The value to be returned by the function - if no parameter used the return value is undefined."

That's what I get for assuming the function would return 0

Edited January 14, 2014 by jaberwacky

[guinness]

So you get my point now?

[jaberwacky]

Well, it wasn't a submission just showing that it doesn't need Number() instead of just wondering outloud.

[guinness]

Oh, OK.

I won't be paying close attention to this thread much anymore, so if you have a submission post to Trac. Thanks.

Edited January 14, 2014 by guinness

[jaberwacky]

Will do.

As an aside, I post here for anyone who wants to read and respond.

Edited January 14, 2014 by jaberwacky

[guinness]

I know why trancexx chose 2006 and 2007, though she could have chosen 1995 and 1996 as well.

Edit: Just managed to get around to properly looking at that function.

Edit 2: I have left it undocumented for now, just in case people want to play around with it.

Edited January 15, 2014 by guinness

[guinness]

That's fun!

; #FUNCTION# ====================================================================================================================
; Author ........: Jason Brand <exodius at gmail dot com>
; Modified.......: guinness
; ===============================================================================================================================
Func _DateToMonth($iMonNum, $iFormat = Default)
    If $iFormat = Default Then $iFormat = 0
    $iMonNum = Int($iMonNum)
    If Not __DateIsMonth($iMonNum) Then Return SetError(1, 0, "")
    Local $tSYSTEMTIME = DllStructCreate($tagSYSTEMTIME)
    DllStructSetData($tSYSTEMTIME, "Year", @YEAR)
    DllStructSetData($tSYSTEMTIME, "Month", $iMonNum)
    DllStructSetData($tSYSTEMTIME, "Day", 1)
    Return _WinAPI_GetDateFormat(BitAND($iFormat, $DOW_LOCALE_LONGNAME) ? $LOCALE_USER_DEFAULT : $LOCALE_INVARIANT, $tSYSTEMTIME, 0, BitAND($iFormat, $DOW_SHORTNAME) ? "MMM" : "MMMM")
EndFunc   ;==>_DateToMonth

[jaberwacky]

Nice!  At this point, you might as well call yourself the author now! =D

Hey, thought you said you weren't going to pay attention to this thread anymore?

[jaberwacky]

Where is $DOW_LOCALE_LONGNAME defined?