Jump to content
TheDcoder

FileDelete fails deleting a file for no reason

Recommended Posts

TheDcoder

Hello, This is my (test) code:

FileOpen(@ScriptDir & '\' & "Test.txt", 1)
$iDeleteResult = FileDelete(@ScriptDir & '\' & "Text.txt")

$sDeleteResult = "Pass"

If $iDeleteResult = 0 Then $sDeleteResult = "Fail"

ConsoleWrite("Result: " & $sDeleteResult & @CRLF)

FileOpen does its job (i.e creating a file) but FileDelete fails deleting a simple text file? :think:

 

Thanks in Advance, TD :)


AutoIt.4.Life Clubrooms - Life is like a Donut (secret key)

Spoiler

My contributions to the AutoIt Community

If I have hurt or offended you in anyway, Please accept my apologies, I never (regardless of the situation) mean to do that to anybody!!!

3fHNZJ.gif

PLEASE JOIN ##AutoIt AND HELP THE IRC AUTOIT COMMUNITY!

Share this post


Link to post
Share on other sites
water

Do you want to delete Test.txt or Text.txt?


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2018-10-19 - Version 1.4.10.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (2018-09-01 - Version 1.3.4.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites
TheDcoder

:blink: Thanks water... Looks like I made a mistake while researching...

P.S I had this issue with FileDelete (without the spelling mistake).

Edited by TheDcoder
Opening bracket instead of closing bracket

AutoIt.4.Life Clubrooms - Life is like a Donut (secret key)

Spoiler

My contributions to the AutoIt Community

If I have hurt or offended you in anyway, Please accept my apologies, I never (regardless of the situation) mean to do that to anybody!!!

3fHNZJ.gif

PLEASE JOIN ##AutoIt AND HELP THE IRC AUTOIT COMMUNITY!

Share this post


Link to post
Share on other sites
Starstar

FileOpen(@ScriptDir & "\Test.txt", 1)

$iDeleteResult = FileDelete(@ScriptDir & '\' & "Test.txt")

$sDeleteResult = "Pass"

If $iDeleteResult = 0 Then $sDeleteResult = "Fail"

ConsoleWrite("Result: " & $sDeleteResult & @CRLF)

you are creating Test.txt and you are deleting Text.txt


Life is like a coin. You can spend it Anyway as you wish and for your kind information. "you can spend it only once."

Share this post


Link to post
Share on other sites
water

I'm sure you need to do a FileClose before you can delete a file opened by FileOpen.


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2018-10-19 - Version 1.4.10.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (2018-09-01 - Version 1.3.4.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites
TheDcoder

@water But my test code works without closing the file handle :huh:


AutoIt.4.Life Clubrooms - Life is like a Donut (secret key)

Spoiler

My contributions to the AutoIt Community

If I have hurt or offended you in anyway, Please accept my apologies, I never (regardless of the situation) mean to do that to anybody!!!

3fHNZJ.gif

PLEASE JOIN ##AutoIt AND HELP THE IRC AUTOIT COMMUNITY!

Share this post


Link to post
Share on other sites
Starstar

During file deleting(or any other operation) opened file is not a trouble........But open an other file without closing old one can confuse you........

Edited by Starstar

Life is like a coin. You can spend it Anyway as you wish and for your kind information. "you can spend it only once."

Share this post


Link to post
Share on other sites
TheDcoder

But open an other file without closing old on can confuse you

​Like this?:

FileOpen(@ScriptDir & '\' & "Test1.txt", 1)
FileOpen(@ScriptDir & '\' & "Test2.txt", 1)
FileOpen(@ScriptDir & '\' & "Test3.txt", 1)
$iDeleteResult = FileDelete(@ScriptDir & '\' & "Test3.txt")

$sDeleteResult = "Pass"

If $iDeleteResult = 0 Then $sDeleteResult = "Fail"

ConsoleWrite("Result: " & $sDeleteResult & @CRLF)

 


AutoIt.4.Life Clubrooms - Life is like a Donut (secret key)

Spoiler

My contributions to the AutoIt Community

If I have hurt or offended you in anyway, Please accept my apologies, I never (regardless of the situation) mean to do that to anybody!!!

3fHNZJ.gif

PLEASE JOIN ##AutoIt AND HELP THE IRC AUTOIT COMMUNITY!

Share this post


Link to post
Share on other sites
water

It's good coding practice to close an open file before any other operation.
When deleting the file this might not be a problem. But when copying the file there still might be some data in the cache not written to the file.

  • Like 1

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2018-10-19 - Version 1.4.10.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (2018-09-01 - Version 1.3.4.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites
water

​Like this?:

FileOpen(@ScriptDir & '\' & "Test1.txt", 1)
FileOpen(@ScriptDir & '\' & "Test2.txt", 1)
FileOpen(@ScriptDir & '\' & "Test3.txt", 1)
$iDeleteResult = FileDelete(@ScriptDir & '\' & "Test3.txt")
$sDeleteResult = "Pass"
If $iDeleteResult = 0 Then $sDeleteResult = "Fail"
ConsoleWrite("Result: " & $sDeleteResult & @CRLF)

​Don't think this is a problem for AutoIt.
The coder of the script might get confused and hence he might see unexpected results.

  • Like 1

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2018-10-19 - Version 1.4.10.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (2018-09-01 - Version 1.3.4.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites
water

Double post.

Edited by water

My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2018-10-19 - Version 1.4.10.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (2018-09-01 - Version 1.3.4.0) - Download - General Help & Support - Example Scripts - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • ahha
      By ahha
      This short script seems to show that FileDelete waits until the script exits before it actually deletes the files.  I don't understand this.  What am I missing?
      #AutoIt3Wrapper_run_debug_mode=Y ; use this to debug in console window <--- LOOK #include <File.au3> ;v1a - NOTE tried creating files in both %TEMP% and @WorkingDir and on my machine files there need admin to delete IF Autoit program has not exited. ;HMMM - FileDelete seems to work ONLY after Autoit program exits - not the behaviour I want. Tried in %TEMP% and @WorkingDir ;also tried creating files on USB drive so not subject to OS protections - same scenario - files don't delete till program exits. This is crazy - what the heck am I doing wrong? ;get unique filenames $sBatFile = _TempFile(@WorkingDir, "", ".bat") ;get bat file temp name $sOutputFile = _TempFile(@WorkingDir, "", ".res") ;get output file temp name MsgBox(0x40000,"STATUS", "$sBatFile = '" & $sBatFile & "'" & @CRLF & "$sOutputFile = '" & $sOutputFile & "'") ;create the unique files $hBatFile = FileOpen($sBatFile, $FO_OVERWRITE) $hOutputFile = FileOpen($sOutputFile, $FO_OVERWRITE) MsgBox(0x40000,"DEBUG", "Make sure these files exist." & @CRLF & "$sBatFile = '" & $sBatFile & "'" & @CRLF & "$sOutputFile = '" & $sOutputFile & "'") ;clean up $iDelete = FileDelete($sBatFile) If $iDelete = 0 Then MsgBox(0x40000,"DEBUG", "file: '" & $sBatFile & "' NOT deleted.") FileDelete($sOutputFile) If $iDelete = 0 Then MsgBox(0x40000,"DEBUG", "file: '" & $sOutputFile & "' NOT deleted.") MsgBox(0x40000,"DEBUG", "Make sure these files are DELETED" & @CRLF & "$sBatFile = '" & $sBatFile & "'" & @CRLF & "$sOutputFile = '" & $sOutputFile & "'") ;look in the directory BEFORE you hit OK in the above MsgBox and the files are NOT deleted and if you manually try you need admin permission Exit  
    • Milas
      By Milas
      Hello,
           I am working on a GUI that will perform some reg query and wmic cmds for some of our tier 1 techs. everything so far works well except for my function to get mapped printers from a remote computer. I have the function outputting the list of printers to a text file in the temp folder. at the end of the function its suppose to delete the file and that is where my issue lies. The gui wont delete the file until the GUI itself closes. this is causing an issue where if I want to run the function again the gui shuts down on me.
      #include <ButtonConstants.au3> #include <EditConstants.au3> #include <GUIConstantsEx.au3> #include <StaticConstants.au3> #include <WindowsConstants.au3> #include <inet.au3> #include <Constants.au3> #RequireAdmin #cs Program: Phone Tech utilitly tool Purpose: Assist phone techs and others with different wmic and reg query cmds to gain information from remote computers Creator: Salim C. Proctor Co-creator/Editor: John Ennis Date Created: 2 Feb 2016 Last Edited: 16 Feb 2016 Verion 1.0 #ce #Region ### START Koda GUI section ### Form= $Form1 = GUICreate("Form1", 627, 459, 192, 114) $Tab1 = GUICtrlCreateTab(0, 0, 625, 457) $TabSheet1 = GUICtrlCreateTabItem("Main") $User = GUICtrlCreateButton("Who's Logged On", 8, 40, 147, 41) $Host = GUICtrlCreateButton("Get Hostname", 8, 96, 147, 41) $Acc = GUICtrlCreateButton("User Account Info", 440, 40, 139, 41) $MAC = GUICtrlCreateButton("Get MAC Address", 8, 152, 147, 41) $nPrinter = GUICtrlCreateButton("Mapped Printers", 8, 208, 147, 41) $sUser = GUICtrlCreateInput("", 168, 48, 249, 21) $sHost = GUICtrlCreateInput("", 168, 104, 249, 21) $IP = GUICtrlCreateInput("Enter IP/Hostname", 8, 424, 161, 21) $plist = GUICtrlCreateEdit("", 168, 208, 249, 162) $sMAC = GUICtrlCreateInput("", 168, 160, 249, 21) $Ping = GUICtrlCreateButton("Ping", 208, 408, 163, 41) $mDrive = GUICtrlCreateButton("Remote C$", 440, 408, 147, 41) $TabSheet2 = GUICtrlCreateTabItem("Program Version") $search = GUICtrlCreateButton("Search", 8, 32, 147, 41) $program = GUICtrlCreateInput("Enter Program Name", 176, 40, 321, 21) $prog_list = GUICtrlCreateEdit("", 8, 96, 609, 318) GUICtrlSetData(-1, "") GUISetState(@SW_SHOW) #EndRegion ### END Koda GUI section ### While 1 $nMsg = GUIGetMsg() Switch $nMsg Case $User remote_user() Case $Host remote_host() Case $MAC remote_Mac() Case $search remote_program() Case $Ping ping_customer() Case $mDrive map_drive() Case $nPrinter get_printers() Case $Acc Account() Case $GUI_EVENT_CLOSE Exit EndSwitch WEnd Func remote_user() $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get username", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) Local $line While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd $split = StringSplit($line, @CRLF) GUICtrlSetData($sUser, $split[4]) EndFunc ;==>remote_user Func remote_host() $pid = Run(@ComSpec & " /c wmic /node:" & GUICtrlRead($IP) & " computersystem get name", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) Local $line While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd $split = StringSplit($line, @CRLF) GUICtrlSetData($sHost, $split[4]) EndFunc ;==>remote_host Func remote_Mac() $pid = Run(@ComSpec & " /c getmac /nh /s " & GUICtrlRead($IP), @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) Local $line While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd $split = StringSplit($line, @CRLF) $2ndSplit = StringSplit($split[3], "\") GUICtrlSetData($sMAC, $2ndSplit[1]) EndFunc ;==>remote_Mac Func remote_program() Local $fProgram, $nkey, $1position[33], $2position[33] Local $pid, $line1[33], $line, $array_size GUICtrlSetData($prog_list, "") GUICtrlSetState($search, $gui_disable) $fProgram = GUICtrlRead($program) $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall /s /f ' & $fProgram & ' /d| findstr "{"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd $nkey = StringSplit($line, @CRLF & @CRLF) $array_size = UBound($nkey) ReDim $1position[$array_size] ReDim $line1[$array_size] For $i = 1 To $array_size - 1 $1position[$i] = StringLen($nkey[$i]) If $1position[$i] < 132 Then $pid = Run(@ComSpec & ' /c reg query \\' & GUICtrlRead($IP) & '\' & $nkey[$i] & '| findstr /i "displayname displayversion"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) While 1 $line1[$i] &= StdoutRead($pid) If @error Then ExitLoop WEnd GUICtrlSetData($prog_list, $line1[$i] & @CRLF & "~", "~") EndIf $i = $i + 1 Next GUICtrlSetState($search, $gui_enable) EndFunc ;==>remote_program Func ping_customer() Local $error If GUICtrlRead($IP) <> "" Then $pError = RunWait("ping.exe -n 1 " & GUICtrlRead($IP), "", @SW_HIDE) Switch $pError Case 0 MsgBox(0, "Successfull", "Operation was a success!") Case 1 MsgBox(48, "ERROR CODE: 001", "Host/IP is not reachable") EndSwitch Else MsgBox(48, "ERROR CODE: 005", "No input detected") EndIf EndFunc ;==>ping_customer Func map_drive() ShellExecute("C:\Users\Salim.Proctor\Desktop\GUI\john project\c$ remote.exe") EndFunc ;==>map_drive Func get_printers() Local $pid, $sid, $sid2, $hfileopen, $sfileread, $line, $exit, $ip45, $user45 ;disables map printer button in gui GUICtrlSetState($nPrinter, $gui_disable) ;clears any previous data in the printer edit box GUICtrlSetData($plist, " ") ;reads ip address user entered $ip45 = GUICtrlRead($IP) ;reads the user name from the sUser input box $x = GUICtrlRead($sUser) ;splits the data to remove domainname\ $y = StringSplit($x, "\") ;removes a space value from the data $user45 = StringSplit($y[2], " ") ;queries the remote users registry to find thier sid $pid = Run(@ComSpec & ' /c reg query "\\' & $ip45 & '\hklm\software\microsoft\windows nt\currentversion\profilelist" /s /f "' & $user45[1] & '"', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) ;reads the standard ouput from the reg query While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd ;string splits to remove all unneeded data and get only the sid $sid = StringSplit($line, "\") $sid2 = StringSplit($sid[7], @CRLF) ;queries the remote users registry using the newly obtained sid and writes it out to a text file $pid = Run(@ComSpec & ' /c reg query \\' & $ip45 & '\hkey_users\' & $sid2[1] & '\Printers\Connections > c:\temp\printer_list.txt', @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) ;pause program to give it time to create the file Sleep(1000) ;opens the file so that it can be read If FileExists("c:\temp\printer_list.txt") Then FileWriteLine("c:\temp\printer_list.txt", "1\2\3\4\end of list") $hfileopen = FileOpen("c:\temp\printer_list.txt") EndIf $exit = " " $i = 2 ;output the data into the gui until it reaches the end of the list Do $exit = FileReadLine("c:\temp\printer_list.txt", $i) $printer_string = StringSplit($exit, "\") GUICtrlSetData($plist, $printer_string[5] & @CRLF & "~", "~") $i = $i + 1 Until $exit = "1\2\3\4\end of list" ;reeneables the gui map printer button GUICtrlSetState($nPrinter, $gui_enable) ;delete the text file that is created by the command line If FileExists("c:\temp\printer_list.txt") Then FileClose("c:\temp\printer_list.txt") FileDelete("c:\temp\printer_list.txt") EndIf EndFunc ;==>get_printers Func Account() Local $line $split = StringSplit(GUICtrlRead($sUser), "\") $pid = Run(@ComSpec & " /c net user " & $split[2] & " /domain", @SystemDir, @SW_HIDE, $STDERR_CHILD + $STDOUT_CHILD) While 1 $line &= StdoutRead($pid) If @error Then ExitLoop WEnd While 1 $line &= StderrRead($pid) If @error Then ExitLoop WEnd MsgBox(0, "STDOUT read:", $line) EndFunc ;==>Account just to reiterate the function im having issue with is func get_printers
    • johnmcloud
      By johnmcloud
      Hi guys, i have this simple script:

      #Include <File.au3> #Include <Array.au3> #include <RecFileListToArray.au3> ; External UDF $FileList=_RecFileListToArray(@Workingdir & "\Test", "*", 2, 1, 0, 2, "", "") ; Only Folder, all subfolder, full path If @Error=1 Then MsgBox (0,"","No Files\Folders Found.") Exit EndIf For $i = 1 to $FileList[0] If StringInStr(FileGetAttrib($FileList[$i]),"D") Then If DirGetSize($FileList[$i]) = 0 Then If DirRemove($FileList[$i]) Then ConsoleWrite("Dir removed: " & $FileList[$i] & @crlf) Else ConsoleWrite("Could not remove (empty?) dir: " & $FileList[$i] & @crlf) Endif Else ConsoleWrite("Not removed (contains files): " & $FileList[$i] & @crlf) Endif EndIf Next MsgBox(0,"Results", "Empty Removed")
      I have this problem. If i have a situation like this:
      EmptyDirMaster\EmptyDir\EmptyDir

      The array remove only the subfoder and don't the EmptyDirMaster. On ConsoleWrite i have:

      Could not remove (empty?) dir: Path\EmptyDirMaster
      If i start again it will delete the folder, but why don't process the first time?
      Thanks for support
×