Ownership And Permissions question

[Chimaera]

im knocking together a little attribute and permissions GUI

basically for customer drives that have been caught with the latest security virus that hides everything and changes stuff

starting with

$source = FileSelectFolder("Select Drive" , "")

so the attrib section is done basically just using

FileSetAttrib( $source & "Users", "-H", 1); basically just unhides the folder Users and sub folders

now on the permssion side i have used

RunWait(@ComSpec & "/c" & 'takeown /f $source & "*.*"'); equivalent to C:\*.* if C were chosen
RunWait(@ComSpec & "/c" & 'ICALCS $source & "*.*" /grant @UserName:F'); equivalent to C:\*.* grant current logged on user full permissions

1: So first question is this the right way to do this?

2: I have hit a snag because with file select folder if i click C drive it gives a result of C:\

but if i select c:\users folder it gives a result of C:\Users with no backslash

How do i get it to either add the backslash for all selections with FileSelectFolder

So i get

C:\ or

C:\Users\

so that *.* fits on the end of either

Or is there a way to just get the drive letter and ill add the rest like this & :\ &

Hope this makes sense

Chimaera

[JohnOne]

Maybe you should test it for the backslash with if then, using StringRight function.

If its not there, add it.

[Chimaera]

Thanks JohnOne

I ended up with this

$var = StringRight( $source, 1)
if $var = "\" Then 
$source = StringTrimRight( $source , 1) 
EndIf

Chimaera

Edited June 12, 2011 by Chimaera

[JohnOne]

Or maybe

If Not StringRight( $source, 1) == "\" Then 
$source &= "\"
EndIf

Edited June 12, 2011 by JohnOne

[GEOSoft]

Or my old favorite

$Source = StringRegExpReplace($Source, "\134*$", "\\", 1)

It will add \ if it's not there and it will replace single or multiple occurences like \\ but only at the end of the string.

[guinness]

And another I found whilst searching in File.au3, just check out _GetDirectoryFormat() in my Signature.

[Chimaera]

Or my old favorite

$Source = StringRegExpReplace($Source, "\134*$", "\\", 1)

It will add \ if it's not there and it will replace single or multiple occurences like \\ but only at the end of the string.

And the winner is GEOSoft, i have no idea "how" it does it but very clever

Thanks for the help

Chim

[Chimaera]

Can someone advise on if i have got these laid out correctly plz

Starting with

$source = FileSelectFolder("Select Drive", "C:") ;<<< just for eg
$source = StringRegExpReplace($source, "\134*$", "\\", 1) ;<<< just for eg

Giving me C:\ for eg

Then

RunWait(@ComSpec & "/c takeown /f" & $source & "/r") ;<<< is the syntax correct?

RunWait(@ComSpec & "/c ICALCS" & $source & "*.*" & "/grant @UserName:F") ;<<< is the syntax correct?

As far as i can tell its correct but doesn't seem to work, well it finishes far too quick

can someone just check it for me plz

Many thanks

Edited June 15, 2011 by Chimaera

[Joon]

I haven't check on the executable syntax but I know you're missing spaces on before and after the quotes. I also recommend using single quote and put double quotes around $source for the long file names.

RunWait(@ComSpec & " /c takeown /f " & $source & " /r");
RunWait(@ComSpec & " /c ICALCS " & $source & " *.*" & " /grant @UserName:F");

- joon

Edited June 15, 2011 by Joon

[Chimaera]

aah getting closer it opened a cmd window but just sat there with the cursor in the corner.

if i do it manually like this in a cmd window

takeown /f C:\ /r

it works fine Edited June 15, 2011 by Chimaera

[Joon]

aah getting closer it opened a cmd window but just sat there with the cursor in the corner.

if i do it manually like this in a cmd window

it works fine

hmm... can you change your code to something like this and see the console output?

$syntax = " /c takeown /f " & $source & " /r"
ConsoleWrite($syntax & @LF)
RunWait(@ComSpec & $syntax);

[Chimaera]

Here you go all seems to be correct and copied from console

/c takeown /f C:\ /r

and again window open with no text and cursor sat in corner

Edited June 15, 2011 by Chimaera

[Joon]

Here you go all seems to be correct and copied from console

and again window open with no text and cursor sat in corner

This works for me without a problem.

$syntax = " /c takeown /f C:\temp /r"
ConsoleWrite($syntax & @LF)
RunWait(@ComSpec & $syntax)

[Chimaera]

This works for me without a problem.

$syntax = " /c takeown /f C:\temp /r"
ConsoleWrite($syntax & @LF)
RunWait(@ComSpec & $syntax)

Ok i cant see what the hell is wrong here. Edited June 15, 2011 by Chimaera

[Joon]

Your code worked on me without any modification. Windows 7 Enterprise x64.

[GEOSoft]

You could be running into a permissions problem

try adding " /d y" to the end of $syntax

Also I don't remember what happens if you attempt takeown on a folder where you already have ownership. I've been playing with takeown in some code of mine and it works fine.

[Chimaera]

So the Permissions button didnt give a blank window?, im on same OS as you m8

Another odd thing for me, when the blank cmd is open you can press enter and the cursor moves down a line??

EDIT

after addy GEOSoft addition it now flashes the cmd window and exits, ill have to test it on a machine where the ownership is different

to see whats happening

Thanks for the help

Edited June 15, 2011 by Chimaera

[UEZ]

Just a hint: you can also use SubInACL to change ownership of files and folders.

Br,

UEZ

[Chimaera]

Just a hint: you can also use SubInACL to change ownership of files and folders.

Br,

UEZ

Thanks UEZ

but...

i messed with it a few years ago and its far to complicated for me to use, whilst i agree its the most powerfull but the help is also limited

and i have no idea how to start it through autoit

And it dosent seem to support Vista or above on the page you mentioned

Edited June 15, 2011 by Chimaera

[Maffe811]

This works for me without a problem.

$syntax = " /c takeown /f C:\temp /r"
ConsoleWrite($syntax & @LF)
RunWait(@ComSpec & $syntax)

The cmd window flashes for me on Win7 HomePremium 64-bit