my _ChangeVolume function

[Guest]

Hello

I searched for Func that Change my audio speakers without any hotkeys

and i found that now one worte working function for windows 7.

I decided to write my own.

this is my function:

Func _ChangeVolume($Volume_Percent)
$nircmd = @ScriptDir & "\" & "nircmd.exe "
$a_Val = ($Volume_Percent/100)*65535
Run($nircmd & "setsysvolume "&$a_Val)
EndFunc

Example use:

MsgBox(0,"Change Volume to 20","now i changing the Volume to 20",2)
_ChangeVolume(20)

Sleep(2000)

MsgBox(0,"Change Volume to 40","now i changing the Volume to 40",2)
_ChangeVolume(40)

Sleep(2000)

MsgBox(0,"Change Volume to 60","now i changing the Volume to 60",2)
_ChangeVolume(60)

Sleep(2000)

MsgBox(0,"Change Volume to 80","now i changing the Volume to 80",2)
_ChangeVolume(80)

Sleep(2000)

MsgBox(0,"Change Volume to 100","now i changing the Volume to 100",2)
_ChangeVolume(100)

Sleep(2000)
MsgBox(0,"Change Volume to 0","now i changing the Volume to 0",2)
_ChangeVolume(0)

you must to download the NirCmd to get it to work.

i have uploaded the rar with all the necessary Things

credit to

http://www.nirsoft.net/about_nirsoft_freeware.html

for the real magic

i hop that i helped for someone

EDIT:

i changed the line:

Run($nircmd & "nircmd.exe setsysvolume "&$a_Val) to Run($nircmd & "setsysvolume "&$a_Val)

Edited February 25, 2013 by Guest

[guinness]

There's an error in your NirCmd path.

[Guest]

There's an error in your NirCmd path.

what error? it is working!

you just have to place the NirCmd lik an dll in the same folder(where the script run)

[guinness]

Strange as this doesn't look correct.

@ScriptDir & "\" & "nircmd.exe nircmd.exe setsysvolume "

[Guest]

Strange as this doesn't look correct.

@ScriptDir & "\" & "nircmd.exe nircmd.exe setsysvolume "

what?

the script working..

and this is not what in my script..

in my script it is:

$nircmd = @ScriptDir & "" & "nircmd.exe "

[guinness]

But that's your code isn't it?

Func _ChangeVolume($Volume_Percent)
$nircmd = @ScriptDir & "\" & "nircmd.exe "
$a_Val = ($Volume_Percent/100)*65535
Run($nircmd & "nircmd.exe setsysvolume "&$a_Val) ; This is similar to C:\nircmd.exe nircmd.exe setsysvolume 50
EndFunc

[nitekram]

Func _ChangeVolume($Volume_Percent)
$nircmd = @ScriptDir & "\" & "nircmd.exe "
$a_Val = ($Volume_Percent/100)*65535
Run($nircmd & "nircmd.exe setsysvolume "&$a_Val)
EndFunc

What guinness is saying is that your code will not work as posted, Run($nircmd & "nircmd.exe setsysvolume "&$a_Val) has the command for nircmd.exe already in it and then you are using your variable $nircmd - which equals @ScriptDir & "" & "nircmd.exe "

[Guest]

What guinness is saying is that your code will not work as posted, Run($nircmd & "nircmd.exe setsysvolume "&$a_Val) has the command for nircmd.exe already in it and then you are using your variable $nircmd - which equals @ScriptDir & "" & "nircmd.exe "

you are right.

but i don't have nircmd.exe in C.

But the point is that the script works and you run the script in your head instead of your computer.

I had several occasions after I built to exe then there was an error .. That's why I put @ ScriptDir.

but this:

Run("nircmd.exe setsysvolume "&$a_Val)

Also works

[guinness]

Thanks nitekram.

Correct syntax is:

Func _ChangeVolume($iPercent)
    Local $iPID = 0
    Local Const $sNirPath = @ScriptDir & '\nircmd.exe'
    If FileExists($sNirPath) Then
        Local Const $iValue = (Int($iPercent) / 100) * 65535
        $iPID = Run($sNirPath & ' setsysvolume ' & $iValue)
    EndIf
    Return $iPID
EndFunc   ;==>_ChangeVolume

Edited February 25, 2013 by guinness

[wraithdu]

But the point is that the script works and you run the script in your head instead of your computer.

This is a ridiculous statement. The point is your code is wrong, and if it works it is by accident. Your error has been pointed out, and will take 2 seconds, literally 2 seconds, to fix. You're wasting more time defending the error than it would take to fix it. Why?

[Guest]

This is a ridiculous statement. The point is your code is wrong, and if it works it is by accident. Your error has been pointed out, and will take 2 seconds, literally 2 seconds, to fix. You're wasting more time defending the error than it would take to fix it. Why?

Ok sorry ..

Maybe I did not understand something.

What is the error?

i know that what i worte was like create Shortcut to:

"D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe" nircmd.exe setsysvolume 65535

the plan was to do this thing

But it is working

Edited February 24, 2013 by Guest

[guinness]

As wraithdu said the fact it works is by accident and not doubt Nir Sofer is probably a little too forgiving and thus strips nircmd.exe from the commandline parameter string.

Syntax is ... "D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe" setsysvolume 65535

Source: http://www.nirsoft.net/utils/nircmd2.html#using

[BrewManNH]

In this case, you're using NirCmd to run NirCmd. That's what everyone is trying to point out to you.

ALL you need to do is lose one of the NirCmd.exe's in your run statement. It works, but it's not a very good way to get it to work. You're running NirCmd twice when you only need to run it once. You're using memory that isn't necessary to be used up.

[Guest]

I feel even more confused now.

you say that

"D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe" setsysvolume 65535

right?

so what i did is

$nircmd

@ScriptDir "" & "nircmd.exe " "nircmd.exe setsysvolume "&$a_Val

=

D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe nircmd.exe setsysvolume 6535

EDIT

In this case, you're using NirCmd to run NirCmd. That's what everyone is trying to point out to you.

ALL you need to do is lose one of the NirCmd.exe's in your run statement. It works, but it's not a very good way to get it to work. You're running NirCmd twice when you only need to run it once. You're using memory that isn't necessary to be used up.

OK now i figured it out ..

But I did not understand why this happens.

Edited February 24, 2013 by Guest

[guinness]

You don't need to include the executable name again. Please study my code above.

[guinness]

Do you open a URL with Firefox like this?

C:\Program Files\Firfox\Firefox.exe FireFox.exe "http://example.com"

Or this?

C:\Program Files\Firfox\Firefox.exe "http://example.com"

[Guest]

OK but i mast to understand way

D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe nircmd.exe setsysvolume 6535

is like using NirCmd to run NirCmd ?

EDIT:

i still don't know but the Shortcut

"D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe" setsysvolume 65535

and

"D:ChangeVolume by gil900ChangeVolume by gil900nircmd.exe" nircmd.exe setsysvolume 65535

are both work ..

But from what you say, the first shortcut is the correct one.

I would never have known about it without you. It's not about programming. It's about basic computer knowledge ..

Edited February 24, 2013 by Guest

[nitekram]

In this case, it is about programming. You are programming the computer to do something, but in this case your code is not correct EVEN if something works, it does not mean that it is the right way. We are not testing your function - just looking at the code. And when you program - you have to do it RIGHT, otherwise you are going to create bugs in your code. And when you start trying to debug your code, you are going to be hard pressed to find out what the issue is - unless you follow guidelines.

In this code you are telling the application to open twice. Look at it like this. Say you have a browser like firefox - you want to run the application - do you click the desktop icon 4 times (2 times to open it and then two more time to open yet another window)? No. But that is what you are doing in your code. Trust that we are leading you in the right direction, and just change your code so that later you will not have issues. Then learn from this, as you would with any other experience.

[guinness]

I'm happy you understand.

[Guest]

Thanks nitekram.

Correct syntax is:

Func _ChangeVolume($iPercent)
    Local $iPID = 0
    Local Const $sNirPath = @ScriptDir & '\nircmd.exe'
    If FileExists($sNirPath) Then
        Local Const $iValue = (Int($iPercent) / 100) * 65535
        Run($sNirPath & ' setsysvolume ' & $iValue)
    EndIf
    Return $iPID
EndFunc ;==>_ChangeVolume

line 1:

for what the Local $iPID = 0 ?

line 2:

for what the "Const" and what Const do?

line 3-4:

If FileExists($sNirPath) Then

Local Const $iValue = (Int($iPercent) / 100) * 65535

Run($sNirPath & ' setsysvolume ' & $iValue)

EndIf

??

why use if?

why use Int($iPercent) and not just $iPercent ?

line 5:

again for what the $iPID?

Edited February 25, 2013 by Guest