Sign in to follow this  
Followers 0
Spiff59

Is the integrated sort within the recursive FLTA migrating to production worthwhile?

72 posts in this topic

#1 ·  Posted (edited)

I just noticed this function is in the Beta and working it's way to production... with all the sorting code and the pack of helper functions?

To be consistant are embedded sort functions going into the _FileReadFromArray and _FileWriteFromArray functions, the three _FTP_FileListToArray functions, the Excel array fucntions, the Word array functions, IE array functions?  I'm sure there are many more suitable functions. You never know when you might need a sort.

Melba could crunch this into a single function with all the current functionality, except sort, and do it in under 80 lines. It would be faster and way smaller, much more easily maintained, and not reliant upon a dozen helper functions, some of which commit the sin of calling themselves.

Why take this to production with the sort? We don't already have sort?

It is easy to see that Valik has not been around for a while.

Edited by Spiff59

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

Spiff59,

How nice of you to share your opinion with us and, given your constant belittling about this UDF since it was released, how unsurprising that you felt it necessary to do so. I do hope you feel better getting that off your chest. :)

You might care to know that many of the community do not share your low opinion and that the decision to include the UDF as part of _File.au3 was at the request of others, not myself. Furthermore, I would like to point out that the helper functions that "call themselves" are just slightly modified (for speed) variants of the standard _ArraySort QuickSort functions - should we remove those too? :huh:

Until now I have been reticent to comment openly on your frequent posts attacking this UDF, but such an open and embittered post has passed any reasonable limits of polite comment and is nothing more than flaming, pure and simple. Please note that any further such posts from you in a similar vein will be treated as such and sanctioned accordingly. :naughty:

M23

P.S. And Valik has gone and is not coming back - either live with it or leave. ;)

Edit: The above post as edited bears little resemblance to the original. This might explain any apparent over-reaction on my part.

Edited by Melba23

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

If you're reading the same post that I authored above, it's pretty focused... it presents just a single point: An argument against the inclusion of the sort option. 

Your reply references much that is beyond the actual content of my post. You mix in old history, ad hominems, threaten to sanction me, and don't address the subject of my post.

I've expressed my opinion. I'll restate it:

I feel it's unwise to create "All-in-One" functions by embedding redundant copies of other functions already within the library, such as the "standard _ArraySort QuickSort functions".  The code for the new module becomes exponentially larger, more complex, more difficult to maintain. The maintenance of the original function is also affected as updates to it will now likely need to be duplicated in other locations. The whole function library is now larger, more complex and harder to maintain.  The basic FLTA version and many other functions get along fine without an integrated search option, why must the recursive FLTA be different?

 My post above (#308) has nothing to do with years ago when a couple of the very first Melba versions were going around and I bitched that they were 98% similar to an earlier non-Melba version. We had a spat over that a long time ago. The issue was resolved. I'm long over it.

Requests for a recursive directory search are one of the most common in the forum.  They are routinely serviced in short order by yourself and a couple others usually with a one-liner saying "This is what you need..." and a link to this UDF.  Sometimes an OP will specifically ask what's the fastest, or easiest, or most efficient, way to do a recursive directory search.  In those cases, the canned answer is insufficient.  Out of probably 150-200(?) threads requesting how to do a recursive FLTA since this UDF has been available, I may have added a reply 3 or 4 times. I'll inform the OP that there are options other than 400 lines of code and 13 functions, that some things can be done in a few lines with DOS, or that there are a number of concise, single-function recursive FLTA's that are powerful and can be found using a forum search. I'm sorry if providing additional information to a request upsets anyone. My post above (#308) also has nothing to do with this.

I think the present UDF is bloatware, due to the internal sort, and that, as is, it is inappropriate for production.

I'd Love to see it go into production without the sort.  I've long felt a recursive FLTA was a needed standard function.

I did not place "OBEY ME!" in 48pt bold at the end of my post. I attacked a single idea, that of turning a mouse into an elephant for the sake of a sort option that will often not be used, and is already available in separate functions.  My intent was to present a solid argument, and evoke debate. Censure or censor me as you like. You have that power.

Share this post


Link to post
Share on other sites

I've expressed my opinion. I'll restate it

Nothing like a chip on both shoulders - makes you feel balanced! :D

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Is there an answer to Spiff's inquiry?  I have used his DOS recommendation in the past as it smoked the UDF for simple sorts.  I expected this question would lead to a better discussion, and a better understanding, rather than one liners that seem to persist from old battles.


,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

I would suggest the same to you as has been suggested to other members of this forum that complain about the current content but offer nothing in return - put up or shut up. If you can do it much better than Melba has - do it! Post it and show us all why yours is so much better. It is easy to criticize someone else's hard work with ambiguous statements about what "should" or "should not" be done.

How about, instead of posting a wall of text in this thread, actually create the better mousetrap and submit it for scrutiny :)


√-1 2^3 ∑ π, and it was delicious!

Share this post


Link to post
Share on other sites

#7 ·  Posted (edited)

@JLogan3o13 -  I haven't read everything above, but as I remember Melba often explicitly requests that people do make suggestions for consideration.

Edited by czardas

Share this post


Link to post
Share on other sites

I agree, and he is always open to suggestions. But reading through this thread, it seems there have been more digs and fewer concrete suggestions.

@Spiff - I did not mean my post to sound harsh, apologies if it came across that way. You may well have a better way of doing things; I'm just saying - put it in code format so we can all benefit.


√-1 2^3 ∑ π, and it was delicious!

Share this post


Link to post
Share on other sites

I agree, and he is always open to suggestions. But reading through this thread, it seems there have been more digs and fewer concrete suggestions.

 

I have no time to read the whole thread right now, but I understand and agree with you on principle.

Share this post


Link to post
Share on other sites

Is there a thread already in existence that discusses the

slightly modified (for speed) variants of the standard _ArraySort QuickSort

 

 
Why are the modified (for speed) variants not pushed up as changes for the _ArrayQuickSort functions and then RFLTA go there for the need?

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

boththose,

The modifications are basically the removal of errorchecking - the UDF knows it is passing an array of the correct type and so there is no requirement to check the input. Obviously that cannot be done with the standard _ArraySort functions. :)

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

#12 ·  Posted (edited)

Also including the Array UDF in File.au3, just for the sake of_ArraySort, is a huge no no.

 

If anyone should be blamed for including this UDF, blame me. I'm the one who committed it to the UDFs and asked about its inclusion, not Melba23. Therefore I am happy to hear suggestions, so long as it's kept civil.

 

It is easy to see that Valik has not been around for a while.

I don't understand what this has to do with the UDF? But it's fairly easy to see, go to his profile and you will see "Last Active". Edited by guinness

_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 04/09/2015

Share this post


Link to post
Share on other sites

#13 ·  Posted (edited)

This cannot be the only UDF that would always return the correct type, so then is slowed by the standard _ArraySort().  Why not have something more handily available like an _ArraySort_noerr() in the Array UDF.  Moreover, why not have error checking free versions of all functions where it results in a notable speed increase.

Just trying to better understand why whats good for this goose would not be for the gander.

Edited by boththose

,-. .--. ________ .-. .-. ,---. ,-. .-. .-. .-.
|(| / /\ \ |\ /| |__ __||| | | || .-' | |/ / \ \_/ )/
(_) / /__\ \ |(\ / | )| | | `-' | | `-. | | / __ \ (_)
| | | __ | (_)\/ | (_) | | .-. | | .-' | | \ |__| ) (
| | | | |)| | \ / | | | | | |)| | `--. | |) \ | |
`-' |_| (_) | |\/| | `-' /( (_)/( __.' |((_)-' /(_|
'-' '-' (__) (__) (_) (__)

Share this post


Link to post
Share on other sites

Moreover, why not have error checking free versions of all functions where it results in a notable speed increase.

Because this would cause a massive influx in "this function doesn't work!" like posts.


_AdapterConnections()_AlwaysRun()_AppMon()_AppMonEx()_BinaryBin()_CheckMsgBox()_CmdLineRaw()_ContextMenu()_ConvertLHWebColor()/_ConvertSHWebColor()_DesktopDimensions()_DisplayPassword()_DotNet_Load()/_DotNet_Unload()_Fibonacci()_FileCompare()_FileCompareContents()_FileNameByHandle()_FilePrefix/SRE()_FindInFile()_GetBackgroundColor()/_SetBackgroundColor()_GetConrolID()_GetCtrlClass()_GetDirectoryFormat()_GetDriveMediaType()_GetFilename()/_GetFilenameExt()_GetHardwareID()_GetIP()_GetIP_Country()_GetOSLanguage()_GetSavedSource()_GetStringSize()_GetSystemPaths()_GetURLImage()_GIFImage()_GoogleWeather()_GUICtrlCreateGroup()_GUICtrlListBox_CreateArray()_GUICtrlListView_CreateArray()_GUICtrlListView_SaveCSV()_GUICtrlListView_SaveHTML()_GUICtrlListView_SaveTxt()_GUICtrlListView_SaveXML()_GUICtrlMenu_Recent()_GUICtrlMenu_SetItemImage()_GUICtrlTreeView_CreateArray()_GUIDisable()_GUIImageList_SetIconFromHandle()_GUIRegisterMsg()_GUISetIcon()_Icon_Clear()/_Icon_Set()_IdleTime()_InetGet()_InetGetGUI()_InetGetProgress()_IPDetails()_IsFileOlder()_IsGUID()_IsHex()_IsPalindrome()_IsRegKey()_IsStringRegExp()_IsSystemDrive()_IsUPX()_IsValidType()_IsWebColor()_Language()_Log()_MicrosoftInternetConnectivity()_MSDNDataType()_PathFull/GetRelative/Split()_PathSplitEx()_PrintFromArray()_ProgressSetMarquee()_ReDim()_RockPaperScissors()/_RockPaperScissorsLizardSpock()_ScrollingCredits_SelfDelete()_SelfRename()_SelfUpdate()_SendTo()_ShellAll()_ShellFile()_ShellFolder()_SingletonHWID()_SingletonPID()_Startup()_StringCompact()_StringIsValid()_StringRegExpMetaCharacters()_StringReplaceWholeWord()_StringStripChars()_Temperature()_TrialPeriod()_UKToUSDate()/_USToUKDate()_WinAPI_Create_CTL_CODE()_WinAPI_CreateGUID()_WMIDateStringToDate()/_DateToWMIDateString()Au3 script parsingAutoIt SearchAutoIt3 PortableAutoIt3WrapperToPragmaAutoItWinGetTitle()/AutoItWinSetTitle()CodingDirToHTML5FileInstallrFileReadLastChars()GeoIP databaseGUI - Only Close ButtonGUI ExamplesGUICtrlDeleteImage()GUICtrlGetBkColor()GUICtrlGetStyle()GUIEventsGUIGetBkColor()Int_Parse() & Int_TryParse()IsISBN()LockFile()Mapping CtrlIDsOOP in AutoItParseHeadersToSciTE()PasswordValidPasteBinPosts Per DayPreExpandProtect GlobalsQueue()Resource UpdateResourcesExSciTE JumpSettings INISHELLHOOKShunting-YardSignature CreatorStack()Stopwatch()StringAddLF()/StringStripLF()StringEOLToCRLF()VSCROLLWM_COPYDATAMore Examples...

Updated: 04/09/2015

Share this post


Link to post
Share on other sites

boththose,

Have you even looked at the _FielListToArrayRec UDF as it currently exists in the Beta? Like the OP, probably not, as it uses a dual pivot sort algorithm which is not (yet) in the main Array.au3 UDF and the only modified existing function it uses is to concatenate various arrays - all 5 lines of it. The additional 7 lines in the existing function are pure error-checking. So chase this red herring as far as you all want. :D

As to having "faster" versions of the various UDFs by removing errorchecking - not a hope. It would essentially double the size of the #include files. Besides it would only be in special cases where they are called as intensively as in this UDF and the gains in normal use would be relatively minor. :)

And that is all I am going to say on the subject. As explained earlier, I was not the instigator of adding the UDF to the standard install - if enough people decide that it is not worthy, then appeal to the Devs to remove it. I will be perfectly happy to continue it as one of my personal UDFs in the Examples thread. But I reiterate my warning that I will not stand for any more pure flaming of the type that began this thread - just as I would not accept it in a case where I was not personally involved. :mad:

M23

1 person likes this

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

#16 ·  Posted (edited)

I  just lost 3 long paragraphs I had written in reply due to a misclick because I'm disturbed at all the popups saying things have been added to this topic.

These are all posts made on a thread with a title you wrote and then put my name to.

I find your title highly biased. It immediately engenders the thought that I oppose a recursive FLTA in production.

How about "Should we include copies of half the Sort functions in the production recursive FLTA?" for a title?

Do you like that wording?

I have a bit of stuff to retype in reply...  but want the title off, thread locked, something...

I have a history starting before you had joined the forum of strongly supporting the development of a recursive FLTA.

I put a lot of effort over a year into the very active 96952 thread, which generated many good ideas and many good examples.

 

Grr... I can't finish this now... not with your title on a thread that you made me the author of...

Edit: I am a little perturbed now.  For creating this thread, putting a misleading title on it and making me the author.  I got flustered as a dozen replies were added while I'm writing a thought-out reply, and lost my work. 

Edit2: What percentage of users have access to the dev forum to see my anti-recursive-FLTA/anti-Melba thread title? If it's small then I'm not that excited. But I don't like the thought of this thread out there trolling to the entire world impressions about myself that were concocted by another.

Edited by Spiff59

Share this post


Link to post
Share on other sites

#17 ·  Posted (edited)

Okay I have read what this is about now.

I'm just about wondering one thing that Melba said. Replacing the array sort algorithm will cause some of my older scripts to behave incorrectly. I realised this a long tiime ago when I was modelling the behaviour of the sort function. I know it's unrelated, but it's the first time I have heard this mentioned. Lucky for me I predicted the eventuality of such a change and have changed my model since, although it goes to show how much there is to consider.

Edited by czardas

Share this post


Link to post
Share on other sites

I've not looked through the UDF in beta or the UDF at all in a long time, but from what I can gather, using _ArraySort would be doing the error checking twice.

Am I correct in thinking that RFLTA tests that the array is of the correct type before passing to the faster sort?

If so, I don't see what all the fuss is about.


AutoIt Absolute Beginners    Require a serial    Pause Script    Video Tutorials by Morthawt   ipify 

Monkey's are, like, natures humans.

Share this post


Link to post
Share on other sites

For now the algorithm is not being replaced, but added as an alternative.

This is because I doesn't bring performance improvements in all cases.

Spiff, what is your specific issue with the inclusion of Melba23s function?

1 person likes this

Share this post


Link to post
Share on other sites

#20 ·  Posted (edited)

I have a tendency to rip many of the UDF functions that I use out of the includes files to make lightweight programs. With less dependancies this will be easier to do. A larger AutoIt install package is perhaps the downside, but I would have thought this to be negligible overalll.

@Mat - thanks for the new info.

Edited by czardas

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0