How do I delete empty cells in a 2D array.

[Valnurat]

I have a

Global $aResult[0][2]

For $i = 0 to UBound($aNames) -1
    Local $aUserInfo = _AD_GetObjectsInOU($aNames[$i],"","","displayName,distinguishedName")
    _ArrayDisplay($aUserInfo)
    _ArrayConcatenate($aResult, $aUserInfo, 1)
    _ArrayDisplay($aResult, 'AD ' & UBound($aResult))
Next

I do receive empty info that's added to my array.

How can I delete empty records?

[water]

Loop through the array from the end to the start und use _ArrayDelete to get rid of empty cells. 

[kylomas]

Valnurat,

Just for grins...

#include <array.au3>

Local $aArray = [[1, 2, 3], ['', '', ''], [4, 5, 6], [7, 8, 9, 0], ['', '', 'a', 'b'], [''], ['last row first cell']]

_ArrayDisplay($aArray)

For $i = UBound($aArray) - 1 To 0 Step -1
    For $j = 0 To UBound($aArray, 2) - 1
        If $aArray[$i][$j] <> '' Then ExitLoop
    Next
    If $j - 1 = UBound($aArray, 2) - 1 And $aArray[$i][$j - 1] = '' Then _ArrayDelete($aArray, $i)
Next

_ArrayDisplay($aArray)

kylomas

[water]

Exactly what I suggested above  

[kylomas]

@water - Yes, just #@$%# around...nice sunny day here in central US...

[water]

 

[iamtheky]

#include <array.au3>

Local $aArray = [[1, 2, 3], ['', '', ''], [4, 5, 6], [7, 8, 9, 0], ['', '', 'a', 'b'], [''], ['last row first cell']]

msgbox(0 , '' , stringstripWS(StringRegExpReplace(_ArrayToString($aArray) , "\|\|+" , " ") , 4))

yall don't #@$$$%# around nearly enough

Edited March 20, 2017 by iamtheky

[Valnurat]

10 hours ago, iamtheky said:

#include <array.au3>

Local $aArray = [[1, 2, 3], ['', '', ''], [4, 5, 6], [7, 8, 9, 0], ['', '', 'a', 'b'], [''], ['last row first cell']]

msgbox(0 , '' , stringstripWS(StringRegExpReplace(_ArrayToString($aArray) , "\|\|+" , " ") , 4))

yall don't #@$$$%# around nearly enough

How do I use this? How do I put this back to an array?

[Jfish]

EDIT: just answering the last question without regard to whether or not the output should be a 1D or 2D array.  If you liked the output that @iamtheky created and just want it in an array then this should work it assigns the string to a variable that splits the string back into an array using carriage returns with line feeds as the delimiter. 

#include <array.au3>

Local $aArray = [[1, 2, 3], ['', '', ''], [4, 5, 6], [7, 8, 9, 0], ['', '', 'a', 'b'], [''], ['last row first cell']]
$newArray=StringSplit(stringstripWS(StringRegExpReplace(_ArrayToString($aArray) , "\|\|+" , " ") , 4),@CRLF)
_ArrayDisplay($newArray)

 

Edited March 21, 2017 by Jfish

[Valnurat]

Ok, but this just end up in 1D array. It has to be in a 2D array.

[czardas]

I don't understand this request. Are you trying to delete empty rows in a 2D array? Deleting empty cells is impossible without also deleting rows or columns.

Edited March 21, 2017 by czardas

[Gianni]

also, why don't you check for empty records before the  _ArrayConcatenate() ?

[MilesAhead]

46 minutes ago, Chimp said:

also, why don't you check for empty records before the  _ArrayConcatenate() ?

That would be cheating.  Too easy.

[Valnurat]

17 hours ago, czardas said:

I don't understand this request. Are you trying to delete empty rows in a 2D array? Deleting empty cells is impossible without also deleting rows or columns.

My mistake. I will ofcourse delete rows. Just my bad words of choice.

 

17 hours ago, Chimp said:

also, why don't you check for empty records before the  _ArrayConcatenate() ?

And if I want to do that. How should I do that? Is there a UDF for this?

[water]

Do not use _ArrayConcatenate but loop through $aUserInfo and only write non blank rows to $aResult.

[Valnurat]

Ok. I will do that.

Thank you for all your answers.

[Gianni]

On 22/3/2017 at 8:12 AM, Valnurat said:

.... And if I want to do that. How should I do that? Is there a UDF for this? ....

I don't know what exactly is returned by the _AD_GetObjectsInOU() function , (emmm... sorry @water ) , expecially when there is not data returned, anyway if you have only to scan all records to see if are all empty then something like this should do (not tested):

Global $aResult[0][2]
Local $aUserInfo

For $i = 0 To UBound($aNames) - 1
    $aUserInfo = _AD_GetObjectsInOU($aNames[$i], "", "", "displayName,distinguishedName")
    If _IsNotEmpty($aUserInfo) Then ; there is data in the record?
        ; _ArrayDisplay($aUserInfo)
        _ArrayConcatenate($aResult, $aUserInfo, 1)
    EndIf
Next

_ArrayDisplay($aResult, 'AD ' & UBound($aResult))

Func _IsNotEmpty(ByRef $aData)
    ; returns True if record contains data otherwise returns False
    Local $iSum = 0
    For $x = 1 To UBound($aData) - 1
        $iSum += $aData[$x] <> "" ; count not empty fields
    Next
    Return $iSum > 0 ; returns true if record is not empty
EndFunc   ;==>_IsNotEmpty

 

[water]

Or you could modify the LDAP query so it only returns records where displayname<>""

[AdamUL]

Here is the _AD_GetObjectsInOU with the proper LDAP query that should get you what you need.  As mentioned by water.  This query only finds user accounts, and not computer accounts. 

$aUserInfo = _AD_GetObjectsInOU($aNames[$i], "(&(objectCategory=Person)(objectclass=user)(displayName=*))", "", "displayName,distinguishedName")

Here is some info on using LDAP Queries.  

 

Adam

 

[Valnurat]

Ok. I will try a different approach.

$aUserInfo = _AD_GetObjectsInOU("OU=company,DC=ad,DC=company,DC=org", "(&(objectCategory=Person)(objectclass=user)(sAMAccountName=" & $aNames[$i] & "*))", "", "displayName,distinguishedName")

But the result of this ends up with users that I'm not interested in. I would like to avoid where "TransferZone" is exists in distinguishedName.

Is it possble to add an extra filter?