Unable to re-use command prompt for a second command

[thegreatjedi]

I am trying to automate the execution of the chkdsk command over multiple disk drives.

expandcollapse popup

Opt("MustDeclareVars", 1)

Func RunChkDskTask()
  Local $driveList = DriveGetDrive("FIXED") ; Returns [2, "C:", "D:"]
  
  For $i = 1 To $driveList[0]
    ExecCmdCommand("chkdsk" & $driveList[$i])
  Next
EndFunc

Func ExecCmdCommand($command)
  Local $pid = 0
  Local $output = ""
  Local $splitOutput = 0
  
  _GUICtrlEdit_SetText($CmdLogEdit, "") ; GUI defined elsewhere in script
  
  $pid = Run(@ComSpec & " /c " & $command, "", @SW_HIDE, $STDIN_CHILD + $STDOUT_CHILD)
  
  While True
    $output = StdoutRead($pid)
    If @error Then
      ; We shall call this Branch A
      MsgBox(0, "", "Command: """ & $command & """ completed.")
      ExitLoop 1
    Else
      ; We shall call this Branch B
      If StringLen(StringStripWS($output, 1 + 2)) <> 0 Then
        $output = StringReplace($output, @CR, @CRLF)
        $output = StringReplace($output, @LF, @CRLF)
        $output = StringReplace($output, @CRLF & @CRLF, @CRLF)
        $splitOutput = StringSplit($output, @CRLF, 1 + 2)
        
        For $i = 0 To (UBound($splitOutput) - 2)
          _GUICtrlEdit_AppendText($CmdLogEdit, StringStripWS($splitOutput[$i], 1 + 2) & @CRLF)
        Next
      EndIf
    EndIf
  WEnd
  
  ProcessWaitClose($pid)
EndFunc

The script executes as intended for the first iteration ("chkdsk C:"): The script enters Branch B, writes all output to the GUI, and when the command completes execution it enters Branch A and exits the function. When the script enters the second iteration ("chkdsk D:"), however, it goes directly to Branch A without ever entering Branch B.

What's wrong?

Update: Further debugging shows that "chkdsk D:" is actually running smoothly in the background, although for some reason the script goes straight into Branch A from the very start even though the command hasn't completed execution yet. Additionally, attempting to manually SetError(0) before entering the while-loop didn't solve the problem.

Edited October 11, 2018 by thegreatjedi

[caramen]

Almost done ! Gl

 

Could you provide me a snippet of the working code if you dont mind please (When it will be done) ?  

 

 

Edited October 11, 2018 by caramen

[careca]

What happens if you change the error check to 

If $output = @error Then

The reason i ask is because this way we check that specific variable for error, but if it's just error, it may be an error somewhere else.