Pixelsearch issues

[adjist]

Hello, feeling kind of stupid right now as I already had this working earlier, accidentally deleted the code, came back to my pc and now I cannot remember what I did.

The basis of what i'm wanting to do is pixelsearch inside of a window specified from wingetpos

Local $a = WinGetPos("example")
$example = PixelSearch($a[0] + 585, $a[1] + 259, $a[0] + 621, $a[1] + 289, 0xDF2C33,10)
if not(@error) Then
    ControlClick("example", '', '', "left", 1, 892, 433)
endif

It gets the window position fine, but then it seems like the pixelsearch function doesnt work, at all.

 

 

Edited April 30, 2020 by adjist

[alienclone]

i have a solution, but not for your code.

i keep all my scripts in folders that are backed up on the cloud, mainly Google Drive, Dropbox, and OneDrive, with their respective syncing apps installed.

If i ever delete, or otherwise completely fubar my code i can just grab a previous version from the cloud, saves me from many hassles and headaches.

[Nine]

Shouldn't you use the array result of the PixelSearch ?  Instead of using static coordinates ?

Also remember that ControlClick uses coordinates WITHIN the control.

Edited April 30, 2020 by Nine

[careca]

@Nine from what i understand it could be a condition, more than a find and click situation.

Maybe it's like, if a certain color exists in a certain place, then click this button, which is fixed.

I just don't understand the bit:

$a[0] + 621, $a[1] + 289

If you would be so kind to explain why you made it this way..

[adjist]

5 hours ago, careca said:

@Nine from what i understand it could be a condition, more than a find and click situation.

Maybe it's like, if a certain color exists in a certain place, then click this button, which is fixed.

I just don't understand the bit:

$a[0] + 621, $a[1] + 289

If you would be so kind to explain why you made it this way..

Yes that's correct, I want to search an area within the window, and then click a button within the window if the certain color is found

[Nine]

Did you read my second comment about ControlClick ? 

If you want/need more help, you will have to give us more details on what is the application, provide screen shot, give autoit info tool results.  The more info we have, more likely we will be able to help you out.

[careca]

I think the user did not understand the remark.

I'll try to clarify: Remove the coordinates from the controlclick line (no coords = clicks the center of the control)

and insert the control id of the control you're trying to click, you can't do it like it is. Unless the button is at least 892px wide and 433px height, it will click outside of it.

Actually without the id it won't.

ControlClick("example", '', 'IDHERE', "left", 1)

Or, i think you may be looking for a different function, like this:

MouseClick("left", 892, 433, 1, 1)

 

Edited April 30, 2020 by careca

[adjist]

1 hour ago, careca said:

I think the user did not understand the remark.

I'll try to clarify: Remove the coordinates from the controlclick line (no coords = clicks the center of the control)

and insert the control id of the control you're trying to click, you can't do it like it is. Unless the button is at least 892px wide and 433px height, it will click outside of it.

Actually without the id it won't.

ControlClick("example", '', 'IDHERE', "left", 1)

Or, i think you may be looking for a different function, like this:

MouseClick("left", 892, 433, 1, 1)

 

The controlclick works perfectly fine, the issue is when I try to pixelsearch.

I am trying to "dynamically" search for the pixel, as in, getting the top left coord of a window, and then moving down to where I want to search for the pixel. If you understand that at all 

I had tried using PixelCoordMode and adding the hWnd to the pixelsearch but it didnt seem to work either.

[careca]

Right, so,

$a[0] + 585, $a[1] + 259, $a[0] + 621, $a[1] + 289

You want to start the search:

585 pixels to the right of the left border,

259 pixels to the top border,

621 from the right border, and

289 from the bottom border?

Wouldn't this mean you are searching in some sort of offset mode?

I don't understand the logic behind this line.

The image shows my understanding of that code:

the blue represents the window, and the red, the portion you are searching.

Which of the PixelCoordMode did you use? When you change the mode, you have to adapt the code.

[Bert]

11 hours ago, adjist said:

The controlclick works perfectly fine, the issue is when I try to pixelsearch.

I am trying to "dynamically" search for the pixel, as in, getting the top left coord of a window, and then moving down to where I want to search for the pixel. If you understand that at all 

I had tried using PixelCoordMode and adding the hWnd to the pixelsearch but it didnt seem to work either.

We understand perfectly WHAT you want. We are asking WHY you want it that way. In other words - what is your REASON for needing pixel search? (other than it is what you already have and you just want to fix it.) Why are you not open to a different solution that would make your code more stable?

Pixel searching - it is by far the WORST way to automate. Very unstable due to highly prone to changes by the program you are trying to automate, windows changing sizes, updates to the OS or the application by the developers of the software, display size, you name it. You ONLY use it if there is no choice to do something else. That is why we are asking you the question. 

 

[adjist]

Nevermind, ended up being able to fix it myself

Edited May 1, 2020 by adjist

[careca]

Awesome, how did you fix?

[adjist]

5 hours ago, careca said:

Awesome, how did you fix?

realized this was a thing, lol.

[careca]

That would be the same as this i guess.

Opt("PixelCoordMode", 0) ;1=absolute, 0=relative, 2=client