Script is spamming in an endless loop

[kjpolker]

I'm hesitant to even post this as there has got to be an obvious issue, though I have been a little rusty lately...

I am writing a program to catch the output of the command line window so I can have a nice little HUD for launching a server, monitoring the status etc...

When I run this, it just spams a command line window endlessly and no GUI. The first time it happened I was forced to hard reboot before adding in the termination hotkey and a long sleep at the end of the while statement. When I comment out GUISetBkColor(0x414141, -1) I at least get he GUI and no more spamming but it is completely unresponsive.

 

expandcollapse popup

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <Array.au3>

#Region
$Form1 = GUICreate("Command Line Tracker", 615, 422, -1, -1)
;~ GUISetBkColor(0x414141, -1)
GUISetIcon("Portal.ico", -1)
$Group1 = GUICtrlCreateGroup("Server Status", 8, 40, 601, 185)
GUICtrlSetFont(-1, 12, 800, 0, "MS Sans Serif")
GUICtrlSetColor(-1, 0xFFFFFF)
$Edit1 = GUICtrlCreateEdit("", 16, 64, 585, 153, BitOR($ES_UPPERCASE,$ES_AUTOVSCROLL,$ES_READONLY,$ES_WANTRETURN))
GUICtrlSetData(-1, "")
GUICtrlSetFont(-1, 14, 400, 0, "Consolas")
GUICtrlSetBkColor(-1, 0x000000)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Group2 = GUICtrlCreateGroup("Client Status", 8, 232, 601, 185)
GUICtrlSetFont(-1, 12, 800, 0, "MS Sans Serif")
GUICtrlSetColor(-1, 0xFFFFFF)
$Edit2 = GUICtrlCreateEdit("", 16, 256, 585, 153, BitOR($ES_UPPERCASE,$ES_AUTOVSCROLL,$ES_READONLY,$ES_WANTRETURN))
GUICtrlSetData(-1, "")
GUICtrlSetFont(-1, 14, 400, 0, "Consolas")
GUICtrlSetBkColor(-1, 0x000000)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Button1 = GUICtrlCreateButton("Launch Server", 8, 8, 97, 33)
GUISetState(@SW_SHOW)
#EndRegion

HotKeySet("{END}", "Terminate")

;~ $a = WinList()
;~ _ArrayDisplay($a,"Window List")

$serverdir = ("directory\file.bat")

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $Button1
            runserver()
    EndSwitch
WEnd

Func Refresh() ;Needs work, have not tested
    Sleep(100)
    If $serverrunning = 1 Then
        $MessageServer &= StdoutRead($serverid)
        GUICtrlSetData($Edit1,$MessageServer)
    EndIf
EndFunc

Func runserver()
    If $serverrunning = 0 Then
        $serverid = ShellExecute($serverdir) ;This is a batch file
        WinWaitActive("")
        WinSetState($serverid,"",@SW_MINIMIZE)
        GUICtrlSetData($Button1,"Server Running")
        $serverrunning = 1
    Else
        WinClose($serverid)
        GUICtrlSetData($Button1,"Launch Server")
        GUISetIcon("Portal.ico", ,$Form1)
        $serverrunning = 0
    EndIf
EndFunc

Func Terminate()
    Exit
EndFunc

 

Edited December 20, 2021 by kjpolker

[Danp2]

Does it work if you eliminate the 2nd parameter, ie:

GUISetBkColor(0x414141)

 

[mLipok]

  On 12/20/2021 at 2:59 PM, kjpolker said:

When I comment out GUISetBkColor(0x414141, -1)

Expand  

I had an issue with -1 in the past.
 

Do not use -1 as HWND try to use 0 or as @Danp2 said just omnit this parameter to use default value:

GUISetBkColor

Sets the background color of the GUI window.

GUISetBkColor ( background [, winhandle] )

Parameters

background	Background color of the dialog box.
winhandle	[optional] Windows handle as returned by GUICreate() (default is the previously used window).

Edited December 20, 2021 by mLipok

[kjpolker]

Yes and yes. Unbelievable detail... I am chocking up the window being non responsive when I commented out the line due to me adding in way too many safety measures so it would not happen again haha. As of now, removing the -1 on GUISetBkColor and removing all the extra bail out of loop after x seconds, hotkey terminate, sleep functions 😅 makes the GUI accurate and responsive.

Edited December 20, 2021 by kjpolker

[ad777]

kjpolker :use AdlibRegister("Refresh")

[kjpolker]

  On 12/20/2021 at 3:29 PM, ad777 said:

kjpolker :use AdlibRegister("Refresh")

Expand  

I have not used AdlibRegister before but that seems to be a handy tool for this. Do I just include it in the While loop? Also do you happen to know if setting the Data for Edit box is the best method for outputting lines?

[ad777]

Add AdlibRegister("Refresh") below #include 

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <Array.au3>
AdlibRegister("Refresh")