Jump to content

Script is spamming in an endless loop


Go to solution Solved by mLipok,

Recommended Posts

I'm hesitant to even post this as there has got to be an obvious issue, though I have been a little rusty lately...

I am writing a program to catch the output of the command line window so I can have a nice little HUD for launching a server, monitoring the status etc...

When I run this, it just spams a command line window endlessly and no GUI. The first time it happened I was forced to hard reboot before adding in the termination hotkey and a long sleep at the end of the while statement. When I comment out GUISetBkColor(0x414141, -1) I at least get he GUI and no more spamming but it is completely unresponsive.

 

#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <Array.au3>

#Region
$Form1 = GUICreate("Command Line Tracker", 615, 422, -1, -1)
;~ GUISetBkColor(0x414141, -1)
GUISetIcon("Portal.ico", -1)
$Group1 = GUICtrlCreateGroup("Server Status", 8, 40, 601, 185)
GUICtrlSetFont(-1, 12, 800, 0, "MS Sans Serif")
GUICtrlSetColor(-1, 0xFFFFFF)
$Edit1 = GUICtrlCreateEdit("", 16, 64, 585, 153, BitOR($ES_UPPERCASE,$ES_AUTOVSCROLL,$ES_READONLY,$ES_WANTRETURN))
GUICtrlSetData(-1, "")
GUICtrlSetFont(-1, 14, 400, 0, "Consolas")
GUICtrlSetBkColor(-1, 0x000000)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Group2 = GUICtrlCreateGroup("Client Status", 8, 232, 601, 185)
GUICtrlSetFont(-1, 12, 800, 0, "MS Sans Serif")
GUICtrlSetColor(-1, 0xFFFFFF)
$Edit2 = GUICtrlCreateEdit("", 16, 256, 585, 153, BitOR($ES_UPPERCASE,$ES_AUTOVSCROLL,$ES_READONLY,$ES_WANTRETURN))
GUICtrlSetData(-1, "")
GUICtrlSetFont(-1, 14, 400, 0, "Consolas")
GUICtrlSetBkColor(-1, 0x000000)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Button1 = GUICtrlCreateButton("Launch Server", 8, 8, 97, 33)
GUISetState(@SW_SHOW)
#EndRegion

HotKeySet("{END}", "Terminate")

;~ $a = WinList()
;~ _ArrayDisplay($a,"Window List")

$serverdir = ("directory\file.bat")

While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
        Case $Button1
            runserver()
    EndSwitch
WEnd

Func Refresh() ;Needs work, have not tested
    Sleep(100)
    If $serverrunning = 1 Then
        $MessageServer &= StdoutRead($serverid)
        GUICtrlSetData($Edit1,$MessageServer)
    EndIf
EndFunc

Func runserver()
    If $serverrunning = 0 Then
        $serverid = ShellExecute($serverdir) ;This is a batch file
        WinWaitActive("")
        WinSetState($serverid,"",@SW_MINIMIZE)
        GUICtrlSetData($Button1,"Server Running")
        $serverrunning = 1
    Else
        WinClose($serverid)
        GUICtrlSetData($Button1,"Launch Server")
        GUISetIcon("Portal.ico", ,$Form1)
        $serverrunning = 0
    EndIf
EndFunc

Func Terminate()
    Exit
EndFunc

 

Edited by kjpolker
Link to post
Share on other sites
  • Solution
9 minutes ago, kjpolker said:

When I comment out GUISetBkColor(0x414141, -1)

I had an issue with -1 in the past.
 

Do not use -1 as HWND try to use 0 or as @Danp2 said just omnit this parameter to use default value:

GUISetBkColor

Sets the background color of the GUI window.

GUISetBkColor ( background [, winhandle] )

Parameters

background Background color of the dialog box.
winhandle [optional] Windows handle as returned by GUICreate() (default is the previously used window).
Edited by mLipok

Signature beginning:
Please remember: "AutoIt"..... *  Wondering who uses AutoIt and what it can be used for ? * Forum Rules *
ADO.au3 UDF * POP3.au3 UDF * XML.au3 UDF * IE on Windows 11 for other useful stuff click the following button:

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library * Include Dependency Tree (Tool for analyzing script relations) *

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection * * 2GUI on Dual Monitor System * _SciLexer.au3 UDF * SciTE - Lexer for console pane

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

OpenOffice/LibreOffice/XLS Related: WriterDemo.au3 * XLS/MDB from scratch with ADOX

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskSchedulerIE Embedded Control Versioning (use IE9+ and HTML5 in a GUI) * PDF Related:How to get reference to PDF object embeded in IE * IE on Windows 11

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

I also encourage you to check awesome @trancexx code:  * Create COM objects from modules without any demand on user to register anything. * Another COM object registering stuffOnHungApp handlerAvoid "AutoIt Error" message box in unknown errors  * HTML editor

winhttp.au3 related : * https://www.autoitscript.com/forum/topic/206771-winhttpau3-download-problem-youre-speaking-plain-http-to-an-ssl-enabled-server-port/

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2022-03-07

Link to post
Share on other sites

Yes and yes. Unbelievable detail... I am chocking up the window being non responsive when I commented out the line due to me adding in way too many safety measures so it would not happen again haha. As of now, removing the -1 on GUISetBkColor and removing all the extra bail out of loop after x seconds, hotkey terminate, sleep functions 😅 makes the GUI accurate and responsive.

Edited by kjpolker
Link to post
Share on other sites
7 minutes ago, ad777 said:

kjpolker :use AdlibRegister("Refresh")

I have not used AdlibRegister before but that seems to be a handy tool for this. Do I just include it in the While loop? Also do you happen to know if setting the Data for Edit box is the best method for outputting lines?

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...