mdwerne

Compare COM Object to Array from text file?

3 posts in this topic

#1 ·  Posted (edited)

I'm having trouble nesting a couple "For Loops".

Currently I'm using the following function to remove "Extra" admins from the local administrators group:

Func _DeleteExtraAdmins($sHost = @ComputerName)
    Local $filter[1] = ["group"]
    Local $colGroups = ObjGet("WinNT://" & $sHost & "")
    If Not IsObj($colGroups) Then Return 0
    $colGroups.Filter = $filter
    For $objGroup In $colGroups
        If $objGroup.name = "Administrators" Then
            For $objUser In $objGroup.Members
                If $objUser.name <> "AuthAdminOne" And $objUser.name <> "AuthAdminTwo" And $objUser.name <> "AuthAdminThree" Then
                    Run('Net localgroup Administrators ' & $objUser.name & ' /Delete', @SystemDir, @SW_HIDE)
                EndIf
            Next
        EndIf
    Next
EndFunc   ;==>_DeleteExtraAdmins

What I would like to do is read the AuthAdmins from a text file instead of hard coding them...something like (and this is where I need help) below:

Func _DeleteExtraAdmins($sHost = @ComputerName)
    Local $aInput, $Admins = @ScriptDir & "\AMData.dat"
    Local $filter[1] = ["group"]
    Local $colGroups = ObjGet("WinNT://" & $sHost & "")
    If Not IsObj($colGroups) Then Return 0
    $colGroups.Filter = $filter
    For $objGroup In $colGroups
        If $objGroup.name = "Administrators" Then
            For $objUser In $objGroup.Members
            _FileReadToArray($Admins, $aInput)
            For $i = 1 To UBound($aInput) - 1
                If $objUser.name <> "AnyOfTheArrayNamesFromTheFile" Then
                    Run('Net localgroup Administrators ' & $objUser.name & ' /Delete', @SystemDir, @SW_HIDE)
                EndIf
            Next
        EndIf
    Next
EndFunc   ;==>_DeleteExtraAdmins

I understand that the second function is seriously broken, that is where I need a some help with my loops.

Any suggestions, even if it means a totally different approach, would be greatly appreciated.

All the best,

-Mike

Edited by mdwerne

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

Something like this:
 

;~ https://www.autoitscript.com/forum/topic/178312-compare-com-object-to-array-from-text-file/#comment-1279510

Func _DeleteExtraAdmins($sHost = @ComputerName)
    Local $aInput, $sAdmins_FileFullPath = @ScriptDir & "\AMData.dat"
    Local $filter[1] = ["group"]
    Local $oGroups_coll = ObjGet("WinNT://" & $sHost & "")
    If Not IsObj($oGroups_coll) Then Return 0

    $oGroups_coll.Filter = $filter
    If @error then Return SetError(@error, @extended, 0)

    _FileReadToArray($sAdmins_FileFullPath, $aInput)
    Local $sAdminList = '|'
    For $iInput_idx = 1 To UBound($aInput) - 1
        $sAdminList &= $aInput[$iInput_idx] & '|'
    Next
    Local $oMembers_coll = Null
    For $oGroup_enum In $oGroups_coll
        If $oGroup_enum.name = "Administrators" Then
            $oMembers_coll = $oGroup_enum.Members
            If @error then Return SetError(@error, @extended, 0)

            For $oUser_enum In $oMembers_coll
                If StringInStr($sAdminList, '|' & $oUser_enum.name & '|' Then
                    Run('Net localgroup Administrators ' & $oUser_enum.name & ' /Delete', @SystemDir, @SW_HIDE)
                EndIf
            Next
        EndIf
    Next
EndFunc   ;==>_DeleteExtraAdmins

???

mLipok

Edited by mLipok

Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST API *

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 - BETA * ADO.au3 UDF SMTP Mailer UDF *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Best coding practices * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * 

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2017-06-04

Share this post


Link to post
Share on other sites

Thank you very much mLipok, I'll give this a shot and see how it all plays out! :D

-Mike

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now