Problem in function _ArrayUnique, crash

[Massi]

Hi, I have update to the most recent Autoit version. I have a little problem with _ArrayUnique function.

If I have one array with two rows. _ArrayUnique crashes. I haven't any problem if there are more than two rows. I know that seems useless use this function with two rows, but these rows are the result of a search (generally I have more than two rows).

"C:\Program Files (x86)\AutoIt3\Include\Array.au3" (2290) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
Local $vFirstElem = ( ($iDims = 1) ? ($aArray[$iBase]) : ($aArray[$iColumn][$iBase]) )
Local $vFirstElem = ( ($iDims = 1) ? ($aArray[$iBase]) : (^ ERROR

 

#include <Array.au3>
Dim $Test1[3][6]=[["11","12","13","14","15","16"],["21","22","23","24","25","26"],["21","22","23","24","25","26"]]
Dim $Test[2][6]=[["11","12","13","14","15","16"],["21","22","23","24","25","26"]]
Dim $result=0
_ArrayDisplay($Test1)
_ArrayDisplay(_ArrayUnique($Test1, 2))

_ArrayDisplay($Test)
_ArrayDisplay(_ArrayUnique($Test, 2))

I put a workaround that I don't use _ArrayUnique function if there are only two results

[Melba23]

Massi,

I thought we had fixed that in 3.3.14.2 - the line should read:

Local $vFirstElem = ( ($iDims = 1) ? ($aArray[$iBase]) : ($aArray[$iBase][$iColumn]) )

and yet it still reads the other way round when I look in the file. So it will crash when the column value is higher that the number of rows in the array - although it still checks the correct column if that is not the case.  I am beginning to seriously dislike this function...........

Looking in SVN it has been further modified to use an If structure rather than a ternary (which is a pity) and it is still the wrong way around. I will fix it now so it is ready for the next release.

M23

Edit: And done - apologies again.

Edited February 16, 2016 by Melba23

[Massi]

 LOL don't hate this function, it's useful

Don't worry make a mistake is the first step before make all working in the right way 

Thank you for support, it seems to work well now

[uncommon]

Thanks, this fixed my problem too.

[nobbitry]

Thank you Melba, 

3.3.15.0 crashed. I only copied the 'Autocheck of first element'-part from 3.3.14.2 and its working.

I'm happy

[mLipok]

On 15.02.2016 at 11:45 PM, Massi said:

Don't worry make a mistake is the first step before make all working in the right way 

Good sentence

---

@nobbitry

You are using 3.3.15.0 which was released in 2015 , @Melba23 fixed this issue in February which mean this is still on SVN and waiting for 3.3.15.1 ...

 

[supersonic]

Sorry for reviving this rather old topic:

The former _ArrayUnique (3.3.12.0) seems to be a bit more fault-tolerant: If row count < base it just sets error and returns. The new version (tested with 3.3.14.2) fails.

Therefore I adjusted "Check parameters" section:

If $iBase < 0 Or $iBase > 1 Or (Not IsInt($iBase)) Or UBound($aArray, $UBOUND_ROWS) = $iBase Then Return SetError(3, 0, 0)

Hope to see this in an upcoming release...