BrianTheLibrarian

Script crashes after 10-14 loops

4 posts in this topic

Hello I am having a bit of trouble with the following script. It runs fine for 10-14ish loops and then it crashes with the following error message.

Quote

$tags=$oIE.document.GetElementsByTagName($tagName)
$tags=$oIE.document^ERROR
Error: The requested action with this object has failed.

Here is the chunk of code that seems to be giving me problems, any suggestions would be greatly appreciated.

While $count < $iRows
    $y = 0
   _IENavigate($oIE, $url[$count])
   _IELoadWait($oIE, 500);


   $colLinks = _IELinkGetCollection($oIE)
   For $oLink In $colLinks
      If $oLink.className = "Title" Then
         $oFound = $oLink
         _IEAction ($oFound, "click")
         ExitLoop
      EndIf
   Next
   _IELoadWait($oIE);


   GetData("h1", "Title")
   GetData("a", "Name")
   GetData("span", "Score1")
   GetData("span", "Value1")

   $tags = $oIE.document.GetElementsByTagName("div")
   For $tag in $tags
      $class_value = $tag.className

      If $class_value = "left" Then
         $bookInfo[0][$y] = $tag.innerText
         $y = $y+1
      EndIf

      If $class_value = "right" Then
         $bookInfo[0][$y] = $tag.innerText
         $y = $y+1
      EndIf
   Next

   $cell = "V"&$startRow

   _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $bookInfo, $cell)
   _Excel_BookSave($oWorkbook)
   $count = $count+1

 WEnd

Func GetData($tagName, $classVal)
   $tags = $oIE.document.GetElementsByTagName($tagName)
   For $tag in $tags
       $class_value = $tag.className
       If $class_value = $classVal Then
         $bookInfo[0][$y] = $tag.innerText
         $y = $y+1
         ExitLoop
        EndIf

   Next
EndFunc

 

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

Few questions:

AutoIt version you are using ?
Windows version NAME + 32 or 64 Bit ?
IE version ?

btw.
Welcome to the AutoIt Forum

Edited by mLipok

ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button:

Spoiler

Last update: 2016-12-23
Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft Components * TeamViewer API -UDF * JavaManagement UDF * VIES over SOAPPOP3.au3 UDF *  RTF Printer - UDF * XML.au3 - BETA * ADO.au3 UDF SMTP Mailer UDF * WinSCP UDF *

My contribution to others projects: * _sql.au3 UDF  *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Best coding practices * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities *

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, The Art of Computer Programming
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

 

Share this post


Link to post
Share on other sites

#3 ·  Posted (edited)

Turn on the _IE errorhandler.  There are some situations where the dom isn't loaded, or in a state that can't be queried.

It's a bug with the functions...edit: oh, you are referencing the dom directly...definitely turn on the error handler.

Edited by jdelaney

IEbyXPATH-Grab IE DOM objects by XPATH IEscriptRecord-Makings of an IE script recorder ExcelFromXML-Create Excel docs without excel installed GetAllWindowControls-Output all control data on a given window.

Share this post


Link to post
Share on other sites

#4 ·  Posted (edited)

You can read about using COM Error Handler with IE.au3    here:   How to use IE.au3  UDF with  AutoIt v3.3.14.x  

EDIT:

You can try this workaround:

Local $oDocument = $oIE.document
If Not @error Then
    $tags = $oDocument.GetElementsByTagName("div")
    ....
EndIf

 

Edited by mLipok

ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button:

Spoiler

Last update: 2016-12-23
Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft Components * TeamViewer API -UDF * JavaManagement UDF * VIES over SOAPPOP3.au3 UDF *  RTF Printer - UDF * XML.au3 - BETA * ADO.au3 UDF SMTP Mailer UDF * WinSCP UDF *

My contribution to others projects: * _sql.au3 UDF  *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Best coding practices * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities *

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, The Art of Computer Programming
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now