Jump to content
Briandr

Embedded If-EndIf statement

Recommended Posts

Briandr

Hi,

The inner If-EndIf code shown below is failing to write to the log. Can someone please help? I been searching for the right way to check for the registry key. I don't necessarily care about the value of the registry key. Just need a way to check if it exists. Come on over 29 views and no one?

If @OSArch = "X64" and @OSVersion = "WIN_7" Then
        $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "MySSVersion")
        If @Error -1 Then ;Key does exist
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
        ElseIf @Error > 1 Then ;Key does not exist
        _FileWriteLog($Log, "MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
        EndIf
EndIf

Thanks.

Edited by Briandr

Share this post


Link to post
Share on other sites
mLipok

Like this:

If @OSArch = "X64" And @OSVersion = "WIN_7" Then
    $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "")
    If @error Then ;Key not found
        _FileWriteLog($Log, "MySSKey missing; MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
    Else
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
    EndIf
EndIf

 

?

  • Like 1

Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST API *

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * 

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-03-17

Share this post


Link to post
Share on other sites
Briandr

Thanks for offering assistance. Code still does not appear quite right. Results of the logging below:

2016-05-24 20:52:59 : My-SS-update2_test 4 module called
2016-05-24 20:52:59 : MySSKey missing; MentorSS out of date.
2016-05-24 20:52:59 : MySS is now up to date.

The only line that should have been written to the log should have been

MySS up to date, no action needed. 

That should have been written as the registry key is present. The other two lines should not have been written to the log file.


 

Share this post


Link to post
Share on other sites
mLipok

hmmm....

If @OSArch = "X64" And @OSVersion = "WIN_7" Then
    $CheckForSSKey = RegRead("HKLM\Software\DellKACE\MySSVersion", "")
    If @error Then ;Key not found
        _FileWriteLog($Log, "MySSKey missing; MySS out of date.")
        RunWait(@ComSpec & " /c " & 'net stop pcasvc', "", @SW_HIDE)
        FileChangeDir("%systemroot%\syswow64")
        FileDelete("%systemroot%\syswow64\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\syswow64\My.scr", 1)
        FileChangeDir("%systemroot%\sysnative")
        FileDelete("%systemroot%\sysnative\My.scr")
        FileCopy(@ScriptDir & "\My.scr", "%systemroot%\sysnative\My.scr", 1)
        RegWrite("HKLM" & "\Software\DellKACE", "MySSVersion", "REG_SZ", "2")
        RunWait(@ComSpec & " /c " & 'net start pcasvc', "", @SW_HIDE)
        _FileWriteLog($Log, "MySS is now up to date.")
        ; if you want it once then use EXIT like in the second case you are using it
        Exit
    Else
        _FileWriteLog($Log, "MySS up to date, no action needed.")
        Exit
    EndIf
EndIf

 


Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST API *

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * 

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-03-17

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.