Jump to content
Sign in to follow this  
autoitxp

Object Collection Redim Slow

Recommended Posts

Although this function works correctly but bit slower may b bec of Redim any other way to do which is faster. 

Fetching more than 500 Schedule task in specified folder .

 

#include <Array.au3>
Global $g_eventerror = 0 
Global $oMyError = ObjEvent("AutoIt.Error", "_MyErrFunc")
Global $err
Global $GetFP
Global $GFolder
Global $GFS
Global $GF
Global $GFL[0]
Global $strerrors = 0
Global $ObjSS

_ArrayDisplay(_STF())

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
        $strerrors += 1
        ReDim $GFL[$strerrors + 1]
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF



Func _MyErrFunc($oMyError)
    ConsoleWrite(@LF & "---------------------------------------------------------------------" & @LF & _
            " Source: " & $oMyError.source & @LF & _
            " Description: " & $oMyError.description & @LF & _
            " Windescription: " & $oMyError.windescription & @LF & _
            " Number: " & $oMyError.number & @LF & _
            " Retcode: " & $oMyError.retcode & @LF & _
            " Scriptline: " & $oMyError.scriptline & @LF & _
            " Helpfile: " & $oMyError.helpfile & @LF & _
            " Helpcontext: " & $oMyError.helpcontext & @LF & _
            " Lastdllerror: " & $oMyError.lastdllerror & @LF & _
            "---------------------------------------------------------------------" & @LF)

    $err = $oMyError.number
    If $err = 0 Then $err = -1
    $g_eventerror = $err ; to check for after this function returns
EndFunc   ;==>_MyErrFunc


 

 

Edited by autoitxp

Share this post


Link to post
Share on other sites

@autoitxp

Have you already tried _ArrayAdd() ? :)


Click here to see my signature:

Spoiler

Thoughts:

  • I will always thank you for the time you spent for me.
    I'm here to ask, and from your response, I'd like to learn.
    By my knowledge, I can help someone else, and "that someone" could help in turn another, and so on.

/*--------------------------------------------------------------------------------------------------------------------------------------------------------------------------*/

ALWAYS GOOD TO READ:

 

Share this post


Link to post
Share on other sites

_ArrayAdd uses ReDim, so not sure you'll gain anything by using it.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Here's a way to do it using only one Redim, as long as there aren't going to be more than 10000 items added to the array, it should work the same.

#include <Array.au3>
Global $g_eventerror = 0
Global $oMyError = ObjEvent("AutoIt.Error", "_MyErrFunc")
Global $err
Global $GetFP
Global $GFolder
Global $GFS
Global $GF
Global $GFL[10000]
Global $strerrors = 0
Global $ObjSS

_ArrayDisplay(_STF())

Func _STF()
;~     Redim $GFL[10000] ; only use this line if you don't set the size above
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
;~      $strerrors += 1 ; if this is uncommented, then there will be nothing in the zero element of the array, make sure if you do uncomment it, to comment the identical line below or it will not work right.
;~      ReDim $GFL[$strerrors + 1]
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
        $strerrors += 1 ; this ensures that the zero element of the array holds the first object
    Next
    ReDim $gfl[$strerrors] ; add 1 to this redim if you use the $strerrors +=1 before adding items to the array
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF



Func _MyErrFunc($oMyError)
    ConsoleWrite(@LF & "---------------------------------------------------------------------" & @LF & _
            " Source: " & $oMyError.source & @LF & _
            " Description: " & $oMyError.description & @LF & _
            " Windescription: " & $oMyError.windescription & @LF & _
            " Number: " & $oMyError.number & @LF & _
            " Retcode: " & $oMyError.retcode & @LF & _
            " Scriptline: " & $oMyError.scriptline & @LF & _
            " Helpfile: " & $oMyError.helpfile & @LF & _
            " Helpcontext: " & $oMyError.helpcontext & @LF & _
            " Lastdllerror: " & $oMyError.lastdllerror & @LF & _
            "---------------------------------------------------------------------" & @LF)

    $err = $oMyError.number
    If $err = 0 Then $err = -1
    $g_eventerror = $err ; to check for after this function returns
EndFunc   ;==>_MyErrFunc

 


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

quick look here

https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfolder-getfolders
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection-count
https://docs.microsoft.com/en-us/windows/desktop/taskschd/taskfoldercollection-item

and you can try to use this not tested concept:

 

Local $GFS = $GFolder.GetFolders(0)
ReDim $GFL[$GFS.count]
For $iItem_idx =0 To $GFS.count
; For $iItem_idx =0 To $GFS.count -1 ; I'm not sure
    $GFL[$iItem_idx] $GFS.Item($iItem_idx)
Next

 

Edited by mLipok

Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest beginning - communication with GitHub REST API Forum Rules *
Include Dependency Tree (Tool for analyzing script relations)
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library *

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection * * 2GUI on Dual Monitor System * _SciLexer.au3 UDF * SciTE - Lexer for console pane

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler

PDF Related:https://www.autoitscript.com/forum/topic/177368-how-to-get-reference-to-pdf-object-embeded-in-ie/ *

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2020-09-20

Share this post


Link to post
Share on other sites

im getting error array variable has incorrect number of subscripts .....

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    ReDim $GFL[$GFS.Count]
    For $GF In $GFS
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
        $strerrors += 1
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF

on other hand im not getting  $GFS.Name getting unknown name error  ?

Func _STF()

$ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    ReDim $GFL[$GFS.Count]
    For $i = 0 To $GFS.Count - 1
        $GFL[$i] = $GetFP & "\" & $GFS.Name
    Next
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL

EndFunc  ;==>_STF

 

Edited by autoitxp

Share this post


Link to post
Share on other sites

@BrewManNH i'm getting error after compiling trace back line For $GF In $GFS But when run as normal in Scite works fine after compiling getting below error 

Error:Array variable has incorrect number of subscripts or subscript dimension range exceeded.


 

Global $GFL[10000]

Func _STF()
    $ObjSS = ObjCreate("Schedule.Service")
    $ObjSS.Connect()
    $GetFP = "\Microsoft\Windows"
    If $GetFP = "\" Then $GetFP = ""
    $GFolder = $ObjSS.GetFolder($GetFP)
    $GFS = $GFolder.GetFolders(0)
    For $GF In $GFS
        $strerrors += 1
        $GFL[$strerrors] = $GetFP & "\" & $GF.Name
    Next
    ReDim $GFL[$strerrors + 1]
    If $g_eventerror Then
        $g_eventerror = 0
        Return SetError(@error)
    EndIf
    Return $GFL
EndFunc   ;==>_STF

 

 

Edited by autoitxp

Share this post


Link to post
Share on other sites

Try to see what $seterrors value is when it errors out. If you run this function numerous times, you should reset $seterrors to zero when exiting the function, or make it a local variable inside the function.

Also, if you're not using the array $GFL anywhere other than in this function, make that a local variable also.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...