Bit of guidance please!

[AZPERRY]

Hello there AutoIT users.

I have used Auto it but its been a few years and most my time is working on PLC logic controllers.

Can i ask what is wrong with my code here please?

HotKeySet("{ESC}", "Exit")

include <ImageSearch.au3>

Func MyExit()

    MsgBox(0, "Ending")
    Exit

EndFunc   ;==>MyExit

While 1
    _click()
WEnd

Func _click()

    ConsoleWrite("Starting search" & @CRLF)
    $pump = _ImageSearch('pump.png', 1, $x, $y, 100)

    if $pump True then
        ConsoleWrite("found pump!" & @CRLF)
        MouseClick("left", $pump)
        Sleep(100)
        EndIf
EndFunc

 

[water]

Please post what you expect it to do, what it does when you run your script, if you get any error messages ...

[AZPERRY]

Just a simple click on a image.

It compiles.

But doesnt execute.. Says invalid function

[TheSaint]

I am not familiar with either the _ImageSearch function or Include (UDF) file.

However, I recommend a Sleep of at least 100 in you While ... Wend loop, after _click()

So I don't know if you should be providing $x and $y coordinates, or they just get values returned to those variables. Or indeed whether 'pump.png' is meant to be a full path, or what the 100 parameter is for, or for that matter the 1. I am presuming $pump is a returned coordinate.

Like water says, what is expected from your code?

When providing code, you should Quote it and select AutoIt code, like so. Makes it easier for us to work with.

HotKeySet("{ESC}", "Exit")

include <ImageSearch.au3>


Func MyExit()

    MsgBox(0, "Ending")
    Exit

EndFunc   ;==>MyExit

While 1
    _click()
WEnd


Func _click()

    ConsoleWrite("Starting search" & @CRLF)
    $pump = _ImageSearch('pump.png', 1, $x, $y, 100)

    if $pump True then
        ConsoleWrite("found pump!" & @CRLF)
        MouseClick("left", $pump)
        Sleep(100)
        EndIf
EndFunc

 

Edited November 4, 2019 by TheSaint

[TheXman]

Is this your whole script?  Where are the values for $x & $y coming from?

Edit:  Sorry, I must have hit enter at the same time as TheSaint, with the same question.

Edited November 4, 2019 by TheXman

[Nine]

Run it in Scite, you will see plenty of errors in your code...

Put Opt ("MustDeclareVars", 1) at the top of your script after #include

Edited November 4, 2019 by Nine

[Zedna]

Change 

HotKeySet("{ESC}", "Exit")

to

HotKeySet("{ESC}", "MyExit")

[AZPERRY]

(3) : ==> Unknown function name.:
include <ImageSearch.au3>
^ ERROR
>Exit code: 1    Time: 0.1013

 

[water]

Needs to be

#include <ImageSearch.au3>

 

[AZPERRY]

#include <ImageSearch.au3>

that gives me same error but with the #

?

[water]

Where did you store the file ImageSearch.au3?
Same directory as your script? User defind include directory?

[AZPERRY]

In the same location as script.

[Zedna]

Then use 

#include "ImageSearch.au3"

[AZPERRY]

#include "Image_Search.au3"

$x1=0
$y1=0

$pump = _ImageSearch("pump.png",1,$x1,$y1,0)?
if $result=1 Then
    MouseMove($x1,$y1,3)
    Mouseclick("left",$x1,$y1,3)
Else
    MsgBox(0,"Not Found","Image not found...")
EndIf

ok im doing something wrong here as i cant even get this to work.........

$pump = _ImageSearch("pump.png",1,$x1,$y1,0)?
$pump = ^ ERROR
>Exit code: 1    Time: 0.104

 

[Musashi]

  On 11/4/2019 at 4:02 PM, AZPERRY said:

$pump = _ImageSearch("pump.png",1,$x1,$y1,0)?

Expand  

Remove the ? at the end of the line. Don't know why, but sometimes this happens when you C&P Code from the forum.

[AZPERRY]

still same error 😐

[water]

You are sure your function starts with an underscore?
I searched the forum and found this. If this is the UDF you use then the function name does not start with an "_". If you use another image search library, then please open the UDF and check the name of the function!

; PUBLIC FUNCTIONS
func image_search($sign, $width, $height)
    Local $pos[2]
    Local $hp[2]
    $pos[0] = -1
    $pos[1] = -1
    $hp[0] = -1
    $hp[1] = -1
    $color = $sign[0]
    do
        $hp = next_screen_hotpoint($hp[1],$color)
        if $hp[1] <> -1 then
            $aux = $hp[1]
            do
                if verify_sign($sign,$width,$height,$hp[0],$hp[1]) then
                    $pos = getMiddlePoint($hp[0],$hp[1],$hp[0]+$width-1,$hp[1]+$height-1)
                    return $pos
                endif
                $hp = next_row_hotpoint($hp[0],$hp[1],$color)
            until $hp[1] == -1
            $hp[1] = $aux
        endif
    until $hp[1] == -1
    return $pos
endfunc

 

[FrancescoDiMuro]

  On 11/4/2019 at 4:18 PM, Musashi said:

Don't know why, but sometimes this happens when you C&P Code from the forum.

Expand  

If you're interested

[Musashi]

  On 11/4/2019 at 6:45 PM, water said:

You are sure your function starts with an underscore?
I searched the forum and found this. If this is the UDF you use then the function name does not start with an "_". If you use another image search library, then please open the UDF and check the name of the function!

Expand  

Hi @water

I'm pretty sure @AZPERRY uses  this UDF (not the one you have been linking to).

_ImageSearch is the correct function name, see :

  Reveal hidden contents

expandcollapse popup

#include-once
; ------------------------------------------------------------------------------
;
; AutoIt Version: 3.0
; Language:       English
; Description:    Functions that assist with Image Search
;                 Require that the ImageSearchDLL.dll be loadable
;
; ------------------------------------------------------------------------------

;===============================================================================
;
; Description:      Find the position of an image on the desktop
; Syntax:           _ImageSearchArea, _ImageSearch
; Parameter(s):
;                   $findImage - the image to locate on the desktop
;                   $tolerance - 0 for no tolerance (0-255). Needed when colors of
;                                image differ from desktop. e.g GIF
;                   $resultPosition - Set where the returned x,y location of the image is.
;                                     1 for centre of image, 0 for top left of image
;                   $x $y - Return the x and y location of the image
;
; Return Value(s):  On Success - Returns 1
;                   On Failure - Returns 0
;
; Note: Use _ImageSearch to search the entire desktop, _ImageSearchArea to specify
;       a desktop region to search
;
;===============================================================================
Func _ImageSearch($findImage,$resultPosition,ByRef $x, ByRef $y,$tolerance, $HBMP=0)
   return _ImageSearchArea($findImage,$resultPosition,0,0,@DesktopWidth,@DesktopHeight,$x,$y,$tolerance,$HBMP)
EndFunc

Func _ImageSearchArea($findImage,$resultPosition,$x1,$y1,$right,$bottom,ByRef $x, ByRef $y, $tolerance,$HBMP=0)
    ;MsgBox(0,"asd","" & $x1 & " " & $y1 & " " & $right & " " & $bottom)
    if $tolerance>0 then $findImage = "*" & $tolerance & " " & $findImage
If IsString($findImage) Then
    $result = DllCall("ImageSearchDLL.dll","str","ImageSearch","int",$x1,"int",$y1,"int",$right,"int",$bottom,"str",$findImage,"ptr",$HBMP)
Else
    $result = DllCall("ImageSearchDLL.dll","str","ImageSearch","int",$x1,"int",$y1,"int",$right,"int",$bottom,"ptr",$findImage,"ptr",$HBMP)
EndIf

    ; If error exit
    if $result[0]="0" then return 0

    ; Otherwise get the x,y location of the match and the size of the image to
    ; compute the centre of search
    $array = StringSplit($result[0],"|")

   $x=Int(Number($array[2]))
   $y=Int(Number($array[3]))
   if $resultPosition=1 then
      $x=$x + Int(Number($array[4])/2)
      $y=$y + Int(Number($array[5])/2)
   endif
   return 1
EndFunc

;===============================================================================
;
; Description:      Wait for a specified number of seconds for an image to appear
;
; Syntax:           _WaitForImageSearch, _WaitForImagesSearch
; Parameter(s):
;                   $waitSecs  - seconds to try and find the image
;                   $findImage - the image to locate on the desktop
;                   $tolerance - 0 for no tolerance (0-255). Needed when colors of
;                                image differ from desktop. e.g GIF
;                   $resultPosition - Set where the returned x,y location of the image is.
;                                     1 for centre of image, 0 for top left of image
;                   $x $y - Return the x and y location of the image
;
; Return Value(s):  On Success - Returns 1
;                   On Failure - Returns 0
;
;
;===============================================================================
Func _WaitForImageSearch($findImage,$waitSecs,$resultPosition,ByRef $x, ByRef $y,$tolerance,$HBMP=0)
    $waitSecs = $waitSecs * 1000
    $startTime=TimerInit()
    While TimerDiff($startTime) < $waitSecs
        sleep(100)
        $result=_ImageSearch($findImage,$resultPosition,$x, $y,$tolerance,$HBMP)
        if $result > 0 Then
            return 1
        EndIf
    WEnd
    return 0
EndFunc

;===============================================================================
;
; Description:      Wait for a specified number of seconds for any of a set of
;                   images to appear
;
; Syntax:           _WaitForImagesSearch
; Parameter(s):
;                   $waitSecs  - seconds to try and find the image
;                   $findImage - the ARRAY of images to locate on the desktop
;                              - ARRAY[0] is set to the number of images to loop through
;                                ARRAY[1] is the first image
;                   $tolerance - 0 for no tolerance (0-255). Needed when colors of
;                                image differ from desktop. e.g GIF
;                   $resultPosition - Set where the returned x,y location of the image is.
;                                     1 for centre of image, 0 for top left of image
;                   $x $y - Return the x and y location of the image
;
; Return Value(s):  On Success - Returns the index of the successful find
;                   On Failure - Returns 0
;
;
;===============================================================================
Func _WaitForImagesSearch($findImage,$waitSecs,$resultPosition,ByRef $x, ByRef $y,$tolerance,$HBMP=0)
    $waitSecs = $waitSecs * 1000
    $startTime=TimerInit()
    While TimerDiff($startTime) < $waitSecs
        for $i = 1 to $findImage[0]
            sleep(100)
            $result=_ImageSearch($findImage[$i],$resultPosition,$x, $y,$tolerance,$HBMP)
            if $result > 0 Then
                return $i
            EndIf
        Next
    WEnd
    return 0
EndFunc

 

The UDF requires ImageSearchDLL.dll , which is included in the Zipfiles. In the thread, some users report bugs or have made modifications. Also see : https://www.autoitscript.com/forum/topic/189338-imagesearchau3-help/

To be honest, I never had the desire (nor a reason) to work with ImageSearch . Maybe I would give it a try just for fun, but I'm not sure if I can trust the .dll.

Edited November 4, 2019 by Musashi

[AZPERRY]

Right guy's i have  progressed.

My issue now is that it doesn't actually click on the image.

The image is just on the desktop.

HotKeySet("{ESC}", "MyExit")

#include "ImageSearch.au3"

Func MyExit()

    MsgBox(0, "Ending")
    Exit

EndFunc   ;==>MyExit

$x1=0
$y1=0

While 1
    _click()
 WEnd


Func _click()
$pump = "‪C:\Users\Perrya\Desktop\Autoit\pump.png"

$pump1 = _ImageSearch($pump,1,$x1,$y1,0,0)
    ConsoleWrite("Starting search" & @CRLF)

   if $pump1 = 1 then
      ConsoleWrite("found pump" & @CRLF)
      MouseClick($pump1)
      Sleep(100)
      EndIf
EndFunc