XML search get change settings.

[FMS]

Hello @mLipok and @genius257 many thanks for all the good hints tips and tricks.
Finaly also for futhure reference I've now the final (i hope) function.
maybe somebody has some pointers about this function so we can improve this
I'm open for sugestions.

expandcollapse popup

Func XML_change_working();hidden button 1
   Local $LC_XML_file = @ScriptDir & "\forum.xml"
   Local $LC_XML_obj = ObjCreate("Microsoft.XMLDOM")
   $LC_XML_obj.load($LC_XML_file)
   Local $LC_hits = $LC_XML_obj.selectNodes("//Configuration//Categories//Category[@Name='settings']//SubCategories//SubCategory[@Name='comp1']")
   If $LC_hits.length = 0 Then
      ConsoleWrite("hit = 0" & @CRLF)
   ElseIf $LC_hits.length = 1 Then
      ConsoleWrite("hit = 1" & @CRLF)
      For $i = 0 To $LC_hits.length - 1
         Local $LC_XML_step1 = $LC_hits.Item($i)
         If @error Then
            ConsoleWrite("error step 1" & @CRLF)
         Else
            Local $LC_XML_step2 = $LC_XML_step1.SelectSingleNode(".//Setting[@Name='cmptemp_set']")
            If @error Then
               ConsoleWrite("error step 2" & @CRLF)
            Else
               Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")
               If @error Then
                  ConsoleWrite("error step 3" & @CRLF)
               Else
                  Local $LC_XML_file_open = FileOpen($LC_XML_file, 2)
                  If $LC_XML_file_open = -1 Then
                     ConsoleWrite("error open file" & @CRLF)
                  Else
                     Local $LC_XML_file_write = FileWrite($LC_XML_file_open, $LC_XML_obj.xml)
                     If Not $LC_XML_file_write Then
                        ConsoleWrite("error write file" & @CRLF)
                     EndIf
                     Sleep(200)
                     Local $LC_XMLS_file_close = FileClose($LC_XML_file_open)
                     If $LC_XMLS_file_close = 0 Then
                        ConsoleWrite("error close file : the filehandle is invalid." & @CRLF)
                     EndIf
                  EndIf
               EndIf
            EndIf
         EndIf
      Next
   ElseIf $LC_hits.length > 1 Then
      ConsoleWrite("hit = more then 1" & @CRLF)
   EndIf
EndFunc

 

Edited September 14, 2016 by FMS

[genius257]

11 minutes ago, FMS said:

maybe somebody has some pointers about this function so we can improve this

I would suggest running you script and checking the error messages, before posting it. It seems you passed the wrong variable to the FileClose function.

Besides that small error, it seems to be working well.

I would preffer smaller variable names, like $hFile for the file handle, but that's a personal preference, not a guideline

[FMS]

I editet the error

$LC_XML_file -> $LC_XML_file_open

thanks

[FMS]

I'm not shure if I need to start a new question about this subject but,
I got again a question about this script

I wonder if its possible to catch the error if its not found?

==> The requested action with this object has failed.:
Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")
Local $LC_XML_step3 = $LC_XML_step2^ ERROR

the @error in this script din't catch that error..
Does somebody know how to do this?
I did read this link where @mLipok was a great contributor but,

but don't know how to implement this or even iff this is the right direction to take

please some advice.

Edited September 17, 2016 by FMS

[mLipok]

18 hours ago, FMS said:

but don't know how to implement this or even iff this is the right direction to take

Like this:
 

expandcollapse popup

Func XML_change_working();hidden button 1
    ; Error monitoring. This will trap all COM errors while alive.
    ; This particular object is declared as local, meaning after the function returns it will not exist.
    Local $oErrorHandler = ObjEvent("AutoIt.Error", "_ErrFunc")

   Local $LC_XML_file = @ScriptDir & "\forum.xml"
   Local $LC_XML_obj = ObjCreate("Microsoft.XMLDOM")
   $LC_XML_obj.load($LC_XML_file)
   Local $LC_hits = $LC_XML_obj.selectNodes("//Configuration//Categories//Category[@Name='settings']//SubCategories//SubCategory[@Name='comp1']")
   If $LC_hits.length = 0 Then
      ConsoleWrite("hit = 0" & @CRLF)
   ElseIf $LC_hits.length = 1 Then
      ConsoleWrite("hit = 1" & @CRLF)
      For $i = 0 To $LC_hits.length - 1
         Local $LC_XML_step1 = $LC_hits.Item($i)
         If @error Then
            ConsoleWrite("error step 1" & @CRLF)
         Else
            Local $LC_XML_step2 = $LC_XML_step1.SelectSingleNode(".//Setting[@Name='cmptemp_set']")
            If @error Then
               ConsoleWrite("error step 2" & @CRLF)
            Else
               Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")
               If @error Then
                  ConsoleWrite("error step 3" & @CRLF)
               Else
                  Local $LC_XML_file_open = FileOpen($LC_XML_file, 2)
                  If $LC_XML_file_open = -1 Then
                     ConsoleWrite("error open file" & @CRLF)
                  Else
                     Local $LC_XML_file_write = FileWrite($LC_XML_file_open, $LC_XML_obj.xml)
                     If Not $LC_XML_file_write Then
                        ConsoleWrite("error write file" & @CRLF)
                     EndIf
                     Sleep(200)
                     Local $LC_XMLS_file_close = FileClose($LC_XML_file_open)
                     If $LC_XMLS_file_close = 0 Then
                        ConsoleWrite("error close file : the filehandle is invalid." & @CRLF)
                     EndIf
                  EndIf
               EndIf
            EndIf
         EndIf
      Next
   ElseIf $LC_hits.length > 1 Then
      ConsoleWrite("hit = more then 1" & @CRLF)
   EndIf
EndFunc



; User's COM error function. Will be called if COM error occurs
Func _ErrFunc($oError)
    ; Do anything here.
    ConsoleWrite(@ScriptName & " (" & $oError.scriptline & ") : ==> COM Error intercepted !" & @CRLF & _
            @TAB & "err.number is: " & @TAB & @TAB & "0x" & Hex($oError.number) & @CRLF & _
            @TAB & "err.windescription:" & @TAB & $oError.windescription & @CRLF & _
            @TAB & "err.description is: " & @TAB & $oError.description & @CRLF & _
            @TAB & "err.source is: " & @TAB & @TAB & $oError.source & @CRLF & _
            @TAB & "err.helpfile is: " & @TAB & $oError.helpfile & @CRLF & _
            @TAB & "err.helpcontext is: " & @TAB & $oError.helpcontext & @CRLF & _
            @TAB & "err.lastdllerror is: " & @TAB & $oError.lastdllerror & @CRLF & _
            @TAB & "err.scriptline is: " & @TAB & $oError.scriptline & @CRLF & _
            @TAB & "err.retcode is: " & @TAB & "0x" & Hex($oError.retcode) & @CRLF & @CRLF)
EndFunc    ;==>_ErrFunc

 

[FMS]

thank you for your reply @mLipok,

I've tried what u sugested but still got that error.
Mine script whit your code before your reply gave me the same error so i thought i was on the wrong direction.
 

==> The requested action with this object has failed.:
Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")
Local $LC_XML_step3 = $LC_XML_step2^ ERROR

Iff i change the name in the XML file of <settings> "cmp_tempset"  to "cmp_tempset_old"
I got this error and also this function does not catch it.

[mLipok]

What you get in SciTE console ?

[FMS]

what i just posted :

"D:\map\test.au3" (3583) : ==> The requested action with this object has failed.:
Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")
Local $LC_XML_step3 = $LC_XML_step2^ ERROR

this is if I change the name of the setting in the XML file.
not in the loaded settings.

[mLipok]

Try this mod:
 

Local $LC_XML_step2 = $LC_XML_step1.SelectSingleNode(".//Setting[@Name='cmptemp_set']")
            If @error Then
               ConsoleWrite("error step 2" & @CRLF)
            ElseIf Not IsObj($LC_XML_step2) Then
               ConsoleWrite("error step 2b" & @CRLF)
            Else

 

Edited September 17, 2016 by mLipok
" Then" was missed in my snippet

[FMS]

nice ,... @mLipokthat did totaly did the trick.
Why i don't know i must say , din't know i must check on objects ?

Isn't this error checking also nessesary whit

Local $LC_XML_step3 = $LC_XML_step2.SetAttribute("Value","")

and

Local $LC_hits = $LC_XML_obj.selectNodes("//Configuration//Categories//Category[@Name='settings']//SubCategories//SubCategory[@Name='comp1']")

???

 

[mLipok]

$LC_XML_step3

is not used so you do not need to test it.

 

and:
 

Local $LC_hits = $LC_XML_obj.selectNodes("//Configuration//Categories//Category[@Name='settings']//SubCategories//SubCategory[@Name='comp1']")
   If @error Or (Not IsObj($LC_hits)) Then
       ......
   ElseIf $LC_hits.length = 0 Then

 

[hm221989]

@FMS   can i have your complete working code?