Jump to content
_leo_

Excel RangeFind is not working

Recommended Posts

Hey there!¬†ūüėÉ

I am having a problem with the _Excel_RangeFind. I am trying to search for a value in a particular cell range. The script copies the value from the internet. Copying and saving as a variable is working fine, but as soon as it should find the value in excel, nothing happens. ( I am not getting an error)

#include <Excel.au3>
   
   Func Excel()
    Send("{CTRLDOWN}")
    Send("{c}")
    Send("{CTRLUP}")
    Local $sName = ClipGet() ;Text
    Local $sShortName = StringTrimRight ( $sName, 1) ;delete one letter
    Local $bOpenWorkBook = False, $oExcel = _Excel_Open()
    Local $sFilePath = "C:\Users\Acer\OneDrive\xyz.xlsx"
    Local $oWorkbook
    $oWorkbook = _Excel_BookAttach($sFilePath)
    If @error Then
      $oWorkbook = _Excel_BookOpen($oExcel, $sFilePath)
      $bOpenWorkBook = True
    EndIf
    sleep(15000)
    Send("{LWINDown}") 
    Send ("{up}") ;maximize window
    Send("{LWINup}") 
    sleep(1000)
    _Excel_RangeFind ($oWorkbook, $sShortName, "A3:A56")
   EndFunc

Is anyone familiar with this problem or am I just missing some basic stuff? 

Thanks for help!

Share this post


Link to post
Share on other sites

_Excel_RangeFind returns either a 2D Array of the results or error (see help file for return values).  Use _ArrayDisplay (requires #include <Array.au3> to show you the results.  Also try to use ControlSend rather than Send, Send can have be unpredictable, whereas ControlSend is targeted and less likely to have any issues.

Share this post


Link to post
Share on other sites
35 minutes ago, Nine said:

To make your script more robust, you can use excel method instead of using Send to maximize the window like this :

Const $xlMaximized = -4137
$oExcel.WindowState = $xlMaximizedÔĽŅ

 

Thanks! I included your suggestion in my script ūüôā

Share this post


Link to post
Share on other sites
7 hours ago, Subz said:

_Excel_RangeFind returns either a 2D Array of the results or error (see help file for return values).  Use _ArrayDisplay (requires #include <Array.au3> to show you the results.  Also try to use ControlSend rather than Send, Send can have be unpredictable, whereas ControlSend is targeted and less likely to have any issues.

Hey Subz

Thank you very much for helping me once again! I replaced the send() with the ControlSend() and added the Array.

Is is possible to let the RangeFind show the result by switching to it/ making it the active cell? (like ctrl+f in excel) Because I would like to RangeRead it afterwards. If it is showed in an array, I don't know how the RangeRead could work. 

Thank you again for the productive support!

Share this post


Link to post
Share on other sites
Posted (edited)

What happens if you have multiple results?  Either way you would just use the array[x][2] to get the address of the cell that was found.

Edited by Subz

Share this post


Link to post
Share on other sites

I strongly suggest to not mix the Excel UDF (uses COM to interact with Excel) and GUi automation like Send, ControlSend etc.
Most (if not all) things you can do with GUI automation can be done using COM. But COM does not interfere with the user and is much easier to debug.
Just my 2 cents worth ;)
 


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2019-08-19 - Version 1.4.13.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2019-07-24 - Version 1.3.6.0) - Download - General Help & Support - Example Scripts - Wiki
Outlook Tools (NEW 2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites
1 hour ago, Subz said:

What happens if you have multiple results?  Either way you would just use the array[x][2] to get the address of the cell that was found.

How?

In my case, there can not be multiple results since the range find is searching for numbers from A3 to A56. These cells only contain a numberation from 1 to 50. 

The problem I am facing right now is, that the script should run by itself, without me having to click away the _ArrayDisplay window. Is the rangefind executed and the therefore the array safed, even if I don't use _ArrayDisplay?

What I am trying right now is transforming the RangeFind array result (see screenshot) into a variable using the  _Arraytostring. (does that work like that?) I have problems creating a string only of "col 2" and "row 0" value.

local $sSuchergebnis = _Excel_RangeFind ($oWorkbook, $sNummername, "A3:A56")
   sleep(1000)
   local $sfinal = _Arraytostring($sSuchergebnis, 0, 0, 2, 2)

and then I would use the function Nine sugguested:

$oWorkBook.ActiveSheet.Range ($sfinal).Activate

to activite the cell.

Appreciate your support!

arraydisplay.png

Share this post


Link to post
Share on other sites

@water I assumed he was copying from a third-party product, since the copy occurred prior to Excel being opened.

@_leo_ Just use $sFinal[0][2] to get the result

local $aResult = _Excel_RangeFind ($oWorkbook, $sNummername, "A3:A56")
   sleep(1000)
   $oWorkBook.ActiveSheet.Range ($aResult[0][2]).ActivateÔĽŅ

 

Share this post


Link to post
Share on other sites

But I think he tries to automate the GUI again by activating the found cell. Using _Excel_RangeCopyPaste is the way I'd suggest.


My UDFs and Tutorials:

Spoiler

UDFs:
Active Directory (NEW 2019-08-19 - Version 1.4.13.0) - Download - General Help & Support - Example Scripts - Wiki
OutlookEX (NEW 2019-07-24 - Version 1.3.6.0) - Download - General Help & Support - Example Scripts - Wiki
Outlook Tools (NEW 2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - Wiki
ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts
PowerPoint (2017-06-06 - Version 0.0.5.0) - Download - General Help & Support
Excel - Example Scripts - Wiki
Word - Wiki
 
Tutorials:

ADO - Wiki

 

Share this post


Link to post
Share on other sites

You guys are awesome! Thank you for giving this crazy support! 

@water Thank you for the spark of wisdom :) The next line in the script is with the RangeRead (not with ctrl c). 

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • By _leo_
      Hey guys
      I'm new to autoit, so this could be a simple question. I'm trying to read the value from the currently selected cell in Excel. I read on the forum and tired to find videos, but I couldn't quite get to it. 
      This is what I have got so far:
       
      Local $oExcel_1 = _Excel_Open()
      Local $var = "C:\Users\Acer\xy"
      Local $oWorkbook = _Excel_BookOpen($oExcel_1,$var)
       
      Local $_read1 = _Excel_RangeRead($oWorkbook, Default.Application.ActiveCell.Address)
       
      Whatever I try, I either get an error or it only reads "0".
       
      Thank you very much for any helpful thoughts!
    • By Rhidlor
      Quick question, when working with Excel, does each workbook require its own Excel instance, or can multiple workbooks be opened off of the same Excel instance? I tested both ways, on the surface they both seemed to work, just thought I'd ask here to make sure before proceeding any further. Thanks!
      Disclaimer: The following is pseudo code
      $excel_instance1 = _Excel_Open() $workbook1 = _Excel_BookOpen($excel_instance1, @ScriptDir & "\book1.xlsx") $workbook2 = _Excel_BookOpen($excel_instance1, @ScriptDir & "\book2.xlsx") Or
      $excel_instance1 = _Excel_Open() $workbook1 = _Excel_BookOpen($excel_instance1, @ScriptDir & "\book1.xlsx") $excel_instance2 = _Excel_Open() $workbook2 = _Excel_BookOpen($excel_instance2, @ScriptDir & "\book2.xlsx")  
    • By TheDcoder
      Hello everyone, I am working on a project which requires reading a few values from Excel, the catch is that I need it to be very fast... unfortunatley I found out that read operations using the supplied Excel UDF are very slow, more than 150 ms for each operation on average
      Here is my testing setup that I made:
      #include <Excel.au3> #include <MsgBoxConstants.au3> Global $iTotalTime = 0 Test() Func Test() Local $oExcel = _Excel_Open() Local $oBook = _Excel_BookAttach("Test.xlsx", "FileName", $oExcel) Local $sSheet = "Sheet1" If @error Then Return MsgBox($MB_ICONERROR, "Excel Failed", "Failed to attach to Excel") Local $iNum For $iRow = 1 To 6 Time() Local $iNum = Number(_Excel_RangeRead($oBook, $sSheet, "A" & $iRow)) If ($iNum = 1) Then ConsoleWrite("Row " & $iRow & " is 1 and value of column B is " & _Excel_RangeRead($oBook, $sSheet, "B" & $iRow)) Else ConsoleWrite("Row " & $iRow & " is not 1") EndIf ConsoleWrite(". Reading took: ") Time() Next ConsoleWrite("The whole operation took " & $iTotalTime & " milliseconds." & @CRLF) EndFunc Func Time() Local Static $hTimer Local Static $bRunning = False If $bRunning Then Local $iTime = Round(TimerDiff($hTimer), 2) $iTotalTime += $iTime ConsoleWrite($iTime & @CRLF) Else $hTimer = TimerInit() EndIf $bRunning = Not $bRunning EndFunc And Test.xlsx in CSV format:
      1,-1 -1,1 1,-1 1,1 -1,-1 1,1 Here is the actual xlsx but it should expire in a week: https://we.tl/t-EVkxGp1kc6
      And finally output from my script:
      Row 1 is 1 and value of column B is -1. Reading took: 276.06 Row 2 is not 1. Reading took: 163.36 Row 3 is 1 and value of column B is -1. Reading took: 302.58 Row 4 is 1 and value of column B is 1. Reading took: 294.65 Row 5 is not 1. Reading took: 152.33 Row 6 is 1 and value of column B is 1. Reading took: 284.92 The whole operation took 1473.9 milliseconds.  
      Taking ~1.5 seconds for reading 6 rows of data is bad for my script, which needs to run as fast as possible . It would be nice if I can bring this down to 100 ms somehow, I am not very experienced working with MS office so I thought about asking you folks for help and advice on how I can optimize my script to squeeze out every bit of performance that I can get from this script
       
      Thanks for the help in advance!
    • By SlackerAl
      I have been using some AutoIt scripts to manipulate Excel for a few weeks now. Today they stopped working. I have rebooted the PC and I'm not aware of any other significant changes. I can start and use Excel conventionally without a problem, but any attempt to create an excel object from AutoIt fails. E.g
      #include <MsgBoxConstants.au3> #include <Excel.au3> Local $oExcel = _Excel_Open() If @error Then Exit MsgBox($MB_SYSTEMMODAL, "Excel UDF: _Excel_Open Example 1", "Error creating the Excel application object." & @CRLF & "@error = " & @error & ", @extended = " & @extended) Produces:
      @error = 1
      @extended = -2147221005
      I can't find that COM error listed anywhere... Anyone have any ideas?
    • By Eggie6
      Hi,
      I'm trying to write an formula to the excel, but it actually does not write anything into the cell, any ideas?
      $formula1="=MID(B"&$utakmice&",SEARCH("-",B"&$utakmice&")-1,1)" _Excel_RangeWrite($oWorkbook, $oWorkbook.Activesheet, $formula1, "C"&$smth)  
×
×
  • Create New...