FileCountLines incorect count

[HeavenlyDemon]

expandcollapse popup

#cs ----------------------------------------------------------------------------

AutoIt Version: 3.3.8.1
Author: HD

Script Function:
Template AutoIt script.

#ce ----------------------------------------------------------------------------

; Script Start - Add your code below here


#include <ButtonConstants.au3>
#include <ComboConstants.au3>
#include <DateTimeConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <GUIListBox.au3>
#include <WindowsConstants.au3>
#include <File.au3>

Opt("MustDeclareVars", 1)
Global $Form1, $Group1, $Group2, $Group3, $Input1, $Input2, $Input3, $Input5, $Button1, $Button2, $Button3, $Button4, $Combo1, $Combo2, $Date1, $Date2, $List1, $List2, $nMsg, $base = @ScriptDir & "\Comenzi\"
#region ### START Koda GUI section ### Form=c:\users\foxwizzy\desktop\form1.kxf
$Form1 = GUICreate("Meniu Principal", 1410, 701, 254, 113)
$Group1 = GUICtrlCreateGroup("Adauga Firma", 0, 0, 185, 129)
$Input1 = GUICtrlCreateInput("Nume", 24, 16, 121, 21, BitOR($GUI_SS_DEFAULT_INPUT, $ES_CENTER))
$Input2 = GUICtrlCreateInput("Strada", 24, 40, 121, 21, BitOR($GUI_SS_DEFAULT_INPUT, $ES_CENTER))
$Input3 = GUICtrlCreateInput("Numar", 24, 64, 121, 21, BitOR($GUI_SS_DEFAULT_INPUT, $ES_CENTER))
$Button1 = GUICtrlCreateButton("Adauga", 48, 88, 75, 25)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Group2 = GUICtrlCreateGroup("Verifica Comenzi", 0, 352, 393, 345)
$Date1 = GUICtrlCreateDate("2013/04/07 13:01:13", 104, 368, 170, 21)
$Button2 = GUICtrlCreateButton("Verifica", 152, 392, 75, 25)
$List1 = GUICtrlCreateList("", 8, 424, 169, 227)
$List2 = GUICtrlCreateList("", 184, 424, 201, 227)
$Button3 = GUICtrlCreateButton("Verifica Firma", 152, 656, 75, 25)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$Group3 = GUICtrlCreateGroup("Adauga Comanda", 0, 128, 185, 153)
$Combo1 = GUICtrlCreateCombo("Firma", 16, 144, 145, 25, BitOR($CBS_DROPDOWN, $CBS_AUTOHSCROLL))
$Input5 = GUICtrlCreateInput("Cantitate", 16, 192, 145, 21, BitOR($GUI_SS_DEFAULT_INPUT, $ES_CENTER))
$Combo2 = GUICtrlCreateCombo("Produs", 16, 168, 145, 25, BitOR($CBS_DROPDOWN, $CBS_AUTOHSCROLL))
$Button4 = GUICtrlCreateButton("Adauga", 48, 248, 75, 25)
$Date2 = GUICtrlCreateDate("2013/04/07 16:05:56", 16, 216, 146, 21)
GUICtrlCreateGroup("", -99, -99, 1, 1)
Local $x
For $x = 1 To _FileCountLines($base & "firme.dat")
GUICtrlSetData($Combo1, FileReadLine($base & "firme.dat", $x))
Next
GUISetState(@SW_SHOW)
#endregion ### END Koda GUI section ###

start()
new_firm()
new_prod()
verify()

Func start()
While 1
$nMsg = GUIGetMsg()
Switch $nMsg
Case $GUI_EVENT_CLOSE
Exit

EndSwitch
WEnd
EndFunc ;==>start

Func new_firm()

EndFunc ;==>new_firm

Func new_prod()

EndFunc ;==>new_prod

Func verify()

EndFunc ;==>verify

The file

Sirolena
Turcu
Atac
P.F.A.
test
Nume

I only get 3 lines out of 6

Edited April 7, 2013 by HeavenlyDemon

[guinness]

Does each line have the same line ending e.g. @CRLF?

To check open the file in SciTE and View>>End of Line. Though ideally you should be using _FileReadToArray.

[Melba23]

HeavenlyDemon,

I get all 6 lines entered into the combo. Try reading the file into an array with _FileReadToArray and see how many elements you get - perhaps there is a EOL problem.

M23

[water]

Try:

#include <Array.au3>
Global $aLines, $sEntries
_FileReadToArray($base & "firme.dat", $aLines)
$sEntries = _ArrayToString($aLines, "|", 1)
GUICtrlSetData($Combo1, $sEntries)

[Melba23]

HeavenlyDemon,

You cannot complain about the consistency of the advice you get here! Best you try it soon!

M23

[guinness]

Thankfully these errors have been fixed in the beta versions of these functions.

[HeavenlyDemon]

Local $x, $li
_FileReadToArray($base & "firme.dat", $li)
For $x = 1 To $li[0]
GUICtrlSetData($Combo1, FileReadLine($base & "firme.dat", $x))
Next
GUISetState(@SW_SHOW)

Same....only 3

[HeavenlyDemon]

HeavenlyDemon,

You cannot complain about the consistency of the advice you get here! Best you try it soon!

M23

Cant keep up with you )...testing all advices now

[HeavenlyDemon]

Try:

#include <Array.au3>
Global $aLines, $sEntries
_FileReadToArray($base & "firme.dat", $aLines)
$sEntries = _ArrayToString($aLines, "|", 1)
GUICtrlSetData($Combo1, $sEntries)

This works but it looks like thie

Sirolena

Turcu

AtacP.F.A.testNume

[water]

Local $x, $li
_FileReadToArray($base & "firme.dat", $li)
For $x = 1 To $li[0]
GUICtrlSetData($Combo1, FileReadLine($base & "firme.dat", $x))
Next
GUISetState(@SW_SHOW)

Same....only 3

You are mixing concepts. Either read the whole file to an array (_FileReadToArray) or read every single line (FileReadLine).

Did you try my code example? It is untested but should work (with a bit of bug fixing).

[Melba23]

Heavenly Demon,

You certainly have an EOL problem - try running this and see if it works:

#include <GUIConstantsEx.au3>
#include <ComboConstants.au3>

$Form1 = GUICreate("Meniu Principal", 500, 500)
$Combo1 = GUICtrlCreateCombo("Firma", 16, 144, 145, 25, BitOR($CBS_DROPDOWN, $CBS_AUTOHSCROLL))

; Read file
$sText = FileRead($base & "firme.dat")
; Convert all EOLs into @CRLF
$sText = StringRegExpReplace($sText, "((?<!\x0d)\x0a|\x0d(?!\x0a))", @CRLF)
; Split the file
$aLines = StringSplit($sText, @CRLF, 1)
; Read the elements into the combo
For $i = 1 To $aLines[0]
    GUICtrlSetData($Combo1, $aLines[$i])
Next

GUISetState(@SW_SHOW)

While 1
    If GUIGetMsg() = $GUI_EVENT_CLOSE Then Exit
WEnd

Any luck?

M23

[HeavenlyDemon]

Heavenly Demon,

You certainly have an EOL problem - try running this and see if it works:

#include <GUIConstantsEx.au3>
#include <ComboConstants.au3>

$Form1 = GUICreate("Meniu Principal", 500, 500)
$Combo1 = GUICtrlCreateCombo("Firma", 16, 144, 145, 25, BitOR($CBS_DROPDOWN, $CBS_AUTOHSCROLL))

; Read file
$sText = FileRead($base & "firme.dat")
; Convert all EOLs into @CRLF
$sText = StringRegExpReplace($sText, "((?<!\x0d)\x0a|\x0d(?!\x0a))", @CRLF)
; Split the file
$aLines = StringSplit($sText, @CRLF, 1)
; Read the elements into the combo
For $i = 1 To $aLines[0]
GUICtrlSetData($Combo1, $aLines[$i])
Next

GUISetState(@SW_SHOW)

While 1
If GUIGetMsg() = $GUI_EVENT_CLOSE Then Exit
WEnd

Any luck?

M23

Sorry for late respons

Nope....empty box

can i get rid of the EOL error if i reinstall autoit ?

or is there a specific reason this EOL error is happening ?

Edited April 7, 2013 by HeavenlyDemon

[kylomas]

H.D.,

Can you post some or all of the ACTUAL file?

kylomas

[HeavenlyDemon]

H.D.,

Can you post some or all of the ACTUAL file?

kylomas

right now that is the file

its a new project the file is going to containe a verry long list of names that i am going to encrypt before writeing it in the file

[guinness]

I'm wondering how the file is generated.

[HeavenlyDemon]

this script is going to generate the file with the

_StringEncrypt()

[FireFox]

Can you tell us what is the OEL character ? (click on the P symbol in notepad++ or Ctrl+Shift+9 in SciTE)

Edited April 7, 2013 by FireFox

[HeavenlyDemon]

Sirolena CRLF
Turcu CRLF
Atac CR
P.F.A. CR
test CR
Nume CRLF

Edited April 7, 2013 by HeavenlyDemon

[HeavenlyDemon]

Dam....i deleted the lines in the file and readded them and now

Local $x, $li
_FileReadToArray($base & "firme.dat", $li)
$x = _ArrayToString($li, "|", 1)
GUICtrlSetData($Combo1, $x)

works

Thank you for all the help

Respect 2 all

Edited April 7, 2013 by HeavenlyDemon

[guinness]

The functions that have been mentioned can't handle when a file has multiple variations of @CRLF, @LF or @CR and presumes that if the file contains @CRLF, then all EOLs should be @CRLF. Which wasn't the case in your example.