Jump to content
AJB

While Loop confusion

Recommended Posts

AJB

Hello,

I am relatively new to autoit (and this type of programming in general, typically do front end web dev). I have been tasked with writing some scripts to login to, navigate, and download files from some private websites. I have been hacking my way through these projects with plenty of wrong turns, cursing, and confusion.

 

I currently have a script that works, but utilizes some rather lengthy Sleep times to manage varying page loading times. During page loads, there will often be text that says "Page Loading" I am trying to write some code to check whether this exists after particular steps, then if it does sleep for a few seconds, then check again until it no longer exists (page has loaded) then proceed. This is what I was trying based on sample code that I've seen throughout my google searches. It doesn't seem to work correctly, can someone point out what I'm doing wrong, or provide links to a 'for dummies' explanation of how to do what I'm trying to do?

$body = _IEBodyReadHTML($oIE)
 While
   If StringInStr($body, "Page Loading")== 1 Then
      Sleep(5000)
   Else
   EndIf
WEnd

Thank you for your insight.

Share this post


Link to post
Share on other sites
mLipok
Func _IE_Wait_notCpuMemoryChanges(ByRef $oIE, $iSleep = 0)
    If IsObj($oIE) Then
        Local $iIEPID = _IE_GetPid($oIE)
        Local Static $iWorkingSetSize
        Local Static $iPeakWorkingSetSize
        Local $aMemory
        While 1
            $aMemory = ProcessGetStats($iIEPID)
            If UBound($aMemory) Then
                If $iWorkingSetSize <> $aMemory[0] Or $iPeakWorkingSetSize <> $aMemory[1] Then
                    $iWorkingSetSize = $aMemory[0]
                    $iPeakWorkingSetSize = $aMemory[1]
                    If $iSleep <> 0 Then Sleep($iSleep)
                Else
                    ExitLoop
                EndIf
            Else
                ExitLoop
            EndIf
        WEnd
    EndIf
EndFunc   ;==>_IE_Wait_notCpuMemoryChanges

Func _IE_GetPid(ByRef $oIE)
;~  http://www.autoitscript.com/forum/topic/152691-how-to-know-pid-in-this-case/#entry1096901
    Local $hwnd = _IEPropertyGet($oIE, 'hwnd')
    Local $PID = DllStructCreate("int")
    Local $aCall = DllCall("user32.dll", "int", "GetWindowThreadProcessId", "hwnd", HWnd($hwnd), "dword*", DllStructGetPtr($PID))
    Return $aCall[2]
;~     MsgBox(0,"PID", $aCall[2])
EndFunc   ;==>_IE_GetPid

 


Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API Forum Rules *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library
 

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection * * 2GUI on Dual Monitor System * _SciLexer.au3 UDF *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-10-31

Share this post


Link to post
Share on other sites
AJB

For the concept  ;)

While 1
   $body = _IEBodyReadHTML($oIE)
   If StringInStr($body, "Page Loading") Then
      Sleep(5000)
   Else
      Exitloop
   EndIf
WEnd

 

I see that I neglected to include the Exitloop per your sample, but when trying to implement it I've ended up with an infinite loop, even though the "Page Loading" string is no longer in $body. I'm wondering if it relates to another issue that I was having, where my _IE commands were referencing the previous instance of html after each page change (I've been working around this by reattaching to the page with $oIE = _IEAttach after every link followed, page change, etc. to get the current iteration of the page). Or am I just not getting the concept?

Thank you for your help.

Share this post


Link to post
Share on other sites
mikell

Including Exitloop is necessary but not sufficient, you must also put the _IEBodyReadHTML inside the loop so you do every time the StringInStr checking on a refreshed source content

Share this post


Link to post
Share on other sites
AJB

Including Exitloop is necessary but not sufficient, you must also put the _IEBodyReadHTML inside the loop so you do every time the StringInStr checking on a refreshed source content

Is the example format incorrect then? I assumed that everything within the While and WEnd was within the loop. I also tried putting some gibberish as the string in the If statement (assuming that since it wouldn't be anywhere in $body that it would exit immediately)but it still just does infinite loops without ever exiting. 

Share this post


Link to post
Share on other sites
kaisies

Is the example format incorrect then? I assumed that everything within the While and WEnd was within the loop. I also tried putting some gibberish as the string in the If statement (assuming that since it wouldn't be anywhere in $body that it would exit immediately)but it still just does infinite loops without ever exiting. 

If it never exits, then you have a problem with your $oIE.

Share this post


Link to post
Share on other sites
mikell

Could you post the code which is before the While loop ?

Share this post


Link to post
Share on other sites
AJB
#include <IE.au3>
#include <Date.au3>
#include <Excel.au3>
#include <MsgBoxConstants.au3>

Call ("myFunc")

Func myFunc()

;This deletes the file if it still exists
IF FileExists("C:\filenameexample.csv") == 1 Then
    FileDelete("C:\filenameexample.csv")
EndIf

$oIE = _IECreate ("http://www.example.com/login")

$username = _IEGetObjById ($oIE, "login_username")
$password = _IEGetObjById ($oIE, "login_password")

;Fill in login credentials and submit
_IEFormElementSetValue ($username, "exampleusername")
_IEFormElementSetValue ($password, "examplepassword")
$oButtons = _IETagNameGetCollection ($oIE, "button")
 For $oButton In $oButtons
    If $oButton.type = "submit" Then _IEAction ($oButton, "click")
 Next
Sleep(15000)

;Reattach to page - I HAVE TO DO THIS EVERY SINGLE TIME
$oIE = _IEAttach("welcome KEVIN","text")

;Select the lead type from dropdown
$LeadType = _IEGetObjByName($oIE, "data[leads_types]")
$LeadType.focus
_IEFormElementOptionSelect($LeadType, "Expired", 1, "byText")
Sleep(2000)

;click Filter button
$filterBtn = _IEGetObjById($oIE, "advanced_search")
_IEAction($filterBtn, "click")
Sleep(5000)

;Check for page load
$oIE = _IEAttach("welcome KEVIN","text")
; trying to attach again
While 1
  $body = _IEBodyReadHTML($oIE)
  If StringInStr($body, "Page Loading") Then ;I can put anything as that string but it loops infinitely anyway
      Sleep(5000)
      MsgBox($MB_SYSTEMMODAL, "Loop", "Looping", 1)
   Else
      Exitloop
   EndIf
WEnd

continues................

This is the code that leads up to the looping issue. The other issue is the attachment problem, every time I do anything creates a change on the page, follow a link, press a button, etc autoit needs to be reattached. I'm fairly certain this is causing the loop problem because it isn't seeing the new "Page loading" div. Is this normal behavior for autoit and the IE udf? 

This is also creating an issue later in my code where I open and paste into an excel sheet and save. When I reactivate the IE window I can't even attach to it... 

Thanks again to everyone for taking their time to reply and help me work through this.

Share this post


Link to post
Share on other sites
aleph01

I know this has nothing to do with the issues you are trying to resolve, but with my admittedly limited coding skills, I offer this, only because I believe the shorter the code, the more elegant it is.  Much of your code is over my head, simply because I haven't worked much with IE.au3 functions.  However, AutoIt has a wonderful feature which allows you to eliminate some overhead when creating some If...EndIf statements.  The first task in your function cold be written as follows, on one line, no EndIf required:

Func myFunc()

;This deletes the file if it still exists
IF FileExists "C:\filenameexample.csv" Then  FileDelete("C:\filenameexample.csv")

 

Sorry, I don't seem to see the "insert code" button, but the code I suggest is so short as to almost eliminate the need for it.

I hope you are as delighted with this feature as I am, and good luck with getting your script exemplary.  I know from experience that you will be getting expert help on this forum.

_aleph_


Meds.  They're not just for breakfast anymore. :'(

Share this post


Link to post
Share on other sites
AJB

I ended up just using extended sleep delays to get around the issue. None of the loops I was trying worked unfortunately. Still haven't figured out why sometimes autoit 'detaches'  or references the previous iteration of the html from the webpage in IE11. Some scripts I've written have no such issue, and others I have to constantly reattach to get the updated page data after any change events...

Thank you guys for your input.

Edited by AJB

Share this post


Link to post
Share on other sites
philkryder

I ended up just using extended sleep delays to get around the issue. None of the loops I was trying worked unfortunately. Still haven't figured out why sometimes autoit 'detaches'  or references the previous iteration of the html from the webpage in IE11. Some scripts I've written have no such issue, and others I have to constantly reattach to get the updated page data after any change events...

Thank you guys for your input.

did you try:
If StringInStr($body, "Page Loading") > 0 Then ;
The return value for
StringInStr is numeric not Boolean.
If the value of zero is returned that is likely treated as False.

 

 

 

Edited by philkryder

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Similar Content

    • Seminko
      By Seminko
      Wrote a script that grabs all of the IP addresses from Netflix's IP log, checks the IPs and returns suspicious activity.
      Everything works as it should but only when _IECreate is set to visible. When visible is set to false, it fails to login for some reason.
      Any ideas what might cause it and/or how to circumvent that?
    • nooneclose
      By nooneclose
      I need to send a string of text to this popup and click on the ok button to save it.
      Here is the code I have so far:
      ;Start IE Sleep(7000) $oIE = _IECreate("http://www.google.com") Sleep(500) _IELoadWait($oIE) $hIE = _IEPropertyGet($oIE, "hwnd") ; Get Handle of the IE window Sleep(500) WinSetState($hIE, "", @SW_MAXIMIZE) ;Wait for a browser page load to complete Sleep(3000) _IENavigate($oIE, "https://properURL.com") Sleep(8000) _IELoadWait($oIE) ;Attach to a browser control embedded in another window $oIE = _IEAttach("https://"properURL.com", url") ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $oIE = ' & $oIE & @CRLF & '>Error code: ' & @error & ' Extended code: 0x' & Hex(@extended) & @CRLF) ;### Debug Console Sleep(2000) ;Get the title of the webpage ;Local $wTitle = _IEPropertyGet($oIE, "title") ;MsgBox($MB_SYSTEMMODAL, "Webpage title:", $wTitle) ;Clicks the new button Sleep(3000) _IEAction($nWorkOrderB, "focus") _IEAction($nWorkOrderB, "click") Sleep(5000) ;Store the Element names where the important data will be sent ;Store the long description button Local $wLongDButton = _IEGetObjById($oIE, "m65d795a4-img") ;Store the long Description field id Local $wComments = _IEGetObjById($oIE, "ma6499a9c-rte_iframe") ;Store the ok button id that is in the long description Local $wCommOk = _IEGetObjById($oIE, "m74031266-pb") ;******************************************************************************* ; Send the stored data to the proper field ;******************************************************************************* ;Click the long description button Sleep(300) _IEAction($wLongDButton, "focus") _IEAction($wLongDButton, "click") Sleep(300) ;Sends the Comments Sleep(500) _IEAction($wComments, "focus") _IEAction($wComments, "click") Sleep(500) _IEFormElementSetValue($wComments, "hello darkness my old friend") ;Click the ok button Sleep(500) _IEAction($wCommOk, "focus") _IEAction($wCommOk, "click") Sleep(500)  
      Here is the popup:

    • hemichallenger
      By hemichallenger
      Hello,
      If anyone can help, it would be greatly appreciated. The code is just an example and similar to the issue with an internal webpage. I'm trying to autofill than click the submit button. I get the same error running the script.
      _IEFormElementSetValue, $_IESTATUS_InvalidObjectType
      IEGetObjById, $_IESTATUS_NoMatch
      Is it possible to edit the <textarea></textarea>  field with AutoIt?  If anyone could assist me on how. Than I could have a better understanding and chance in figuring it out on my main script. Thank you
      #include <IE.au3> Local $oIE1 = _IECreate ("https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea") _IELoadWait($oIE1) local $oFormCollection = _IEFormGetCollection($oIE1,0) local $oid = _IEGetObjByid($oFormCollection, "iframeResult") _IEFormElementSetValue($oid, "test") sleep (2000) Local $oIE2 = _IECreate ("https://www.w3schools.com/html/tryit.asp?filename=tryhtml_scripts_intro") _IELoadWait($oIE2) $oForm2 = _IEFormGetCollection($oIE2,0) $oClickMe = _IEGetObjById($oForm2, "demo") _IEAction($oClickMe, "focus") _IEAction($oClickMe, "click")
    • Blueman
      By Blueman
      Hey Guys,
      Hope that you can help me with something, maybe this is a bug in the new version of AUTOIT but first i will check it with you to know for sure.
      I have made a simple GUI with a Embedded IE Object, then i would like to read the HTML with _IEBodyReadHTML(), easy right?
      When i use the old IE.au3 include from a year back or so, it is working fine!
      When i use the new IE.au3 include came with the new installation that is currently available on autoitscript.com it isnt working (i get a result that says; 0).
      Let me show you.
       
      Working Example
      #include <GUIConstantsEx.au3> #include <IE_EmbeddedVersioning.au3> #include <IE_PreVersion.au3> ;Older Version Example() Func Example() ; Create a GUI with various controls. Local $hGUI = GUICreate("Example", 1000, 1000) Local $idOK = GUICtrlCreateButton("OK", 310, 370, 85, 25) Global $oIE_1 = _IECreateEmbedded() ; CREATE IE OBJECT(S) GUICtrlCreateObj($oIE_1, 355, 5, 600, 360) _IENavigate($oIE_1, "https://www.google.nl", 1) Local $CheckHTML_T = _IEBodyReadHTML($oIE_1) ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) MsgBox(48,"",$CheckHTML_T) ; Loop until the user exits. While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE, $idOK ExitLoop EndSwitch WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>Example  
      Failing Example
      #include <GUIConstantsEx.au3> #include <IE_EmbeddedVersioning.au3> #include <IE.au3> ;New Version Example() Func Example() ; Create a GUI with various controls. Local $hGUI = GUICreate("Example", 1000, 1000) Local $idOK = GUICtrlCreateButton("OK", 310, 370, 85, 25) Global $oIE_1 = _IECreateEmbedded() ; CREATE IE OBJECT(S) GUICtrlCreateObj($oIE_1, 355, 5, 600, 360) _IENavigate($oIE_1, "https://www.google.nl", 1) Local $CheckHTML_T = _IEBodyReadHTML($oIE_1) ; Display the GUI. GUISetState(@SW_SHOW, $hGUI) MsgBox(48,"",$CheckHTML_T) ; Loop until the user exits. While 1 Switch GUIGetMsg() Case $GUI_EVENT_CLOSE, $idOK ExitLoop EndSwitch WEnd ; Delete the previous GUI and all controls. GUIDelete($hGUI) EndFunc ;==>Example  
      I have attachted all files and i am testing on Windows 10 with the latest SciTe Program (Not compiled). 
      When i compile the script it is showing the same result.
      Thanks guys!
      IE_PreVersion.au3
      IE.au3
      IE_EmbeddedVersioning.au3
    • ShakeelAhmad
      By ShakeelAhmad
      I've to upload different number of photos online in different assignments. There is a problem that all photos cannot be selected at once to upload. I have to choose and upload photos one by one. For this purpose I have made a script to automate whatever I have to do manually for choosing and uploading photos one by one.
      Please see my script below and check the last "MouseClick" command. This command clicks the button to choose and upload next photo. The problem I'm facing is; the last "MouseClick" works 1 step extra when all photos have been selected and uploaded. I mean if 7 photos are to be uploaded, this command opens the box from where next photo is selected and uploaded then it again opens the box and next photo is choosen and so on.... when last photo is selected and uploaded, this button once again opens the box. When all photos are uploaded, it should not click the button to select next photo. Please suggest how can I resolve this issue.
      #include <AutoItConstants.au3> Sleep(200) HotKeySet("{ESC}","Quit") ;Press ESC key to quit Send("{ALT DOWN}") Send("{TAB}") Send("{ALT UP}") Sleep(200) Local $photos = InputBox("Question", "How many photos to upload?", "#", "", _ - 1, -1, 0, 0) ; How many photos to upload Local $selector = 0 While $photos <> $selector MouseClick("Left", 281, 238, 1) ; mouse click on very first photo in the box. if $selector = 0 Then Send("{ENTER}") ; for selecting very first photo from "open" window. Sleep(800) Else sleep(200) Send("{RIGHT " & $selector & "}") ; for selecting 2nd to onward photos from "open" window. sleep(1000) Send("{ENTER}") sleep(1000) EndIf MouseClick("Left", 495, 198, 1) ; for clicking a button to choose next photo to upload $selector = $selector + 1 WEnd Beep(1500, 300) ; beep when all photos uploaded Exit Regards,
       
      Shakeel
×