Jump to content
Champak

Issue with returning a variable

Recommended Posts

Champak

What I expect in the following example is the voltage to be returned with ONE asterisk beside it no matter how many times this is called. However an asterisk is added every time it is called. So by the third time what's returned is "12.4***" instead of "12.4*". Am I using the return incorrectly or expecting the wrong thing?

Func _OBDII_BatteryVoltage($sBatteryVoltage)

    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        Return $BattVoltage & "*"
    EndIf
    
    ;blah blah
    
endfunc

The $BattVoltage variable is a global variable that's populated in another function. That's why it's not declared here or given a value here.

 

Share this post


Link to post
Share on other sites
mLipok

where $BattVoltage is declared ?

EDIT:
You are here almost so long like me.
You should know how to post working example.

Plesase post working example code, which show how you are using them.

Edited by mLipok

Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API Forum Rules *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library
 

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-10-15

Share this post


Link to post
Share on other sites
Jos
40 minutes ago, Champak said:

The $BattVoltage variable is a global variable

That is fine , but in this Func you defined it as Local scope due to the fact you put it on the Func statement as parameter.
So how are you calling this Func since you are returning the proper value?

Jos


SciTE4AutoIt3 Full installer Download page   - Beta files       Read before posting     How to post scriptsource        Forum Rules
 
Live for the present,
Dream of the future,
Learn from the past.
  :)

Share this post


Link to post
Share on other sites
mLipok

 

1 hour ago, Champak said:

The $BattVoltage variable is a global variable

I overlooked it

30 minutes ago, Jos said:

That is fine , but in this Func you defined it as Local scope due to the fact you put it on the Func statement as parameter.

@Jos I think you also overlooked something ;)
This snippet is little strange, as the parameter has different variable name.
Param: $sBatteryVoltage
Returned value: $BattVoltage

So this can be writen (conceptualy) like this:

Func _OBDII_BatteryVoltage($bTest)

    If $bTest Then
        Return $__g_vBattVoltage & "*"
    EndIf
    
    ;blah blah
    
endfunc

 

As to @Champak question I propose such solution:

Func _OBDII_BatteryVoltage($bTest)

    If $bTest Then
        If StringRight($__g_vBattVoltage,1) <> "*" Then $__g_vBattVoltage &= "*"
        Return $__g_vBattVoltage
    EndIf
    
    ;blah blah
    
EndFunc

 

Edited by mLipok

Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API Forum Rules *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library
 

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-10-15

Share this post


Link to post
Share on other sites
Jos

True...  guess it is too confusing in te way it is setup.
To exchange values you either use Byref or Return xxxx and really should avoid using Global for that.

Jos


SciTE4AutoIt3 Full installer Download page   - Beta files       Read before posting     How to post scriptsource        Forum Rules
 
Live for the present,
Dream of the future,
Learn from the past.
  :)

Share this post


Link to post
Share on other sites
AutoBert

What i not understand in this example, why returning a Global var? The var is always available, assigning is just enough, returning not needed.

Share this post


Link to post
Share on other sites
mLipok
9 minutes ago, AutoBert said:

What i not understand in this example, why returning a Global var? The var is always available, assigning is just enough, returning not needed.

As I said:

20 minutes ago, mLipok said:

This snippet is little strange,

Lets wait what @Champak would say.

 


Signature beginning:   Wondering who uses AutoIT and what it can be used for ?
* GHAPI UDF - modest begining - comunication with GitHub REST API Forum Rules *
ADO.au3 UDF     POP3.au3 UDF     XML.au3 UDF    How to use IE.au3  UDF with  AutoIt v3.3.14.x  for other useful stuff click the following button

Spoiler

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. 

My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST APIErrorLog.au3 UDF - A logging Library
 

My contribution to others projects or UDF based on  others projects: * _sql.au3 UDF  * POP3.au3 UDF *  RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF SMTP Mailer UDF * Dual Monitor resolution detection *

Useful links: * Forum Rules * Forum etiquette *  Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * 

Wiki: Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * 

IE Related:  * How to use IE.au3  UDF with  AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler

I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions *  EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *

"Homo sum; humani nil a me alienum puto" - Publius Terentius Afer
"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming"
:naughty:  :ranting:, be  :) and       \\//_.

Anticipating Errors :  "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty."

Signature last update: 2018-10-15

Share this post


Link to post
Share on other sites
Champak

Sorry, It's not explained more clearly. When I post my issues sometimes it's as clear as day to me because I'm experiencing it, I thought this was in its form.

Global $BattVoltage = 0


Func _OBDII_BatteryVoltage($sBatteryVoltage)


    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        _ConsoleWrite(" No Voltage 1 detected, return previous")
        Return $BattVoltage & "*"
    EndIf



    $sBatteryVoltage = StringTrimRight(StringStripCR($sBatteryVoltage), 1)
    If StringIsAlNum(StringLeft($sBatteryVoltage, 2)) Then
        $BattVoltage = $sBatteryVoltage
        Return $BattVoltage
    Else
        _ConsoleWrite(" No Voltage 2 detected, return previous")
        Return $BattVoltage & "*"
    EndIf


EndFunc




While 1

    $NavS = WinGetState($AppTitle_Settings2, "Vdc")
    If TimerDiff($ITIMER_BATTERY_V) > 5000 And BitAND($NavS, 2) Then

        $SendString2 = _CommSendString("AT RV" & @CR, 1)
        Sleep(100)
        $BattVoltage = _OBDII_BatteryVoltage(_CommGetString())
        ;ControlSetText($AppTitle_Settings2, "", Int($NAV_OPTIONS_ARRAY[39][1]), $BattVoltage & "*")
        _MailSlotWrite($hMailSlotFromNav, $BattVoltage, 2, "04");===send obd battery voltage to print. If we ctrlset text it wont print properly

        $ITIMER_BATTERY_V = TimerInit()

    EndIf
            
WEnd

 

Share this post


Link to post
Share on other sites
mikell

You might use this in the Return

$bv = "12.4"  ; "12.4*******" 

Msgbox(0,"", StringRegExpReplace($bv & "*", '\*+', "*") )

 

Share this post


Link to post
Share on other sites
BrewManNH

Instead of returning a value, just reset the value of $Batteryvoltage inside the function if needed. Maybe something like this.

Func _OBDII_BatteryVoltage($sBatteryVoltage)
    If StringMid($sBatteryVoltage, 4, 2) = "0D" Then
        _ConsoleWrite(" No Voltage 1 detected, return previous")
        $BattVoltage = $sBatteryVoltage & "*"
    EndIf
    $sBatteryVoltage = StringTrimRight(StringStripCR($sBatteryVoltage), 1)
    If StringIsAlNum(StringLeft($sBatteryVoltage, 2)) Then
        $BattVoltage = $sBatteryVoltage & "*"
    Else
        _ConsoleWrite(" No Voltage 2 detected, return previous")
        $BattVoltage = $sBatteryVoltage & "*"
    EndIf
EndFunc   ;==>_OBDII_BatteryVoltage

 


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
Champak

 

@mikell That's a solution, however I need one asterisk to remain if I went that route.

 

@BrewManNH so what your saying is because the return is inside the IF condition this is happening (not saying your solution isnt cleaner to follow)? I'll try it later to see if it works.

 

Still dont understand WHY it's happening like that though.

Share this post


Link to post
Share on other sites
Danyfirex

The problem is that  programatically you say this.

MyvariableGlobal is = MyvariableGlobal(if is global will keep the previous values  if is not set to clean) & "*"

because the function return value to itself.

So Basically you're doing this.

$Variable = ($Variable & "*")  every time you call your function.

 

Saludos

 

Edited by Danyfirex
typo

Share this post


Link to post
Share on other sites
mikell
7 hours ago, Danyfirex said:

$Variable = ($Variable & "*")  every time you call your function.

That's why in this case I suggested this

$Variable = StringRegExpReplace($Variable & "*", '\*+', "*") )

which returns $Variable & "*" with one star only even when there are several calls

Share this post


Link to post
Share on other sites
Danyfirex

@mikell I just answer his last question about why it was happening() and I know nothing about regexp lol). something else, use global that way is not correct.

 

Saludos

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×