Detect double variable declaration

[maniootek]

I just started to change most of my scripts by adding this line:

AutoItOption("MustDeclareVars", True)

I just realized how important it is (I know it's kind of shame but better late than never)

Mostly, this mean I have to add "Local" before all variable declaration. Scripts are large and there is many variables. I want to be sure that I didn't declared same variable twice. Is there any option to check this via Scite?

[Danp2]

Yes, I believe there's an option for that with Au3Check

[mLipok]

  On 11/1/2018 at 9:20 PM, maniootek said:

I just realized how important it is (I know it's kind of shame but better late than never)

Expand  

Cześć.

This only mean that you keep learning  I had the same problem about 4 years ago.

  On 11/1/2018 at 9:20 PM, maniootek said:

Mostly, this mean I have to add "Local" before all variable declaration.

Expand  

Almost ... not always, sometimes Global instead Local

  On 11/1/2018 at 9:20 PM, maniootek said:

Scripts are large and there is many variables

Expand  

How many lines ? more then 10000 ?

  On 11/1/2018 at 9:20 PM, maniootek said:

I want to be sure that I didn't declared same variable twice. Is there any option to check this via Scite?

Expand  

Try to use this:

; AU3Check settings
#AutoIt3Wrapper_Run_AU3Check=Y
#AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7
#AutoIt3Wrapper_AU3Check_Stop_OnWarning=Y

how many ERROR's and WARNINGS's  you get ?
In one of my old script I had more than 500 ... but this is past time - all fixed MANUALLY .... and you now what: 
It was worth it, correct them manually ! ... because I learned even more.

 

Edited November 1, 2018 by mLipok

[BrewManNH]

  On 11/1/2018 at 9:20 PM, maniootek said:

Mostly, this mean I have to add "Local" before all variable declaration

Expand  

Only use Local when the variables are being declared inside of a function, anywhere else is wrong usage (IMNSHO).

And the option you want for Au3Check is the "-w 3" option.

  Quote

-w 3      : already declared var (off)

Expand  

 

[mLipok]

  On 11/1/2018 at 9:31 PM, BrewManNH said:

IMNSHO

Expand  

But you know... I agree with you.

[maniootek]

  On 11/1/2018 at 9:31 PM, BrewManNH said:

Only use Local when the variables are being declared inside of a function, anywhere else is wrong usage (IMNSHO).

Expand  

The problem is that I didn't declare variables outside the functions and they were declared as global by default. When I started to include other script files with same variable name inside then script started to working wrong because of this.

This is the reason I started to declare some funtions as local outside the functions.

I don't know why this is not good idea? Or maybe my scripts are wrong designed as some of them are not functions?

[pixelsearch]

  On 11/2/2018 at 7:12 AM, maniootek said:

The problem is that I didn't declare variables outside the functions and they were declared as global by default.

Expand  

You can't change this behavior, even if you declare variables as Local in the main part of your script (i.e. outside functions), they will be considered as Global. The following sentence is extracted from a wiki page concerning autoit (link below) :

"A variable declared as Local in the Global scope is still a Global variable, it's only for the sake of code clarity that you'd use the Local declaration in the Global scope."

https://www.autoitscript.com/wiki/Best_coding_practices

imho, the only case where it should be advisable to use the word "Local" to declare variables in the main part of your script (outside functions), this case could happen if you intend to #include <...> this script as a function (or within a function)... within another script.
 

Edited November 2, 2018 by pixelsearch

[maniootek]

Thank you all. Now I use au3check with some options to check my code and I started to declare variables in functions and in global scope. I also understand the global scope variable declaration. I wish to know it 9 years ago when I started code in AutoIt  

Anyway, I have one more question. I want use au3check with option

  Quote

-w 5: local var declared but not used (off)

Expand  

because it's very helpful, but in case I declare variable for error handler then I got error too. I want notice that I have to declare error handler object to some variable because only this way it is working. Am I right or I miss something?

I want keep au3check with option "-w 5" but I also want my error handler working right way. Any idea?

[RTFC]

use #forceref

[Skeletor]

  On 11/1/2018 at 9:29 PM, mLipok said:

This only mean that you keep learning  I had the same problem about 4 years ago.

Expand  

@mLipok, I really didn't think you have had any issues with things like this. I mean, you create some really useful stuff on AutoIt. 
Guess we all start at the same point.

Like someone said, Experience is only achieved by the mistakes we made.

[mLipok]

  On 11/8/2018 at 10:07 AM, Skeletor said:

Experience is only achieved by the mistakes we made.

Expand  

I'm very, very, very, experienced, and I'm sill making stupid things.

But the most important thing is to :
"Stop making the same mistakes or be creative - make new mistakes."

[Earthshine]

use a better naming convention such that you give each variable a unique AND MEANINGFUL name. don't use x everywhere and be lazy. Every Error Handler has it's own name. I don't have this problem, ever. in any language

meaningful names describe the variable and it's use

Edited November 8, 2018 by Earthshine

[maniootek]

  On 11/1/2018 at 9:29 PM, mLipok said:

; AU3Check settings
#AutoIt3Wrapper_Run_AU3Check=Y
#AutoIt3Wrapper_Au3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7
#AutoIt3Wrapper_AU3Check_Stop_OnWarning=Y

 

Expand  

I started to add these lines to my scripts but I am just curious if is possible to force this settings for all scripts? Some Au3Check global config?

[mLipok]

Yes autoitwrapper.ini

[maniootek]

  On 11/16/2018 at 12:45 PM, mLipok said:

Yes autoitwrapper.ini

Expand  

According to the help file located here i created a file 

  Quote

AutoIt3Wrapper.ini

Expand  

in location:

  Quote

%LOCALAPPDATA%\AutoIt v3\SciTE\AutoIt3Wrapper

Expand  

and inside the file I inserted these lines:

  Quote

[Other]
Run_AU3Check=1
AU3Check_Stop_OnWarning=1
AU3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7

Expand  

But it does not seemed to work. I see no warning when I run script:

Local $test = "some text" ;local variable in global scope
Func Test()
  $variable = "return" ;no variable declaration
  return $variable
Endfunc

Any idea?

[caramen]

  On 11/8/2018 at 12:40 PM, mLipok said:

or be creative - make new mistakes.

Expand  

 I can learn you 

[mLipok]

  On 11/23/2018 at 9:57 AM, caramen said:

 I can learn you 

Expand  

I learn day by day....

 

Edited November 23, 2018 by mLipok

[caramen]

  On 11/23/2018 at 11:10 AM, mLipok said:

I learn day by day....

 

Expand  

Should specify  I can learn you to do creative mistake  

Edited November 23, 2018 by caramen

[mLipok]

I learn day by day.... ... because I make mistakes day by day so I do not need additional mistakes, because I have a lot of my own.

[mLipok]

  On 11/23/2018 at 8:20 AM, maniootek said:

Any idea?

Expand  

Post here scite console output.