DigDeep Posted April 21, 2021 Share Posted April 21, 2021 Hi, My code has been working with no issues since long years and I remember have not made any change to the below code but since past few months have started getting Object Create error always at line Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count. Can someone help me with the cause and if anything is not correctly aligned here? expandcollapse popupFunc XLSCalc() Local $ID = '/Check/Detail/UpdateData/@ID' Local $Inst = '/Check/Detail/UpdateData/@IsInstalled' Local $Down = '/Check/Detail/UpdateData/References/DownloadURL' Local $Title = '/Check/Detail/UpdateData/Title' Local $Restart = '/Check/Detail/UpdateData/@RestartRequired' Local $KBID = '/Check/Detail/UpdateData/@KBID' Local $C_DIR = "C:\Test" Local $Src_DIR = $C_DIR & "\Source" Local $Files_DIR = $Src_DIR & "\Files" Local $ScanResults_DIR = $Files_DIR & "\ScanResults" DirCreate($ScanResults_DIR) Local $xml_result = $ScanResults_DIR & "\Results.xml" Local $oExcel = _Excel_Open(False) If @error Then _Excel_Close($oExcel) MsgBox(48, "", "Patch Status: An Error occured while opening Excel during XLSCalc." & @CRLF & @CRLF & "Please contact the administrator.") ; Error occurred while launching report. Exit EndIf Local $xls_result = $ScanResults_DIR & "\Results.xls" Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result) If @error Then _Excel_Close($oExcel) EndIf Local $XMLOut = _Excel_RangeRead($oWorkbook, Default, "A1") Select Case $XMLOut = "/XMLOut" _Excel_RangeDelete($oWorkbook.ActiveSheet, '1:1', 1) ; Delete 1st line as /XMLOut If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) _Excel_BookSave($oWorkbook) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndSelect Local $ColNum = $oWorkbook.ActiveSheet.UsedRange.Columns.Count ; Get last column Number Local $sTab7 Local $ColName For $j = $ColNum To 1 Step -1 Local $ScanResults_DIR = $Files_DIR & "\ScanResults" Local $FilePath = $ScanResults_DIR & "\Output.txt" Local $Output_FileOpen = FileOpen($FilePath, 2) Local $FileWrite = FileWrite($Output_FileOpen, $j) FileClose($Output_FileOpen) Local $TotalCol = FileRead($FilePath) Local $ColName = _Excel_ColumnToLetter($TotalCol) ; Get last column Header Name Local $sTab7 = _Excel_RangeRead($oWorkbook, Default, $ColName & '1') If $sTab7 = $ID Or $sTab7 = $Inst Or $sTab7 = $Down Or $sTab7 = $Title Or $sTab7 = $Restart Or $sTab7 = $KBID Then ; Do nothing... Else _Excel_RangeDelete($oWorkbook.ActiveSheet, $ColName & ':' & $ColName) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) _Excel_BookSave($oWorkbook) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndIf Local $sTab8 = _Excel_RangeRead($oWorkbook, Default, $ColName & '2') Local $sTab9 = _Excel_RangeRead($oWorkbook, Default, $ColName & '3') If $sTab8 = '' And $sTab9 <> '' Then _Excel_RangeDelete($oWorkbook.ActiveSheet, '2:2', 1) ; Delete 1st line if blank but not If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) _Excel_BookSave($oWorkbook) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndIf If $sTab7 = $ID Or $sTab7 = $Inst Then Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) For $i = $iCountLines To 1 Step -1 Local $sTab10 = _Excel_RangeRead($oWorkbook, Default, $ColName & $i) If $sTab10 = 'True' Then _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndIf Local $sTab11 = _Excel_RangeRead($oWorkbook, Default, $ColName & $i) If $sTab11 = '123456' Then _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndIf Local $v_Return = Column_GetValues($Files_DIR & "\Exclude.xls", "B", "A") Local $ExcludeFilePath = $ScanResults_DIR & "\FinalExclusion.txt" Local $FinalExclusion_FileOpen = FileOpen($ExcludeFilePath, 1) For $f = 1 To _FileCountLines($ExcludeFilePath) $ExcludeFile = FileReadLine($ExcludeFilePath, $f) If $sTab11 = $ExcludeFile Then _Excel_RangeDelete($oWorkbook.ActiveSheet, $i & ":" & $i, 1) If @error Then Exit MsgBox(0, "Error", "ObjCreate returned @error = " & @error & " and @extended = " & @extended & @CRLF & "Line " & @ScriptLineNumber) EndIf Next FileClose($FinalExclusion_FileOpen) Next EndIf Next _Excel_BookClose($oExcel) Sleep(500) _Excel_Close($oExcel) EndFunc ;==>XLSCalc Link to comment Share on other sites More sharing options...
water Posted April 21, 2021 Share Posted April 21, 2021 You should display an error message AND end the script when the workbook could not be opened. Replace Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result) If @error Then _Excel_Close($oExcel) EndIf with Local $oWorkbook = _Excel_BookOpen($oExcel, $xls_result) If @error Then MsgBox(0, "Error", "Can not open workbook. @error = " & @error & " and @extended = " & @extended & @CRLF & "Line: " & @ScriptLineNumber) _Excel_Close($oExcel) Exit EndIf My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
mLipok Posted April 21, 2021 Share Posted April 21, 2021 Which AutoIt version you are using ? I sugest to split this line: Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count to such piece of code: Local $oSheet = $oWorkbook.ActiveSheet Local $oUsedRange = $oSheet.UsedRange Local $oRows = $oUsedRange.Rows Local $iCount = $oRows.Count Signature beginning:* Please remember: "AutoIt"..... * Wondering who uses AutoIt and what it can be used for ? * Forum Rules ** ADO.au3 UDF * POP3.au3 UDF * XML.au3 UDF * IE on Windows 11 * How to ask ChatGPT for AutoIt Code * for other useful stuff click the following button: Spoiler Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST API * ErrorLog.au3 UDF - A logging Library * Include Dependency Tree (Tool for analyzing script relations) * Show_Macro_Values.au3 * My contribution to others projects or UDF based on others projects: * _sql.au3 UDF * POP3.au3 UDF * RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF * SMTP Mailer UDF * Dual Monitor resolution detection * * 2GUI on Dual Monitor System * _SciLexer.au3 UDF * SciTE - Lexer for console pane * Useful links: * Forum Rules * Forum etiquette * Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * Wiki: * Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * OpenOffice/LibreOffice/XLS Related: WriterDemo.au3 * XLS/MDB from scratch with ADOX IE Related: * How to use IE.au3 UDF with AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler * IE Embedded Control Versioning (use IE9+ and HTML5 in a GUI) * PDF Related: * How to get reference to PDF object embeded in IE * IE on Windows 11 * I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions * EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *I also encourage you to check awesome @trancexx code: * Create COM objects from modules without any demand on user to register anything. * Another COM object registering stuff * OnHungApp handler * Avoid "AutoIt Error" message box in unknown errors * HTML editor * winhttp.au3 related : * https://www.autoitscript.com/forum/topic/206771-winhttpau3-download-problem-youre-speaking-plain-http-to-an-ssl-enabled-server-port/ "Homo sum; humani nil a me alienum puto" - Publius Terentius Afer"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming" , be and \\//_. Anticipating Errors : "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty." Signature last update: 2023-04-24 Link to comment Share on other sites More sharing options...
DigDeep Posted April 21, 2021 Author Share Posted April 21, 2021 @water My bad. I have that added already. Missed to provide that in the above code. The error happens at the below line when the Rows count happens. If $sTab7 = $ID Or $sTab7 = $Inst Then Local $iCountLines = $oWorkbook.ActiveSheet.UsedRange.Rows.Count @mLipok I made the change and ran twice and now it is giving the attached error at the line: Local $oSheet = $oWorkbook.ActiveSheet I am wondering, there is no issue with Local $ColNum = $oWorkbook.ActiveSheet.UsedRange.Columns.Count ; Get last column Number or any step prior it starts for Rows count. Link to comment Share on other sites More sharing options...
mLipok Posted April 21, 2021 Share Posted April 21, 2021 (edited) HINT: Check ConsoleWrite(IsObj($oWorkbook) & @CRLF) ; and ConsoleWrite(ObjName($oWorkbook,1) & @CRLF) ; before you use: Local $oSheet = $oWorkbook.ActiveSheet REMARK:Anticipating Errors : "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty." SUMMARY: Something goes wrong when you get reference to $oWorkbook object, and the problem is that you don't check it before you was trying to use it. Edited April 21, 2021 by mLipok Signature beginning:* Please remember: "AutoIt"..... * Wondering who uses AutoIt and what it can be used for ? * Forum Rules ** ADO.au3 UDF * POP3.au3 UDF * XML.au3 UDF * IE on Windows 11 * How to ask ChatGPT for AutoIt Code * for other useful stuff click the following button: Spoiler Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind. My contribution (my own projects): * Debenu Quick PDF Library - UDF * Debenu PDF Viewer SDK - UDF * Acrobat Reader - ActiveX Viewer * UDF for PDFCreator v1.x.x * XZip - UDF * AppCompatFlags UDF * CrowdinAPI UDF * _WinMergeCompare2Files() * _JavaExceptionAdd() * _IsBeta() * Writing DPI Awareness App - workaround * _AutoIt_RequiredVersion() * Chilkatsoft.au3 UDF * TeamViewer.au3 UDF * JavaManagement UDF * VIES over SOAP * WinSCP UDF * GHAPI UDF - modest begining - comunication with GitHub REST API * ErrorLog.au3 UDF - A logging Library * Include Dependency Tree (Tool for analyzing script relations) * Show_Macro_Values.au3 * My contribution to others projects or UDF based on others projects: * _sql.au3 UDF * POP3.au3 UDF * RTF Printer - UDF * XML.au3 UDF * ADO.au3 UDF * SMTP Mailer UDF * Dual Monitor resolution detection * * 2GUI on Dual Monitor System * _SciLexer.au3 UDF * SciTE - Lexer for console pane * Useful links: * Forum Rules * Forum etiquette * Forum Information and FAQs * How to post code on the forum * AutoIt Online Documentation * AutoIt Online Beta Documentation * SciTE4AutoIt3 getting started * Convert text blocks to AutoIt code * Games made in Autoit * Programming related sites * Polish AutoIt Tutorial * DllCall Code Generator * Wiki: * Expand your knowledge - AutoIt Wiki * Collection of User Defined Functions * How to use HelpFile * Good coding practices in AutoIt * OpenOffice/LibreOffice/XLS Related: WriterDemo.au3 * XLS/MDB from scratch with ADOX IE Related: * How to use IE.au3 UDF with AutoIt v3.3.14.x * Why isn't Autoit able to click a Javascript Dialog? * Clicking javascript button with no ID * IE document >> save as MHT file * IETab Switcher (by LarsJ ) * HTML Entities * _IEquerySelectorAll() (by uncommon) * IE in TaskScheduler * IE Embedded Control Versioning (use IE9+ and HTML5 in a GUI) * PDF Related: * How to get reference to PDF object embeded in IE * IE on Windows 11 * I encourage you to read: * Global Vars * Best Coding Practices * Please explain code used in Help file for several File functions * OOP-like approach in AutoIt * UDF-Spec Questions * EXAMPLE: How To Catch ConsoleWrite() output to a file or to CMD *I also encourage you to check awesome @trancexx code: * Create COM objects from modules without any demand on user to register anything. * Another COM object registering stuff * OnHungApp handler * Avoid "AutoIt Error" message box in unknown errors * HTML editor * winhttp.au3 related : * https://www.autoitscript.com/forum/topic/206771-winhttpau3-download-problem-youre-speaking-plain-http-to-an-ssl-enabled-server-port/ "Homo sum; humani nil a me alienum puto" - Publius Terentius Afer"Program are meant to be read by humans and only incidentally for computers and execute" - Donald Knuth, "The Art of Computer Programming" , be and \\//_. Anticipating Errors : "Any program that accepts data from a user must include code to validate that data before sending it to the data store. You cannot rely on the data store, ...., or even your programming language to notify you of problems. You must check every byte entered by your users, making sure that data is the correct type for its field and that required fields are not empty." Signature last update: 2023-04-24 Link to comment Share on other sites More sharing options...
water Posted April 21, 2021 Share Posted April 21, 2021 We need more information: Which version of AutoIt do you run? Which version of Excel do you run? Can you post the workbook so we can play with it? My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
DigDeep Posted April 21, 2021 Author Share Posted April 21, 2021 @water AutoIT version: 3.3.14.5 Excel version: Excel 2016 Results.xls Link to comment Share on other sites More sharing options...
DigDeep Posted April 22, 2021 Author Share Posted April 22, 2021 @water, not to rush but just wanted to check if anything was found on the error. Thanks again for checking. Link to comment Share on other sites More sharing options...
water Posted April 22, 2021 Share Posted April 22, 2021 „Unfortunately“ everything is working fine here. No errors. Will do some more tests. My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
water Posted April 23, 2021 Share Posted April 23, 2021 Sorry, I have been unable to reproduce your error. Could you please add a COM error handler to your script so we get more detailed error information? Have a look at ObjEvent how to add such a handler. My UDFs and Tutorials: Spoiler UDFs:Active Directory (NEW 2022-02-19 - Version 1.6.1.0) - Download - General Help & Support - Example Scripts - WikiExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example ScriptsOutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - WikiOutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - DownloadOutlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - WikiPowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - WikiTask Scheduler (NEW 2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs:Excel - Example Scripts - WikiWord - Wiki Tutorials:ADO - WikiWebDriver - Wiki Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now