Issue with Array.au3 or _ArrayUnique .au3 in version 3.3.14.1 - "incorrect number of subscripts"
By
souldjer777, in AutoIt General Help and Support
-
Similar Content
-
By dejhost
Hello ,
Here are three stepts that I would like to speed up - if possible:
STEP 1: I am generating an array, containing binary numbers up to a certain amount of digits. My script adds leading zeros, so that each number has equal amount of digits.
Example: 14 digit Binary array:
I am using the code
For $i = 0 to 2^$bit-1 ; $bit amount of digits. for example: 14 $binary = ( Dec2Bin($i) ) ; Check length of binary string $adig = $bit - StringLen($binary) ; Determine how many leading 0 have to be added $zeros = "" For $j = 1 To $adig ; add leading "0"s $zeros = $zeros & "0" Next $BinArray[$i] = $zeros & $binary ;Write binary-number to file, leading "0" Next Func Dec2Bin($D) Return (BitShift($D, 1) ? Dec2Bin(BitShift($D, 1)) : "") & BitAnd($D, 1) EndFunc ;==> Dec2Bin() AutoIt v3.3.12.0 to generate the binary number.
STEP 2: I reduce the array to unique values. In my application, the binary-numbers do not have a start-bit or end-bit. This means, that
are actually the same numbers, and only one of them is to remain in the array. All alterations aren't unique and shall be removed. Here is my code:
For $i = 0 to Ubound($BinArray)-1 ; shift through all rows For $j = 1 to $bit ; shift through all the bits If $i = Ubound($BinArray) Then ; exit before exceeding the arrays boundries ExitLoop 2 EndIf $BinArray[$i] = StringRight ( $BinArray[$i], 1 ) & StringLeft ( $BinArray[$i], $bit-1 ) $BinArray = _ArrayUnique($BinArray, 0, 0, 0, 0, $ARRAYUNIQUE_AUTO) If @error <> 0 Then Msgbox(0, "Error in _ArrayUnique", "The Error Code is " & @error & " Abort.") Exit EndIf Next Next STEP 3: Finally, I write the remaining array into a text-file.
For $i = 0 to Ubound($BinArray)-1 FileWrite($hFileOpen, $i & @TAB & $BinArray[$i] & @CRLF) Next
So my question is: any idea how to speed up this procedure? There certainly is a way to do this smarter. Btw.: Step 2 is optional.
Thanks for helping,
dejhost
-
By Massi
Hi, I have update to the most recent Autoit version. I have a little problem with _ArrayUnique function.
If I have one array with two rows. _ArrayUnique crashes. I haven't any problem if there are more than two rows. I know that seems useless use this function with two rows, but these rows are the result of a search (generally I have more than two rows).
"C:\Program Files (x86)\AutoIt3\Include\Array.au3" (2290) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:
Local $vFirstElem = ( ($iDims = 1) ? ($aArray[$iBase]) : ($aArray[$iColumn][$iBase]) )
Local $vFirstElem = ( ($iDims = 1) ? ($aArray[$iBase]) : (^ ERROR
#include <Array.au3> Dim $Test1[3][6]=[["11","12","13","14","15","16"],["21","22","23","24","25","26"],["21","22","23","24","25","26"]] Dim $Test[2][6]=[["11","12","13","14","15","16"],["21","22","23","24","25","26"]] Dim $result=0 _ArrayDisplay($Test1) _ArrayDisplay(_ArrayUnique($Test1, 2)) _ArrayDisplay($Test) _ArrayDisplay(_ArrayUnique($Test, 2)) I put a workaround that I don't use _ArrayUnique function if there are only two results
-
By czardas
This seems currently a hot topic. Anyway I have been thinking of trying out this idea for a while. This is in experimental stage and uses an old idea of declaring uniquely named variables followed by testing for their existence. I always thought it was an interesting approach. You can set the second parameter to case sensitive. R stands for Row. It returns either a one dimensional array or a two dimensional array of unique rows. Three datatypes are ignored: namely nested arrays, objects and DLLstructs. If someone knows a way to test these items quickly for uniqueness, or represent the data as binary then please enlighten me. Rows containing these items are simply just left in place. I'm not sure how efficient or what limitations this code has. Testing begins in the morning - oh, it already is morning. Meanwhile you might like to have a play with it.
; #FUNCTION# =================================================================================================================== ; Name...........: _ArrayUniqueR ; Description ...: Removes duplicate items (or rows) from a one (or two) dimensional array. ; Syntax.........: _ArrayUniqueR($aArray [, $bCaseSense = False]) ; Parameters.....; $aArray - The array containing duplicate data to be removed. ; Return values .: Success - Returns the unique array [ByRef]. ; $bCaseSense - [Optional] Set to true for case sensitive matches. Default value = False ; Failure sets @error as follows ; |@error = 1 1st parameter is not an array. ; |@error = 2 1st parameter has too many dimensions. ; Author ........: czardas ; Comments ......; Works with strings, numbers, binary, boolean values, pointers, functions and keywords (Null and Default). ; Integers of the same magnitude are treated as duplicates regardless of data type. ; All elements within a row must be duplicated (in the same positions) before removal takes place. ; This function does not remove rows containing objects, DLLStructs or other arrays. ; If you modify _ArrayUniqueR, avoid using variable names that could collide with internally generated names. ; ============================================================================================================================== Func _ArrayUniqueR(ByRef $aArray, $bCaseSense = Default) If Not IsArray($aArray) Then Return SetError(1) ; not an array Local $iDim = UBound($aArray, 0) If $iDim > 2 Then Return SetError(2) ; wrong number of dimensions Local $iRows = UBound($aArray) If $iRows < 2 Then Return ; array is already unique If $bCaseSense = Default Then $bCaseSense = False Local $iCols = ($iDim = 1) ? 1 : UBound($aArray, 2), _ $iItems = 0, $aFunction[1] = [0], $vElement, $iInt, $sName ; for each item, or row, generate unique names using word characters only For $i = 0 To $iRows -1 $sName = '' ; clear previous name For $j = 0 To $iCols -1 $vElement = ($iDim = 1) ? $aArray[$i] : $aArray[$i][$j] ; get the data contained in each element ; use non-hexadecimal characters (other than x) as datatype identifiers and convert the data to hexadecimal where necessary Switch VarGetType($vElement) Case 'String' If Not $bCaseSense Then $vElement = StringUpper($vElement) ; generates a case insensitive name segment $sName &= 's' & StringToBinary($vElement, 4) ; UTF8 [$SB_UTF8] Case 'Int32', 'Int64' ; use decimal without conversion ; the minus sign of a negative integer is replaced with 'g': to distinguish it from the positive value $sName &= ($vElement < 0) ? 'g' & StringTrimLeft($vElement, 1) : 'i' & $vElement Case 'Double' ; may be an integer $iInt = Int($vElement) $sName &= ($vElement = $iInt) ? (($iInt < 0) ? 'g' & StringTrimLeft($iInt, 1) : 'i' & $iInt) : 'h' & Hex($vElement) Case 'Bool' ; True or False $sName &= ($vElement = True) ? 't' : 'v' Case 'Binary' $sName &= 'y' & $vElement Case 'Ptr' $sName &= 'p' & $vElement Case 'Keyword' ; Default or Null (other variable declarations are illegal) $sName &= ($vElement = Default) ? 'w' : 'n' Case 'Function', 'UserFunction' ; string conversion will fail For $k = 1 To $aFunction[0] ; unique functions are stored in a separate array If $vElement = $aFunction[$k] Then ; this function has been encountered previously $sName &= 'u' & $k ContinueLoop 2 EndIf Next $aFunction[0] += 1 If $aFunction[0] > UBound($aFunction) -1 Then ReDim $aFunction[$aFunction[0] + 10] $aFunction[$aFunction[0]] = $vElement $sName &= 'u' & $aFunction[0] Case Else ; Array, Object or DLLStruct $sName = False ; set to ignore ExitLoop EndSwitch Next If $sName Then If IsDeclared($sName) = -1 Then ContinueLoop ; [$DECLARED_LOCAL] this row has been seen previously Assign($sName, "", 1) ; [else] declare each unique row as a new variable name EndIf ; overwrite the next row (assumes that the first duplicate will be found quite quickly) Switch $iDim Case 1 $aArray[$iItems] = $aArray[$i] Case 2 For $j = 0 To $iCols -1 $aArray[$iItems][$j] = $aArray[$i][$j] Next EndSwitch $iItems += 1 Next Switch $iDim Case 1 ReDim $aArray[$iItems] Case 2 ReDim $aArray[$iItems][$iCols] EndSwitch EndFunc ;==> _ArrayUniqueR Example:
#include <Array.au3> Local $aOddMix[14] = [Null, Null, True, True, False, False, Default, Default, Binary('0x0001'), Binary('0x0001'), Ptr(0x0001), Ptr(0x0001), MsgBox, MsgBox] _ArrayDisplay($aOddMix) $aUnique = _ArrayUniqueR($aOddMix) _ArrayDisplay($aOddMix)
-
By Jfish
I think there may be a bug with _ArrayUnique introduced in 3.3.14 (or it could just be me). I updated ticket #3078 with the attached files to demonstrate. If you run test.au3 against the test data file in 3.3.12 it works and you see a unique array from _arrayDisplay. If you do the same in 3.3.14 the _arrayDisplay view will be empty.
I read the script breaking changes and the updates but I don't think it should have cause this. Please let me know if I am doing something wrong.
#include <Excel.au3> #include <Array.au3> func _openSourceData() $sourcefile=FileOpenDialog("Please select source file",@ScriptDir,"All (*.*)") If @error Then ; Display the error message. MsgBox($MB_SYSTEMMODAL, "", "No file(s) were selected.") else ; Create application object Local $oAppl = _Excel_Open() If @error Then Exit MsgBox(16, "Excel UDF: _Excel_BookOpen Example", "Error creating the Excel application object." & @CRLF & "@error = " & @error & ", @extended = " & @extended) ; ***************************************************************************** ; Open an existing workbook and return its object identifier. ; ***************************************************************************** Local $sWorkbook = $sourcefile $oWorkbook = _Excel_BookOpen($oAppl, $sWorkbook, Default, Default, True) If @error Then Exit MsgBox($MB_SYSTEMMODAL, "Excel UDF: _Excel_BookOpen Example 1", "Error opening '" & $sWorkbook & "'." & @CRLF & "@error = " & @error & ", @extended = " & @extended) $sourceArray=_Excel_RangeRead($oWorkbook) _ArrayDisplay($sourceArray) $unique=_ArrayUnique($sourceArray) _ArrayDisplay($unique) EndIf EndFunc _openSourceData()
test.au3
testData2.xlsx
-
By 6105
Hi, have here some alternative method to count rows..
I can't use StringSplit coz array is already buided with _StringBetween, some tips pls,
Reproducer code:
#include <String.au3> #include <Array.au3> #include <IE.au3> $file = @TempDir&'\au3test.tmp' ConsoleWrite('File = '&$file&@CRLF) $oIE = _IECreate('http://autoitscript.com/forum',0,0) _IELoadWait($oIE) $sHTML = _IEBodyReadHTML($oIE) $wFile = FileWrite($file,$sHTML) $nFileHTML = FileOpen($file, 0) If @error then ConsoleWrite('error with FileOpen($file, 0)'&@CRLF) While 1 Local $aArray[10], $aRead = FileReadLine($nFileHTML) If @error then ExitLoop $aSearch = StringInStr($aRead,'<LI><SPAN') If $aSearch > 0 Then $aArray = _StringBetween($aRead, 'href="', '"') _ArrayDisplay($aArray) EndIf WEnd ProcessClose('IEXPLORE.EXE') FileDelete($file)
Thanks in advance for any tips.
Tedy.
-